From: Paolo Bonzini <pbonzini@redhat.com>
To: David Hildenbrand <david@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY_EV exits
Date: Wed, 5 Jul 2017 14:26:15 +0200 [thread overview]
Message-ID: <2d1de3af-5c3f-002a-60d4-129a23af265f@redhat.com> (raw)
In-Reply-To: <2c21b3a2-da45-7f87-776c-ebca59eb4e87@redhat.com>
On 05/07/2017 14:25, David Hildenbrand wrote:
>> vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV;
>> - vcpu->run->internal.ndata = 2;
>> + vcpu->run->internal.ndata = 3;
>> vcpu->run->internal.data[0] = vectoring_info;
>> vcpu->run->internal.data[1] = exit_reason;
>> + vcpu->run->internal.data[2] = vcpu->arch.exit_qualification;
>> + if (exit_reason == EXIT_REASON_EPT_MISCONFIG) {
>> + vcpu->run->internal.ndata++;
>> + vcpu->run->internal.data[3] =
>> + vmcs_read64(GUEST_PHYSICAL_ADDRESS);
> vcpu->run->internal.data[vcpu->run->internal.ndata++] = ...
I considered that, but it's very long and the initializations above use
numbers. Considering that this is not going to change very often, I
ended up with the hard coded 3.
Paolo
> So we don't have to name the position explicitly.
>
> Whatever you prefer.
>
> Reviewed-by: David Hildenbrand <david@redhat.com>
>
prev parent reply other threads:[~2017-07-05 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 10:38 Paolo Bonzini
2017-07-05 12:25 ` David Hildenbrand
2017-07-05 12:26 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d1de3af-5c3f-002a-60d4-129a23af265f@redhat.com \
--to=pbonzini@redhat.com \
--cc=david@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®