From: Joe Perches <joe@perches.com>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org
Subject: [PATCH 8/8] cls_cgroup.h netprio_cgroup.h: Remove extern from function prototypes
Date: Wed, 31 Jul 2013 17:31:39 -0700 [thread overview]
Message-ID: <2d25335e101a20b760b0cd422b24d91aef60c720.1375316912.git.joe@perches.com> (raw)
In-Reply-To: <cover.1375316912.git.joe@perches.com>
There are a mix of function prototypes with and without extern
in the kernel sources. Standardize on not using extern for
function prototypes.
Function prototypes don't need to be written with extern.
extern is assumed by the compiler. Its use is as unnecessary as
using auto to declare automatic/local variables in a block.
Signed-off-by: Joe Perches <joe@perches.com>
---
include/net/cls_cgroup.h | 2 +-
include/net/netprio_cgroup.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/net/cls_cgroup.h b/include/net/cls_cgroup.h
index 0fee061..f55c145 100644
--- a/include/net/cls_cgroup.h
+++ b/include/net/cls_cgroup.h
@@ -24,7 +24,7 @@ struct cgroup_cls_state
u32 classid;
};
-extern void sock_update_classid(struct sock *sk);
+void sock_update_classid(struct sock *sk);
#if IS_BUILTIN(CONFIG_NET_CLS_CGROUP)
static inline u32 task_cls_classid(struct task_struct *p)
diff --git a/include/net/netprio_cgroup.h b/include/net/netprio_cgroup.h
index 50ab8c2..379dd5d 100644
--- a/include/net/netprio_cgroup.h
+++ b/include/net/netprio_cgroup.h
@@ -29,7 +29,7 @@ struct cgroup_netprio_state {
struct cgroup_subsys_state css;
};
-extern void sock_update_netprioidx(struct sock *sk);
+void sock_update_netprioidx(struct sock *sk);
#if IS_BUILTIN(CONFIG_NETPRIO_CGROUP)
--
1.8.1.2.459.gbcd45b4.dirty
next prev parent reply other threads:[~2013-08-01 0:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 0:31 [PATCH 0/8] include/net: next set of extern removals Joe Perches
2013-08-01 0:31 ` [PATCH 1/8] addrconf.h: Remove extern function prototypes Joe Perches
2013-08-01 0:31 ` [PATCH 2/8] af_unix.h: Remove extern from " Joe Perches
2013-08-01 0:31 ` [PATCH 3/8] af_rxrpc.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 4/8] arp/neighbour.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 5/8] ax25.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 6/8] cfg80211.h/mac80211.h: " Joe Perches
2013-08-01 0:31 ` [PATCH 7/8] checksum: " Joe Perches
2013-08-01 0:31 ` Joe Perches [this message]
2013-08-01 0:50 ` [PATCH 0/8] include/net: next set of extern removals David Miller
2013-08-01 0:58 ` Joe Perches
2013-08-01 12:04 ` David Howells
2013-08-01 16:29 ` Joe Perches
2013-08-01 16:44 ` Eric Dumazet
2013-08-01 17:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d25335e101a20b760b0cd422b24d91aef60c720.1375316912.git.joe@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®