mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] regmap: slimbus: add support to raw read/writes
Date: Thu, 5 Jul 2018 18:39:14 +0100	[thread overview]
Message-ID: <2d2ea16e-c8b4-53b9-259e-d75e6ead4362@linaro.org> (raw)
In-Reply-To: <20180705173059.GF6227@sirena.org.uk>



On 05/07/18 18:30, Mark Brown wrote:
> On Thu, Jul 05, 2018 at 06:20:50PM +0100, Srinivas Kandagatla wrote:
> 
>> Access to codec registers is done in 2 steps.
> 
>> 1> Write page number in page register.
>> 2> access register within the page.
> 
>> This seems to exactly what struct regmap_range_cfg gives.
> 
>> Adding ranges to regmap_config along with read/write bus callbacks works for
>> me.
> 
> OK, great - that's what I was expecting.
> 
Thanks, I will respin the patch removing reference to raw in commit log 
and patch.

Are reg_read/reg_write callbacks in bus regmap redundant to read/write 
callbacks?

By the looks of it, it seems redundant, reg_read/reg_write will never be 
used if bus regmap has read/write callbacks. Just wanted reconfirm 
before replacing them with just read/write callbacks.

thanks,
srini


  reply	other threads:[~2018-07-05 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-05 11:37 Srinivas Kandagatla
2018-07-05 15:08 ` Mark Brown
2018-07-05 16:13   ` Srinivas Kandagatla
2018-07-05 16:50     ` Mark Brown
2018-07-05 17:20       ` Srinivas Kandagatla
2018-07-05 17:30         ` Mark Brown
2018-07-05 17:39           ` Srinivas Kandagatla [this message]
2018-07-05 17:47             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d2ea16e-c8b4-53b9-259e-d75e6ead4362@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®