From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F561C07E9C for ; Thu, 8 Jul 2021 01:11:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0693061CC4 for ; Thu, 8 Jul 2021 01:11:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbhGHBOa (ORCPT ); Wed, 7 Jul 2021 21:14:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53582 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbhGHBO3 (ORCPT ); Wed, 7 Jul 2021 21:14:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5847761C77; Thu, 8 Jul 2021 01:11:47 +0000 (UTC) Subject: Re: [PATCH] m68k/coldfire: change pll var. to clk_pll To: Arnd Bergmann Cc: Randy Dunlap , Linux Kernel Mailing List , kernel test robot , linux-m68k , uclinux-dev@uclinux.org References: <20210704230137.28915-1-rdunlap@infradead.org> <024360ce-41b2-c072-f399-7e87f516bfd0@linux-m68k.org> From: Greg Ungerer Message-ID: <2d31fb13-818b-7a90-4071-9c36b50527d1@linux-m68k.org> Date: Thu, 8 Jul 2021 11:11:45 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/7/21 6:32 am, Arnd Bergmann wrote: > On Wed, Jul 7, 2021 at 2:30 PM Greg Ungerer wrote: >> On 5/7/21 9:01 am, Randy Dunlap wrote: >>> DEFINE_CLK() makes the variable name be clk_xyz, so variable >>> 'pll' should instead be 'clk_pll'. >>> >>> In file included from ../arch/m68k/coldfire/m525x.c:12: >>> ../arch/m68k/coldfire/m525x.c:29:30: error: 'pll' undeclared here (not in a function) >>> 29 | CLKDEV_INIT(NULL, "pll.0", &pll), >>> | ^~~ >>> ../include/linux/clkdev.h:30:10: note: in definition of macro 'CLKDEV_INIT' >>> 30 | .clk = c, \ >>> | ^ >>> In file included from ../arch/m68k/coldfire/m525x.c:21: >>> ../arch/m68k/include/asm/mcfclk.h:43:27: warning: 'clk_pll' defined but not used [-Wunused-variable] >>> 43 | static struct clk clk_##clk_ref = { \ >>> | ^~~~ >>> ../arch/m68k/coldfire/m525x.c:25:1: note: in expansion of macro 'DEFINE_CLK' >>> 25 | DEFINE_CLK(pll, "pll.0", MCF_CLK); >>> | ^~~~~~~~~~ >>> >>> Fixes: 63aadb77669a ("m68k: coldfire: use clkdev_lookup on most coldfire") >>> Reported-by: kernel test robot >>> Signed-off-by: Randy Dunlap >>> Cc: Greg Ungerer >>> Cc: linux-m68k@lists.linux-m68k.org >>> Cc: uclinux-dev@uclinux.org >>> Cc: Arnd Bergmann >> >> Thanks Randy. >> >> Arnd: since this has hit mainline do you want me to pick it up >> in the m68knommu git tree and push to Linus from there? > > Yes, that would be good. Sorry I completely missed the bug report and the > earlier fix. No worries. I'll take care of it. Regards Greg