From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012065.outbound.protection.outlook.com [40.93.195.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A64B3E16BD for ; Wed, 3 Jun 2026 16:14:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.65 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503304; cv=fail; b=YHnGOkzIBt0YqxkTI86muZZXrPwMldh1CN0E5CWIQDRaseJrQT9sFmH8XYxca/TWySnzTpezeekrEpbaxMrdmHw5rMplQUlN5ClimU1pPI+u+6cHerT9uHOC5/nLsvjkmENlWhbQtwiX905H2QBCxF8l5yf3AYAOB/0a/+DiROM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780503304; c=relaxed/simple; bh=j1IePAQYXilh1Y9VZHsUpP3ebQBi+3bpFFhLGe6Hi3s=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=OdTSunG5dOh/luE/KT3usgFpvhuwISD9gbz5aOXKwltuF0mVAYcRJPfrUZcD9O24z1NucYnUkdNBtbrnn6JzfCv4ouKPJI5nlabJLW+aYoEKozp8H/DBEvZbkHuijjVZAJc94eDLyesD/bemXwn5jAC995LV+WuI0nWXhVFy9es= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=SQ4nWiVa; arc=fail smtp.client-ip=40.93.195.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="SQ4nWiVa" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZYOmrbLTCuDaNl2u/9+c4dgM3E7vx6kErCGMrYQYFN9AccrSanAJyKyoReqEr9hNVFZhkncFxpo2p47sZSZurjUynZekKxYIDMoDdXtP6fQy6xhQUhtsUuGoEsAnMbTMHs0Jh2oLLzSllytm7BCKp1xk7DrBhpdYycG9vxJ2DXxY0uBe79gn9X8TSkHJjS13oHNR22KLdMo9YoT7t729K0I674rsREkhgtL+MqWq5VZ3/BpuNYds99xlEm+8NLGi4MK3Xh4EH+6gJLW7twM+p1KRmWkTckst/M1RdwYWv0lFs53jhK3LQZc4ALNbv9KTEJBtuhabXoqRCILv8Y4UPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IgTOdyrPRtp/EPZXngGY9YhlymrY3znLb3p5uhkYV7I=; b=nCw26fyJDD38l33lSbgpumPI/bEX9/lEwoNRa2pQIWa8PSv4VcPA5oOzoxE0BtKyJAyRhwZxxMVXOrUmuL9m193Z52euxS5vyPMvf1Oj4J8i053AOIHE+Sra88bKr8c4pagnHm0DrjOHQGQ4ZXVr2w6jERkfs9G0zBi+UWPa6LTJVqKKERCPjy8i5GQtDMRBOfuRdrlxiwqXeXg4md+kcNtL2TAr+JIvSf+9MYHaioNsO16kBccpKhWaWC1UisyQtnn6QrP/a4Gjv4anvAjuRuubfwELylSH/JhziZXBbmCU1pDtcf+TE5Fda4UljcEdjoCnfIK7zNb1wo02dglnnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IgTOdyrPRtp/EPZXngGY9YhlymrY3znLb3p5uhkYV7I=; b=SQ4nWiVakCe4BWRCNovCworC2d8HEWJzsfUS0IuLAP7CUI/d29qr5TER3sURUXYbDtvqptpA3LHbmW0s3PkGUlG4H88MsxApCB0ruQ4TnFmlnV9/MxW8WJB0G5xj0YnB1ONj/5CotxL2UEf2AWZ8OPeEXImy1GqACVZTyAEAt1o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) by CYXPR12MB9428.namprd12.prod.outlook.com (2603:10b6:930:d5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.92.7; Wed, 3 Jun 2026 16:14:52 +0000 Received: from DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::1f4e:98f9:2c94:8e4e]) by DM4PR12MB5389.namprd12.prod.outlook.com ([fe80::1f4e:98f9:2c94:8e4e%4]) with mapi id 15.21.0092.006; Wed, 3 Jun 2026 16:14:52 +0000 Message-ID: <2d3847f6-0245-4628-8254-30496fb04e34@amd.com> Date: Wed, 3 Jun 2026 09:14:50 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] fwctl/pds: propagate actual error code instead of hardcoded -ENOMEM To: Jackie Liu , brett.creeley@amd.com, dave.jiang@intel.com Cc: linux-kernel@vger.kernel.org References: <20260603012219.90498-1-liu.yun@linux.dev> Content-Language: en-US From: "Creeley, Brett" In-Reply-To: <20260603012219.90498-1-liu.yun@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR04CA0047.namprd04.prod.outlook.com (2603:10b6:303:6a::22) To DM4PR12MB5389.namprd12.prod.outlook.com (2603:10b6:5:39e::8) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5389:EE_|CYXPR12MB9428:EE_ X-MS-Office365-Filtering-Correlation-Id: 7096f400-8501-4cd0-1f37-08dec18b3e20 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|22082099003|18002099003|6133799003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: Iojw9LZQCVvbBI51fPixzzy/wQSVs1pCIwz5WA6xX72B3l5JL83pu7uyLf9ekRRSTqsux8i7caUUQWuhDQDcUUhItNZbO5l7LqoPv5xhhOckeSg9/eebZgRCpG0Y0DXZGLq74amRXo9t5vqroHQJLIVjUO1zrAJuF++8/xDD+MUfu4w3G1M4f4r2Rnx6T5+NSvcxLlLRzpPdfDC0E0VJxcj69JNosEtHy1W5VjI/KgWelmiMkNWFY/XOvRDZMGnLaEAx+o6RWMzdDOP3XnA81UCnNN6DX8wmw6kp3FPNL2UWu2Hi9rD79jTjlClor0R53eMj28d/0921TsWQb5OKWUjYH6QtQeROiD3enNXtNtEvX2UVTlFxez6Cu02IGorkyexc8/wB6pAHfX++71hRZPzIP5m/eK2LpaOnO7UH8uiSbxZjBx5H3h9xWi5zfNCJbpuvt+qoK9kuim+Ebw15oPrJ9guGT1ATezqSPWQgoycYdCORBr7sBkQco0TzGxHlz8j9Fwrcs5qhProp8el5Bq7wJ8pgvlF2mTEN1PJ/cOXJ7KW2B9WnblrH7GvBAaAnQL45DB1DDkef4SEY8Oumna0I10EES7nio9/3n1mIJxurEhYaE6LISoZY7SmeYiAft1Uzajq1FMfiV6yKiDAp1U/Gqk9ezPCItxPjE1RP9iyjdGKi04QfOa5Bicv9Egtd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5389.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(22082099003)(18002099003)(6133799003)(56012099006)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDNoaEplMk4wc0dyQmg5MzZFVzR0cnJRYjdneU1PUzNlUzRvTjhjMWlpbmVq?= =?utf-8?B?K0R6MXdMWDNTcmhaOGtxNmtQOHIxSGovQ1dtNVZnRFRuYlJ3eU44eGxGeFNt?= =?utf-8?B?dmF6SFJ1dnQ4NlNBdTZUTTFTQy9TSUhMVmEwRkl4WGNPeUR2TkNzZER4M2cz?= =?utf-8?B?ZmU3YzdhcWtDYUF4bUlpTWRzR1BnQS8rNWp4dEZpRFQyZDArTzM3MWVsS2o0?= =?utf-8?B?Y1F3aS9SejdzRzlNR29LQ1UxcWE0TmFqaDFld0FYM0kyUWZzOStzVUpRQW9l?= =?utf-8?B?TGFsVFh0eEVXRC95cmkzZWpJTVh2V3FvYVlDVXYvVllMR3c0bVhIdmRDQzRa?= =?utf-8?B?SUlSUkVLTzRpVlhvRXNzVWswamdla1B2RTdUQk1Qd2I4TDkyREZpOEF5RXFQ?= =?utf-8?B?MGFEbHFSOUhpNFl3blozVFE3a0EzK1NXRVVJTDFWbnNnYy9xUGZneFJrMmQ2?= =?utf-8?B?NDI3QzdqQUlNMEN1WVhJTmsvVlFvc1BabUxVcFRUbEY3Uk9kSEpZWjJqREJn?= =?utf-8?B?dFBscndOSkZBenQrRjh1aXFTYWJMOUxTalJVemdUU0Y5VGdrQ2FuMXh2QXE2?= =?utf-8?B?ZHJTdmdIOVNpbWxkRXh3WVJiVjZFaHRNUmxubk5lRnFlWUVmSGloUGRHY1hq?= =?utf-8?B?bGNRMlZhRjdKMDRmSkxkYTJIQ3Q4UnVaaXNYRHJXUEsvVmJmd1poVUh5UXpD?= =?utf-8?B?VEh1NzdsNklBNjUrZXJaOE9sVFM4ZU9ZdGxhWS9RU0RJRkNCRWtoMTFTWEdv?= =?utf-8?B?eWZ6U210b0wyNFBmdWhLdVg4M05GMzZxaUhlczFtVFhTbllGKzhOTlV1ZEpY?= =?utf-8?B?UFd2bkpzVGlkekI0dmVzYjU2a2tab2NGdlBMOFh3ZFpwYk8rcHRLSlVEKzVJ?= =?utf-8?B?dEZpTUtHUDhWUGtXQUxEK0R2S1dSbWhVTERERXkyem15NzFBOWg1eUJRMWlS?= =?utf-8?B?M2xmMW81dDBEd1dOSXY0WDJoSlc4VTJGN05ka296dmVEQXllYzBodzFtYmp2?= =?utf-8?B?di9OL1ZMRUVjVS9CeGxXQjJTaDNyREFkTHk3eDZnWFpRYlNZQkY1RW9PRDJl?= =?utf-8?B?R0hoV1M2bC9CTFpsZHZncjBHaTN4SHdLVnptZnhEZGFMVlkwNnpuVlgrdHJs?= =?utf-8?B?ODZLUytuRmZRbXlzanFCV0Q1WlU0aElqa2hIVHpoODhsalBJNS9JWTRXekZS?= =?utf-8?B?OUNrM3FKTzdmUkNhc3BtVjh0RnVkeWFEWHlPdWhRbHl0Tm9KR1gwRjYxL0Zv?= =?utf-8?B?bXN1WHNxVm9JSmhlVGd6clZFeGdxREJSZnh0dUJMUjBOYzN2SEs4bm1oSjR1?= =?utf-8?B?ejU3R1haaTgwY3FIbW43OTJQdXlJM3E3SGlQdVFZSWt4cXFGdWNIbk9RWmt4?= =?utf-8?B?YUdCdVVVMkdEbUFFVzB4N01zK2ttWmVKZmx2akxpMTFyL1lySmJ1blQvWDdB?= =?utf-8?B?dTZuK2g2SEdMSERObUFjNGhmVGdZRDB6YmVXc2JtYVMwRSsxcXdoS25oOFRm?= =?utf-8?B?aGl2SmFodEQxK1QyS1luTGJURmxzUHIyZyt0TVhyLzJhY3NPYi9SSVFoci9G?= =?utf-8?B?RWRiRVdzVGNhNjFPK1RBZDZ6NW9FVmZ3Tm4vdFlEaEI1eHRaRmxVbkZ2SHow?= =?utf-8?B?QUh3a1FWeFV4VHhqVE9pWGcrWktsbTM0VWdnYkNXYVhtSGh2SVM1amFnMC82?= =?utf-8?B?dEJ0YW5lUWZ1UlgyWnBuQ1FZQWJ6ckNuZWJzM3ZSSEhzOGNKTnB6Y2Jmd2Q4?= =?utf-8?B?K2xvamNjaE5hVmdHbzF0T2w1ajhqams5eHAxbjhjZlVzVVcwRnRvV0I5dXFP?= =?utf-8?B?VDN3eng5V0w3V1VzRHh5NjhWVUpJVmkwNU1VQTdROEpmL20xTUlGSHFsYUNT?= =?utf-8?B?UWhYME93eHRNZ2dSNDFqSC9qZWp4K1FLQ0NoSEI5ZUxvZTIxRDM4ZUxEV2E2?= =?utf-8?B?VXBMVzMyV21aREJaZmZWZWI3bnFmb3BoSUpURGhJUW9LemFwb3Yyb2J6WjhQ?= =?utf-8?B?SjFOaVY3N2JDemJWelhMUHlETW8yc3B4N0wzQlU4Wi9rcWUra2JZb3NLZGJn?= =?utf-8?B?eE9RQUlFMmh2WHZROGpxL3RZcG1ZcVhIemc5KzJSZWpma1EzOFMwVDNMOUZE?= =?utf-8?B?cDAyN3RhbVAxMTZQaytqSGs5ektKRUdaaWJDV3I3eUU0TkxUeXdiSXlEMVRJ?= =?utf-8?B?bTZlTEJwQVFkMzFJZUF6QXdkMDRpWU9xUmhhb0hWdStGY3REc040VUVMR2Rt?= =?utf-8?B?RHphQ3hXQmZMT3NmQVlKQUJpTVVLbWxxZXQ1aU1BM2VHTEFWMzdrU2dVYTV2?= =?utf-8?B?SzFrTWxmZFJPUGtEblpFS0xyQmpxRHNpYmxEUzVNaWlnaDRNKzMrQT09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7096f400-8501-4cd0-1f37-08dec18b3e20 X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5389.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2026 16:14:52.1682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hB94TPCtEc9aCECz5kuRwPyIAJS99U7NG0qB5m8cdrfYs/afYx6HyVpdZsx96yPtsZF1jflBeO8GrkHusAajgw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9428 On 6/2/2026 6:22 PM, Jackie Liu wrote: > [You don't often get email from liu.yun@linux.dev. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Jackie Liu > > When pdsfc_get_operations() fails in pdsfc_validate_rpc(), the > function hardcodes the return value to -ENOMEM regardless of the > actual failure. pdsfc_get_operations() can return various errors > from the adminq command (e.g. -ETIMEDOUT, -EIO, -ENODEV) or from > DMA mapping failure (-ENOMEM). Propagate the actual error via > PTR_ERR(operations) so userspace and debugging tools see the correct > failure reason. > > Fixes: 92c66ee829b9 ("pds_fwctl: add rpc and query support") > Signed-off-by: Jackie Liu > --- > drivers/fwctl/pds/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fwctl/pds/main.c b/drivers/fwctl/pds/main.c > index 68fe254dd10a..a4e80cfa3c50 100644 > --- a/drivers/fwctl/pds/main.c > +++ b/drivers/fwctl/pds/main.c > @@ -325,7 +325,7 @@ static int pdsfc_validate_rpc(struct pdsfc_dev *pdsfc, > rpc->in.ep); > if (IS_ERR(operations)) { > mutex_unlock(&ep_info->lock); > - return -ENOMEM; > + return PTR_ERR(operations); LGTM. Thanks for the fix. Reviewed-by: Brett Creeley > } > ep_info->operations = operations; > } > -- > 2.54.0 >