From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
To: Mark Brown <broonie@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Armin Wolf <W_Armin@gmx.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Linux Next Mailing List" <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the pagemap-headers tree
Date: Thu, 24 Sep 2026 22:27:04 +0200 [thread overview]
Message-ID: <2d3a3be5-557b-4f72-8ab1-8096d2a568e1@intel.com> (raw)
In-Reply-To: <arVpRvAzgfZkSHDF@sirena.org.uk>
Hi Mark,
On 9/24/2026 8:17 PM, Mark Brown wrote:
> Hi all,
>
> After merging the pagemap-headers tree, today's linux-next build
> (powerpc ppc4xx_defconfig) failed like this:
>
> In file included from /tmp/next/build/include/linux/preempt.h:11,
> from /tmp/next/build/include/linux/alloc_tag.h:11,
> from /tmp/next/build/include/linux/percpu.h:5,
> from /tmp/next/build/arch/powerpc/include/asm/time.h:14,
> from /tmp/next/build/arch/powerpc/platforms/44x/sam440ep.c:21:
> /tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':
> /tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 211 | static __always_inline void __free_##_name(void *p) { _type _T = *(_type *)p; _free; }
> | ^
> /tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'
> 31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T));
> | ^~~~~~~~~~~
> cc1: all warnings being treated as errors
> make[6]: *** [/tmp/next/build/scripts/Makefile.build:290: arch/powerpc/platforms/44x/sam440ep.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
> In file included from /tmp/next/build/include/linux/preempt.h:11,
> from /tmp/next/build/include/linux/sched.h:15,
> from /tmp/next/build/include/linux/ratelimit.h:6,
> from /tmp/next/build/include/linux/dev_printk.h:16,
> from /tmp/next/build/include/linux/device.h:15,
> from /tmp/next/build/include/linux/platform_device.h:13,
> from /tmp/next/build/arch/powerpc/platforms/44x/warp.c:11:
> /tmp/next/build/include/linux/acpi.h: In function '__free_acpi_object_free':
> /tmp/next/build/include/linux/cleanup.h:211:92: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
> 211 | static __always_inline void __free_##_name(void *p) { _type _T = *(_type *)p; _free; }
> | ^
> /tmp/next/build/include/linux/acpi.h:31:1: note: in expansion of macro 'DEFINE_FREE'
> 31 | DEFINE_FREE(acpi_object_free, union acpi_object *, if (_T) ACPI_FREE(_T));
> | ^~~~~~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
> f54586fcd661e (ACPI: fan: Use __free() to simplify AML error handling)
>
> (it was also causing lots of warnings in other GCC configurations but
> didn't trip -Werror in allmodconfig since it doesn't seem to upset
> clang.). I have reverted that commit for today.
Sorry for the breakage!
Apparently, I forgot to fix up the patch before applying it (even though
I update the changelog to that effect).
Should be fixed now.
Thanks, Rafael
next prev parent reply other threads:[~2026-09-24 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 18:17 Mark Brown
2026-09-24 20:27 ` Wysocki, Rafael J [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-08 20:53 Mark Brown
2026-08-25 13:35 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d3a3be5-557b-4f72-8ab1-8096d2a568e1@intel.com \
--to=rafael.j.wysocki@intel.com \
--cc=W_Armin@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®