From: maowenan <maowenan@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<edumazet@google.com>
Subject: Re: [PATCH net v2] tcp: avoid creating multiple req socks with the same tuples
Date: Thu, 13 Jun 2019 14:34:37 +0800 [thread overview]
Message-ID: <2d3d6b84-acaa-b98a-8454-96546fbe012d@huawei.com> (raw)
In-Reply-To: <20190612.092507.915453305221203158.davem@davemloft.net>
On 2019/6/13 0:25, David Miller wrote:
> From: Mao Wenan <maowenan@huawei.com>
> Date: Wed, 12 Jun 2019 11:57:15 +0800
>
>> diff --git a/net/ipv4/inet_hashtables.c b/net/ipv4/inet_hashtables.c
>> index c4503073248b..b6a1b5334565 100644
>> --- a/net/ipv4/inet_hashtables.c
>> +++ b/net/ipv4/inet_hashtables.c
>> @@ -477,6 +477,7 @@ bool inet_ehash_insert(struct sock *sk, struct sock *osk)
>> struct inet_ehash_bucket *head;
>> spinlock_t *lock;
>> bool ret = true;
>> + struct sock *reqsk = NULL;
>
> Please preserve the reverse christmas tree local variable ordering here.
ok, thanks.
>
> Thank you.
>
> .
>
next prev parent reply other threads:[~2019-06-13 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 3:57 Mao Wenan
2019-06-12 16:25 ` David Miller
2019-06-13 6:34 ` maowenan [this message]
2019-06-12 16:30 ` Eric Dumazet
2019-06-13 4:21 ` maowenan
2019-06-14 4:19 ` maowenan
2019-06-14 4:28 ` Eric Dumazet
2019-06-14 9:35 ` maowenan
2019-06-14 12:27 ` Eric Dumazet
2019-06-14 14:03 ` maowenan
2019-06-14 14:25 ` Eric Dumazet
2019-06-14 14:34 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d3d6b84-acaa-b98a-8454-96546fbe012d@huawei.com \
--to=maowenan@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®