Re: [PATCH V2 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads

[Jon Hunter <jonathanh@nvidia.com>]

On 21/11/16 12:49, Laxman Dewangan wrote:
> 
> On Monday 21 November 2016 04:38 PM, Jon Hunter wrote:
>>>
>>> I had a discussion with the ASIC on this and as per them
>>>      1.8 V nominal is (1.62V, 1.98V)
>>>      3.3 V nominal is (2.97V,3.63V)
>>>
>>> I am working with them to update the TRM document but we can assume that
>>> this information will be there in TRM.
>> My feeling is that if all use-cases today are using either 1.8V or 3.3V,
>> then may be we should not worry about this and only support either 1.8V
>> or 3.3V. I would be more in favour of supporting other voltages if there
>> is a real need.
> 
> Sometimes, the regulator will not return exact 1.8V or 3.3V due to the
> PMIC rail resolution. On such cases, it returns nearest voltage to 1.8V
> or 3.3V.
> That's why the PMIC resolution is considered through IO pad voltage
> tolerances.

Ok, gotcha. I can see that would be the case for when you call
regulator_get_voltage() (ie. in the probe), but what about the notifier?
I imagine that in the notifier, at least for the pre-change case, that
the voltage is the target and not the actual. So I am wondering if we
need to check for a range in the notifier?

>>>>> +    const struct pinctrl_pin_desc *pins_desc;
>>>>> +    int num_pins_desc;
>>>>> +};
>>>>> +
>>>>> +struct tegra_io_pads_regulator_info {
>>>>> +    struct device *dev;
>>>>> +    const struct tegra_io_pads_cfg_info *pads_cfg;
>>>>> +    struct regulator *regulator;
>>>>> +    struct notifier_block regulator_nb;
>>>>> +};
>>>> Is this struct necessary? Seems to be a lot of duplicated information
>>>> from the other structs. Why not add the regulator and regulator_nb to
>>>> the main struct? OK, not all io_pads have a regulator but you are only
>>>> saving one pointer.
>>> Yes, some of IO pads support multi-voltage.
>> Yes, but I am saying why not put this information in the main struct and
>> not bother having yet another struct where half of the information is
>> duplicated.
> 
> For regulator notifier callback, we will need the driver data. If I keep
> this in the main structure then I will not able to get proper structure
> until I make that as global.
> 
> The notifier registration is
>                 ret = devm_regulator_register_notifier(regulator,
> &rinfo->regulator_nb);
> 
> 
> and from the pointer of rinfo->regulator_nb, I will get the rinfo as
> 
>         rinfo = container_of(nb, struct tegra_io_pads_regulator_info,
>                                      regulator_nb);
> 
> if I use this in main structure then I will not be able to get the
> driver data.

Ah yes, you have an array of regulators. Make sense. However, shame to
duplicate some of this data and also would be good to avoid allocating
so much memory in probe for these structs if only a few rails actually
have regulators ...

  tiopi->rinfo = devm_kzalloc(dev, sizeof(*tiopi->rinfo) *
				soc_data->num_pads_cfg, GFP_KERNEL);

Cheers
Jon

-- 
nvpublic