From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752341AbdA3KUj (ORCPT ); Mon, 30 Jan 2017 05:20:39 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35904 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751800AbdA3KTe (ORCPT ); Mon, 30 Jan 2017 05:19:34 -0500 Subject: Re: [PATCH] lightnvm: free properly on target creation error To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1485446259-2396-1-git-send-email-javier@cnexlabs.com> Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <2d46b6b6-4339-a51d-a3fb-1de70b48fe82@lightnvm.io> Date: Mon, 30 Jan 2017 11:19:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1485446259-2396-1-git-send-email-javier@cnexlabs.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/26/2017 04:57 PM, Javier González wrote: > Fix a memory leak when target creation fails. More specifically, free > the entire device structure given to the target (tgt_dev). > > Signed-off-by: Javier González > --- > drivers/lightnvm/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index 8baae61..d5bb5e1 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -309,7 +309,7 @@ static int nvm_create_tgt(struct nvm_dev *dev, struct nvm_ioctl_create *create) > err_queue: > blk_cleanup_queue(tqueue); > err_dev: > - kfree(tgt_dev); > + nvm_remove_tgt_dev(tgt_dev); > err_t: > kfree(t); > err_reserve: > Thanks. Applied.