From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 689F13AE195 for ; Sun, 28 Jun 2026 14:34:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782657251; cv=none; b=nghWEUtgH1n2MO2D/PfRzYASR17md3mtkt4zYK+nQWRBPlKBfUkXzxKKFP2AK8BZf1gl/eTw3Wkxd6ZqaysBiNCDHdwqlzGeoOLp7BOj/8/CxXZw82zJMPgRSxLlr2KYVjeYexAoMlm0PivdDVjnKrgL2GkpAyZJSwuDJjH0MXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782657251; c=relaxed/simple; bh=X6xTrQxudXyfaxRG5i5at9fGETYdYW9TPIX+19qLRA0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kF5HfC84Rv0Eh7u0B9a8+k+0025BPynhOI7cxz+lKBstZd0V0x1HFWegP02CdpV71/4Mm3DX8KhLxnWlIUn1TKaH5e2w/DC8NJLv920fTFNf+//uERLUexkW8sVA15ZXUcKbFFbF5iLKnJJbINqBROACCoDouaeUtLbYBS+bw7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=U+W+wWC9; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="U+W+wWC9" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-44758ab7c60so1330670fac.2 for ; Sun, 28 Jun 2026 07:34:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1782657241; x=1783262041; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rbOALEGU5h8PEFBnFCtxCFFHr0Kpct0HuRmpjhNUHoM=; b=U+W+wWC90+08sqwmHduYxuzf1J/+3Ncak4wgsZzWL09RyEzodgFuA5vkHGRJn732tb xDFP5b3YPxNnSIaW4OkMAIT+am1WZ1Ck9eTZW06b1ay/6ArwyPxkown4is3zhE9zAzih FCYeXCccclJ8cth88iE8suAZoEorG6e9jNR+8MGVgwvuRS+NvJb4doZ3pj0t2UKeULQe NDbxHEyPskqURU0mAPUyYeuaRNYKfy7usIa/QgH+Eub5/EIh/xZ5ftaTpk208PobHsh+ tIXPjBqqx9hRt4xlrA9+ZwfGjuiw0N0+7UE9EWqUthDeRJKy3GflgDxLOFC2OWZGrmuH o3eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782657241; x=1783262041; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rbOALEGU5h8PEFBnFCtxCFFHr0Kpct0HuRmpjhNUHoM=; b=YkLdwK1UnSXYzPO/fD3UlOjvrNK18hvkw9dUQ4EgD4bXuwq40YAWLcHJfncmwOOk6E cUKpE9T47QQeenywKwFrZZK4XmScp2748cO8MgzlpbqYvPYXyMItwvrqkhSSkiMidESw AgccLkFp3xPezaqFy/q5n8ynEZiBrABhI0h9OtQaeMl1WSZMqNzoU0KsvuJnhzyb6qVa N9TX7H7nGqoCEZqmltBDLJWN87ZLX/OBmNAxA8n1hVzbe5h0ClMlLNw/60QO5lk/rPNT 1njaxtMfDhUEdHeMYkxUOj4uUv++NFXzuTy+2w79VPJ4VUsoYcGKWfelzzMiAw0LkjZn FOww== X-Forwarded-Encrypted: i=1; AFNElJ8yv4YUpcFnNGepHdWan3U2vf1yq8reY0H92oPUTg/nJakuMWArSbRJT/toIHGXWtCFOrCEQvI1lHqMdeA=@vger.kernel.org X-Gm-Message-State: AOJu0YwF3OzhUma5c0RT5QWgV2BeNjR9rX/MEEr0037FmAW+0xlIxue8 AGvoGwjERY9RoRXeIKSBmO6jTpFbN6oh2NzVQ3Jpi1TbZyJm4i7znw2XnPHMknyTpHY= X-Gm-Gg: AfdE7clrW81EcnOAKJaHK/tX4P9nyi+Vje6Z1b4FbSLvguVJ3oEosSw/qseTmJsjuHU Bd0oljEpgspNSe7SFHrNw2E0GqMpXdiToZ9PIvzW9xlCy0vrQpytJvYzzgZnmP95jj8SX3AaV2P OqzJNpgf2u825HtfHduRQpUlnjHNTi47/dyTrpeat9z16UB4NT73/W7FRVQO4Y3NdF0OzdlGVKt zut6RgHlBCnjr2Q74EsJfBlVJRJislO6q9YYCDUxAZEinMxKyecAGfZNy0ZSlVK4Kt7NhOTJ7OD KRtxtCCazeZXO9pEz2o0khvmj9NuATCyHCgGVd17r30kHF4baChUkkLJiN9OAb+z5EQgLjg5xG0 SRv8jKpC3AWn5iWSc/wrsoZzh5KV+RcLJ+2NKbYrBHbe4HZcZc6DwYIvHZVcb2J14a+BFqU3BQ+ KcIeVhbuSKevIVNStY/yWrVALi9MbGdksbuTvIUPIhBpyEzE7dp9abD7sFTANkL/E= X-Received: by 2002:a05:6808:c191:b0:492:c931:4d74 with SMTP id 5614622812f47-492c9316c3cmr10168764b6e.28.1782657241453; Sun, 28 Jun 2026 07:34:01 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:f242:ecd6:f61e:d764? ([2600:8803:e7e4:500:f242:ecd6:f61e:d764]) by smtp.gmail.com with ESMTPSA id 5614622812f47-49352b057dasm4998783b6e.6.2026.06.28.07.34.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 07:34:01 -0700 (PDT) Message-ID: <2d478d88-807d-4eed-bcd1-a829d3cd12b6@baylibre.com> Date: Sun, 28 Jun 2026 09:34:00 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] iio: adc: ad7779: Remove unused completion field To: Joshua Crofts , Moksh Panicker Cc: jic23@kernel.org, nuno.sa@analog.com, Michael.Hennerich@analog.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org References: <20260627192638.5623df0e@systembl0wer> <20260628071405.51030-1-mokshpanicker.7@gmail.com> <20260628134154.39236df8@systembl0wer> Content-Language: en-US From: David Lechner In-Reply-To: <20260628134154.39236df8@systembl0wer> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/28/26 6:41 AM, Joshua Crofts wrote: > On Sun, 28 Jun 2026 07:14:04 +0000 > Moksh Panicker wrote: > >> struct ad7779_state contains a completion field that is initialized >> in ad7779_setup_without_backend() but never waited on or signaled >> anywhere in the driver. Remove the dead code. >> >> Suggested-by: Joshua Crofts >> Signed-off-by: Moksh Panicker >> --- > > If you're sending a patch series, please use a cover letter (if > you're using git send-email, add a cover letter with the > `--cover-letter` flag) where you can describe your changes in > detail, along with additional useful info (testing etc.) Also, please don't send new series or revisions of a series in reply to other series or previous revisions. It breaks existing workflows and tooling. > > Nevertheless, > > Reviewed-by: Joshua Crofts >