From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753042AbdBAQwC (ORCPT ); Wed, 1 Feb 2017 11:52:02 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:41690 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbdBAQwB (ORCPT ); Wed, 1 Feb 2017 11:52:01 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Wed, 01 Feb 2017 08:51:54 -0800 From: Stefan Agner To: Felipe Balbi , Greg KH Cc: andrzej.p@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fs: configfs: use hexadecimal values and new line In-Reply-To: <87o9ym2sih.fsf@linux.intel.com> References: <20170201021917.27398-1-stefan@agner.ch> <20170201021917.27398-2-stefan@agner.ch> <20170201080706.GB17968@kroah.com> <87o9ym2sih.fsf@linux.intel.com> Message-ID: <2d492b1c2c0ccd45e14448bcc6d95cc1@agner.ch> User-Agent: Roundcube Webmail/1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-01 01:02, Felipe Balbi wrote: > Hi, > > Greg KH writes: >> On Tue, Jan 31, 2017 at 06:19:17PM -0800, Stefan Agner wrote: >>> Other unsigned properties return hexadecimal values, follow this >>> convention when printing b_vendor_code too. Also add newlines to >>> the OS Descriptor support related properties, like other sysfs >>> files use. >> >> configfs is not sysfs, so watch out, you might not need/want those new >> lines as tools read the values and are not expecting them. >> >> Have you verified that nothing will break with this? How have you >> tested it? I am actually writing OS Descriptor support for libusbgx (fork of libusbg) when I stumbled upon this. The helper function there do not care about the new line, but I just thought we should fix it for the sake of coherency to the other properties. I am also fine dropping this patch. > > I would rather not change things like that, specially since Android guys > are alreadying using configfs. Do you happen to know where the source of that part is? So we could check if they make use of any OS Descriptor support yet... -- Stefan