From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9D9142F8EA5 for ; Wed, 24 Jun 2026 15:19:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782314351; cv=none; b=A7qZMaCtrg7XQe6HTbg/dOIL8MVTRX4D6HnxM72VvbiDmAyMR52OIzHCCE6L2f7HB7mcAQNsQWD56C38m+CWRWMhQ9rjcRl8+QVVNS6rrV9mTW6RyhfE61AVbflhM4hs9tO40uMMsiQMrjsfA7n6p7nxkssLFNbisB3PdINV51M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782314351; c=relaxed/simple; bh=yMU1xAW7VCLIeDPTW+Y/l8HNR8dMHkFt4p4XaemorO4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=e60uT6XmRmyx/eHbdf6e4oWmtcuapJxYOXs7SkIxas4ArDnKJcqA9/l3mCkt8CFLuRRmHE6YQ7jVYu9vHgK7vi0sCFElUgWKPA+YyDaxKAh8JiYN+5gadOmiOQpukuZX7UJ74q2aCM1HeG2xMp5dPmPOEOqZPeg/ugkNOXTOtZ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=IDggzKwH; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="IDggzKwH" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6A5AB2308; Wed, 24 Jun 2026 08:19:05 -0700 (PDT) Received: from [10.57.80.146] (unknown [10.57.80.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C401B3F905; Wed, 24 Jun 2026 08:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782314350; bh=yMU1xAW7VCLIeDPTW+Y/l8HNR8dMHkFt4p4XaemorO4=; h=Date:Subject:To:References:From:In-Reply-To:From; b=IDggzKwHyOv+/3e1mWxdEbYynKeessxJnubIw91Kperm7fXpM7lNSsQE1g5FzhP9B gr9FwCxr4Rj0H4s9Oponq6VpSUUlt18B+eJ4+duI0MPZBEEJgn6GkS1ayL9gIZolYR oqCZBwPQLG+zwtnOWuev5zopPr+mHcXWB3aGrqLA= Message-ID: <2d4c1f13-f3c5-4a45-82d6-7d6441957eb0@arm.com> Date: Wed, 24 Jun 2026 16:19:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/panfrost: include panfrost_drv.h for panfrost_transparent_hugepage To: Ben Dooks , Boris Brezillon , Rob Herring , =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260623104617.768289-1-ben.dooks@codethink.co.uk> From: Steven Price Content-Language: en-GB In-Reply-To: <20260623104617.768289-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/06/2026 11:46, Ben Dooks wrote: > The panfrost_transparent_hugepage variable is declared in panfrost_drv.h > but the panfrost_drv.c does not incldue this header. Fix the following > sparse warning by including panfrost_drv.h : > > drivers/gpu/drm/panfrost/panfrost_drv.c:958:6: warning: symbol 'panfrost_transparent_hugepage' was not declared. Should it be static? > > Signed-off-by: Ben Dooks Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 784e36d72c2b..36cc2e67a308 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -21,6 +21,7 @@ > #include > > #include "panfrost_device.h" > +#include "panfrost_drv.h" > #include "panfrost_gem.h" > #include "panfrost_mmu.h" > #include "panfrost_job.h"