From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Colin Ian King <colin.i.king@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] thermal: lvts: make some read-only arrays static const
Date: Tue, 17 Oct 2023 19:54:25 +0200 [thread overview]
Message-ID: <2d5190ed-5c95-4278-8e70-211a71de821b@linaro.org> (raw)
In-Reply-To: <20231017171655.177096-1-colin.i.king@gmail.com>
Hi Colin,
On 17/10/2023 19:16, Colin Ian King wrote:
> Don't populate the read-only arrays on the stack, instead make them
> static const.
Why ?
> Make lvts_write_config parameters cmds and nr_cmds
> const too.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/thermal/mediatek/lvts_thermal.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c
> index 877a0e5ac3fd..b20e69cb466f 100644
> --- a/drivers/thermal/mediatek/lvts_thermal.c
> +++ b/drivers/thermal/mediatek/lvts_thermal.c
> @@ -308,7 +308,7 @@ static int lvts_get_temp(struct thermal_zone_device *tz, int *temp)
>
> static void lvts_update_irq_mask(struct lvts_ctrl *lvts_ctrl)
> {
> - u32 masks[] = {
> + static const u32 masks[] = {
> LVTS_MONINT_OFFSET_SENSOR0,
> LVTS_MONINT_OFFSET_SENSOR1,
> LVTS_MONINT_OFFSET_SENSOR2,
> @@ -400,7 +400,7 @@ static irqreturn_t lvts_ctrl_irq_handler(struct lvts_ctrl *lvts_ctrl)
> {
> irqreturn_t iret = IRQ_NONE;
> u32 value;
> - u32 masks[] = {
> + static const u32 masks[] = {
> LVTS_INT_SENSOR0,
> LVTS_INT_SENSOR1,
> LVTS_INT_SENSOR2,
> @@ -781,7 +781,7 @@ static int lvts_ctrl_init(struct device *dev, struct lvts_domain *lvts_td,
> * each write in the configuration register must be separated by a
> * delay of 2 us.
> */
> -static void lvts_write_config(struct lvts_ctrl *lvts_ctrl, u32 *cmds, int nr_cmds)
> +static void lvts_write_config(struct lvts_ctrl *lvts_ctrl, const u32 *cmds, const int nr_cmds)
> {
> int i;
>
> @@ -865,7 +865,8 @@ static int lvts_ctrl_set_enable(struct lvts_ctrl *lvts_ctrl, int enable)
>
> static int lvts_ctrl_connect(struct device *dev, struct lvts_ctrl *lvts_ctrl)
> {
> - u32 id, cmds[] = { 0xC103FFFF, 0xC502FF55 };
> + u32 id;
> + static const u32 cmds[] = { 0xC103FFFF, 0xC502FF55 };
>
> lvts_write_config(lvts_ctrl, cmds, ARRAY_SIZE(cmds));
>
> @@ -889,7 +890,7 @@ static int lvts_ctrl_initialize(struct device *dev, struct lvts_ctrl *lvts_ctrl)
> /*
> * Write device mask: 0xC1030000
> */
> - u32 cmds[] = {
> + static const u32 cmds[] = {
> 0xC1030E01, 0xC1030CFC, 0xC1030A8C, 0xC103098D, 0xC10308F1,
> 0xC10307A6, 0xC10306B8, 0xC1030500, 0xC1030420, 0xC1030300,
> 0xC1030030, 0xC10300F6, 0xC1030050, 0xC1030060, 0xC10300AC,
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2023-10-17 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 17:16 Colin Ian King
2023-10-17 17:54 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d5190ed-5c95-4278-8e70-211a71de821b@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®