mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ho Jie Feng <hjf3108@gmail.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Kalle Valo" <kvalo@kernel.org>, neo_jou <neo_jou@realtek.com>,
	Hans Ulli Kroll <linux@ulli-kroll.de>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH rtw-next v3] wifi: rtw88: usb: don't report the aggregation buffer as a frame
Date: Sun, 1 Nov 2026 03:44:13 +0000	[thread overview]
Message-ID: <2d53d5420be945fc9bdfbea5542b61db@realtek.com> (raw)
In-Reply-To: <20261030165451.365591-1-hjf3108@gmail.com>

Ho Jie Feng <hjf3108@gmail.com> wrote:
> When rtw_usb_tx_agg_skb() has more than one frame queued, it copies them
> into a new buffer. That buffer was also handed to mac80211, as one
> additional TX completion.
> 
> Report TX status only for the original frames, and free the aggregate
> buffer without passing it to mac80211.

The rtw_usb_write_port() might be failed and call ieee80211_purge_tx_queue()
to purge txcb->tx_ack_queue list. Should we check if the tail skb of
txcb->tx_ack_queue (or just check skb_head) is drv_frame=true?

> @@ -431,6 +436,9 @@ static bool rtw_usb_tx_agg_skb(struct rtw_usb *rtwusb, struct sk_buff_head *list
>                 goto queue;
>         }
> 
> +       /* report TX status only for the original frames */
> +       rtw_usb_get_tx_data(skb_head)->drv_frame = true;

If we can just check drv_frame by skb_head, just declare a local
   struct rtw_usb_tx_data *skb_head_tx_data.

> +
>         while (skb_iter) {
>                 unsigned long flags;
>



      parent reply	other threads:[~2026-11-01  3:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 16:54 Ho Jie Feng
2026-10-30 19:32 ` Luka Gejak
2026-11-01  3:44 ` Ping-Ke Shih [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d53d5420be945fc9bdfbea5542b61db@realtek.com \
    --to=pkshih@realtek.com \
    --cc=hjf3108@gmail.com \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux@ulli-kroll.de \
    --cc=neo_jou@realtek.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®