From: Guenter Roeck <linux@roeck-us.net>
To: Evgeny Novikov <novikov@ispras.ru>, Jean Delvare <jdelvare@suse.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>
Subject: Re: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt
Date: Sat, 15 May 2021 06:44:42 -0700 [thread overview]
Message-ID: <2d6122d1-e9fa-1e23-1e81-50c6ade08d2f@roeck-us.net> (raw)
In-Reply-To: <141521621084257@mail.yandex.ru>
On 5/15/21 6:20 AM, Evgeny Novikov wrote:
> Driver drivers/hwmon/pcf8591.ko declares and removes attribute group
> pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove
> it completely or to do something else?
Do nothing. Look closely at the file instead to see how the attributes
are created, and realize that the group is only used to simplify
attribute removal.
Yes, the code is a bit odd and unusual, but it is WAI.
Guenter
parent reply other threads:[~2021-05-15 13:44 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <141521621084257@mail.yandex.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d6122d1-e9fa-1e23-1e81-50c6ade08d2f@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=novikov@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®