From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbdKFKG0 (ORCPT ); Mon, 6 Nov 2017 05:06:26 -0500 Received: from esa2.microchip.iphmx.com ([68.232.149.84]:16025 "EHLO esa2.microchip.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbdKFKGW (ORCPT ); Mon, 6 Nov 2017 05:06:22 -0500 X-IronPort-AV: E=Sophos;i="5.43,434,1503385200"; d="scan'208";a="8561877" Subject: Re: video: atmel_lcdfb: Use common error handling code in atmel_lcdfb_of_init() To: SF Markus Elfring , , CC: Bartlomiej Zolnierkiewicz , LKML , References: <2db677d2-ad4e-1f79-344b-dfa38ce948c9@users.sourceforge.net> <5477205e-2067-de4f-8736-71a2c9dc1653@microchip.com> <8d297cae-5dd1-d345-8d9d-9bf3ec32d4f8@users.sourceforge.net> From: Nicolas Ferre Organization: microchip Message-ID: <2d650d87-034c-d05b-b3aa-f689f25ab184@microchip.com> Date: Mon, 6 Nov 2017 11:06:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8d297cae-5dd1-d345-8d9d-9bf3ec32d4f8@users.sourceforge.net> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2017 at 10:32, SF Markus Elfring wrote: >> Sorry but NACK: the message was malformed and resulted in the >> duplication of the error log that you spotted. >> >> The proper way to fix this is to modify the second occurrence of this message. > > * Would you like to achieve that a corresponding message will mention > anything around a property “atmel,dmacon” (instead of “bits-per-pixel”)? Yes: that would actually fix the wrong log message. > * Can it make sense to adjust the used message format then? In another patch, why not... Beware about the added complexity though. Regards, -- Nicolas Ferre