From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48055314D16; Tue, 3 Feb 2026 12:42:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770122550; cv=none; b=ASRDJD/MYttH1q/HKz6CWyf9We/aIqkeR/pX5bO6jFa/JzGhUJrz7l7FvZEyU018M76/FBccghetz1dibvJ6lW7VDHCCtz+dley2r+XRxniemHdQAQ8lrqOuqcppV7sMOokMvbJYPp1YY732pFZEaH5e1YRFTEsiy+LUt1wtqjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770122550; c=relaxed/simple; bh=+vKlgAoMgxorO8wzZsSKLOlHjUax16wakp+NL76Z0jg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R/5GoRGfw43sWg3wB4lWOYrvm/Eu2ta/2VMYF5DY7rFvEmcP+01MVFXhF4E0UzuEaTL5jZ30sVqRFSH1MqFTrJdZo2AA8KWRZ37kW08OZ4tB722qqX8LNapmTXCSxWMP6BNxgJVMHBZki4So46tE0JcwVzGOFvDysB8h7Ahqcx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=VaAFHhJc; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="VaAFHhJc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1770122547; bh=+vKlgAoMgxorO8wzZsSKLOlHjUax16wakp+NL76Z0jg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VaAFHhJc7RJThp3X+a8KljdNfBU40Qohg4ZbBihrSHkldtnS2mr7PIOYLFNNVh3m4 iwPDIMK7zHXuYYbgAnk2nZqfMp/Kc/PcVHebE1k/b71FBy78nAPYLadtFkiaM5Sf6e bpmVJeSOu/HMoajP8WRx2JjXQW/CSQtzckT5P31U= Date: Tue, 3 Feb 2026 13:42:26 +0100 From: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= To: Petr Pavlu Cc: Nathan Chancellor , Arnd Bergmann , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Nicolas Schier , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Schier , Nicolas Bouchinet , Xiu Jianfeng , Fabian =?utf-8?Q?Gr=C3=BCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?utf-8?B?Q8OianU=?= Mihai-Drosi , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 12/17] module: Move signature splitting up Message-ID: <2d6b4a2e-b65a-4db2-aa92-2ad80d066516@t-8ch.de> References: <20260113-module-hashes-v4-0-0b932db9b56b@weissschuh.net> <20260113-module-hashes-v4-12-0b932db9b56b@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-01-29 15:41:43+0100, Petr Pavlu wrote: > On 1/13/26 1:28 PM, Thomas Weißschuh wrote: > > The signature splitting will also be used by CONFIG_MODULE_HASHES. > > > > Move it up the callchain, so the result can be reused. > > > > Signed-off-by: Thomas Weißschuh > > --- > > [...] > > diff --git a/kernel/module/main.c b/kernel/module/main.c > > index c09b25c0166a..d65bc300a78c 100644 > > --- a/kernel/module/main.c > > +++ b/kernel/module/main.c > > @@ -3346,10 +3346,21 @@ static int early_mod_check(struct load_info *info, int flags) > > > > static int module_integrity_check(struct load_info *info, int flags) > > { > > + bool mangled_module = flags & (MODULE_INIT_IGNORE_MODVERSIONS | > > + MODULE_INIT_IGNORE_VERMAGIC); > > + size_t sig_len; > > + const u8 *sig; > > int err = 0; > > > > + if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { > > + err = mod_split_sig(info->hdr, &info->len, mangled_module, > > + &sig_len, &sig, "module"); > > + if (err) > > + return err; > > + } > > + > > if (IS_ENABLED(CONFIG_MODULE_SIG)) > > - err = module_sig_check(info, flags); > > + err = module_sig_check(info, sig, sig_len); > > > > if (err) > > return err; > > I suggest moving the IS_ENABLED(CONFIG_MODULE_SIG) block under the > new IS_ENABLED(CONFIG_MODULE_SIG_POLICY) section. I realize that > CONFIG_MODULE_SIG implies CONFIG_MODULE_SIG_POLICY, but I believe this > change makes it more apparent that this it the case. Otherwise, one > might for example wonder if sig_len in the module_sig_check() call can > be undefined. > > if (IS_ENABLED(CONFIG_MODULE_SIG_POLICY)) { > err = mod_split_sig(info->hdr, &info->len, mangled_module, > &sig_len, &sig, "module"); > if (err) > return err; > > if (IS_ENABLED(CONFIG_MODULE_SIG)) > err = module_sig_check(info, sig, sig_len); > } Ack.