From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDE013B6C17 for ; Mon, 29 Jun 2026 09:56:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726976; cv=none; b=iOlsZuM/Yyp0GGkAOgCpOOu5Y0M6Yo3so92m6QjjEMIG+cUpm66eyG813chQGubEShYQC1nccUyBeNbOIFdyNXfq9ptwvj79rPSNpbP30DSwfNsNYJs+VvAoKDl58gsy54wCwiIfDpi9ElZ+43nlKmiwSaX40xFDxN5pkLih96Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782726976; c=relaxed/simple; bh=TrPGv/zl/q9riZcQ557K3m/9tohKczPiBQpjOOFNp00=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YQG080mS07WKD2fQM7TRzvybn1N9T7QqH0OzCS4qgFUw8yQOJH1sWgiImAz2sDMI8z4+lxWXBj9g7CxLOjVy5ca0B1dfruADLCC0j/kQS9lK9hZbIA6pES8CYUzTE+gBOhCnUiPzJ4YYIZgZLaU1U9cWV0JwcDOfkE6f6Vp3Mjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oJu75Ot5; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bi3DO1iR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oJu75Ot5"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bi3DO1iR" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T8xg592431938 for ; Mon, 29 Jun 2026 09:56:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +GpxxFw2UM30Ce8Qa2rv3JI9XcKMO4o2jYpPU5f/yv8=; b=oJu75Ot5ed9PVbIe goukbMpUXMmZO0aBBSV6tGMj7UYIo7EI280cIOrF1hyDLCjx7cf5pGTE5FvMv0X6 UINAqxzguJvgq1PiRK/Snv6541tVOPwQ3ZnMytFJFK5XkdOeMKJN+5DZxL/RMZqh +e5kaIwY9vPgmUBMifJ5LAID4V+TgNH+9q1utRjJENdU5LTNn4G7Q1tAz2I6+Ghu /Yts4ukPx2bBtKSkC9KFcgL+UbYpd6aG/xRQHPRw36IZCSv+Lkyf1e34wsqnedxB fvcB6/M4UEQNVWWUvXu2gD0qUTHxwJiyN92xqDakvzg+ZVcxKT7sW6Ei3r9phv5p ETE3ow== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3nper82b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 09:56:14 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-51a07295d67so8306561cf.2 for ; Mon, 29 Jun 2026 02:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782726973; x=1783331773; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=+GpxxFw2UM30Ce8Qa2rv3JI9XcKMO4o2jYpPU5f/yv8=; b=bi3DO1iR0pKW8EGf/lxp1ZIfOk+Pn/RrI40R9iYEmdlM7HdkhkfYssFWLbk6A4b4XI piETdB5jf5dlX4NyGxXMxYTp90zXetJZigHOkP4bVtQ4HOI0SPx0ZQQv4wzlaD2ZhyIO ZxAYFQbfFqBTgB61km1plrDM5wZme/M5HxF4wFeY/hoYqfrlY6XfoMSzb0LDz1X92j3k EwAiGt5pLJ+32A4+ADAcFfLF4DgxmPByaXkFn++PA/rRzDZZqZF1DOgFWDAIP31sl/fL RYLyePi4iLJd5SLUexcRPPu1J6c0QJVAk/uW1BeytFUMPnnDu/6fUmc8tt27bZ/Rl5jq HPYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782726973; x=1783331773; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+GpxxFw2UM30Ce8Qa2rv3JI9XcKMO4o2jYpPU5f/yv8=; b=jTnIihd5PejdW1yMduh+YX4/z+v137JmbOgUJa1XMx2WtFqadK+3VZPkN5nMTi5OiN WZM1C3t1XRd8nzQNgkfBrqQwkLB148Okj9DEqCDeHrLMTgRCCTAimatYDA+j8HtXEtwh N8amNeGuy6D7nwvb2KOPsTXA0swRVqBaDf+LzKHRKvWBQ4dFuSwE0UGhmeNn+cZ+ai06 aZ44l9P82fdufIv/mCOnUIG3KQ09wEJsSt4FXpvhYi92gSEs2IiairR6TE36AyhJnU7u VuN6zRR7AVQNloGZRk7yWSIfyhDmf8PIAg3IikaYQmUDxrGbtut0FKCPHDXh+BCNSyja ZFfQ== X-Forwarded-Encrypted: i=1; AFNElJ/iuqwlYB9SCwEJH7d72gwJK0Zbx4R7M2TbveuP7t3qMyV9m2f5y7hc11FPk/0XjO7f6BNWMjDglL9stpk=@vger.kernel.org X-Gm-Message-State: AOJu0YxU6LEK91x7CjGhTOVXzNHlTrBXrSzMndwzbcO89Cwof8rG3uRg UTFox40+HpKGsaltHNb3f0VsanF0vABjehxO5Cw+sX7lWRpHDOhbQ3Jm/qFqcEraxNQPKb6ZY4R VZE8xVo8ito6RMmWyJJuD4Rvn69O4TNWzO6xjPnpCHTXlJzn5yuZoxIa7jZpHqPVJgwQ= X-Gm-Gg: AfdE7cl0yoLmiWgfWSZbsHkA4k0HpZzH1BwbS96i1cwAwCL2hVAgGnWbfsDaswKTM+B abCYo9RLU+U2OdNFO7Qgm5CzpcevL7CEdDjaEK20L8sDCxeAlyNK/z7UtluhTt9pthVjOCUD85a ErZBFseuAYsBHmid6luT3KLKDdNVQQCZdTB5SkVEhP0TT5NYIlDojns1fK0bMuvyAFh0yYxL4Bt louRtNWSrIoQtJa7HVAZiF8AbnoDh0fHnqEWHaVBfGaPmvOdMmt8Gs7FvzuEUCTyL8Ks0Fxl6uq 4bCTkKT01LEzYAU93E+0HPtvCVakR/gLKbAVgRfT2a60EhieU8HuZby56yHCknjbL9hRwaSvGJE VqvPK+AcIIModgPv6GCqFs9YEIdfQpcLGX2s= X-Received: by 2002:ac8:7f82:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51a8c9b94admr77692481cf.11.1782726973116; Mon, 29 Jun 2026 02:56:13 -0700 (PDT) X-Received: by 2002:ac8:7f82:0:b0:51a:8c9b:6494 with SMTP id d75a77b69052e-51a8c9b94admr77692291cf.11.1782726972635; Mon, 29 Jun 2026 02:56:12 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1252b4e6e0sm231458666b.2.2026.06.29.02.56.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 02:56:11 -0700 (PDT) Message-ID: <2d6e7b56-01a8-4b92-921d-629417c7f5c9@oss.qualcomm.com> Date: Mon, 29 Jun 2026 11:56:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] irqchip/qcom-pdc: Move all statics to struct pdc_desc To: "Maulik Shah (mkshah)" , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com> <20260616-hamoa_pdc_v3-v3-2-4d8e1504ea75@oss.qualcomm.com> <8754de51-bfbe-42f2-84bf-36cc000afa3f@oss.qualcomm.com> <91fa4b98-d99e-401c-bb1f-f235034f3aab@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <91fa4b98-d99e-401c-bb1f-f235034f3aab@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA3OSBTYWx0ZWRfX1zCcFyIElgA8 n+1b0UajFI9NWwrzRU2c2rEpQbolu1Q/tMd/cdiAQ3MhQzwu7SZFbz1FHaG9LDiTc+FyQCLvZjE 1ZCCFePo6V+tVTkXhTL9gdBhRCX4qE44Dq5WjmGMYNVTqPGPciE5tLg851vbiHrKNzc5t4C33Gy s/j1lTQKndPVa33rBqVLak+CJm6p5sP0wEwEbW8I92p6JSvVSrOyHSFmpUr0iklLBHwilNotGCz GmKKFZJy0cE1ZRSo02CxaxKT+cQkYTguR6Bp3jCScYeBJg+0EWfKjE83okOqpd6XdKWAsrQpXZU dvsmo6g3Ime++7Ch7LA1nT62ZR9Rxwi5bj7Jn+9qS24pk9k2kkbno6oZ4n+xJsn8Vd5gbBVmZk0 GA3PWTsbnp6lWhPsGt7Dws4jMqBVv5SmsIi/CG7lt1xVXnto4xNJNnqGdNWt462WR85YkOQMR9D sjxr6O18N/pNuinfjKg== X-Proofpoint-ORIG-GUID: c98PAtSwgBprezjn6WtP7nsEJem8jsCu X-Authority-Analysis: v=2.4 cv=T6q8ifKQ c=1 sm=1 tr=0 ts=6a42413e cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=hGRUbYMsCoS4gC--qvEA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA3OSBTYWx0ZWRfXxJ2GvWjhKaFI 2RTqAgRFhkD4Hwk/re7DHsfO4eaErWWtDZBkBWMschifdQYe+zTCI6jUF2ZZvIWbKEge/WRFa/x VWTadfjPVnE5AGSJp8nGcC6GAgO/1QI= X-Proofpoint-GUID: c98PAtSwgBprezjn6WtP7nsEJem8jsCu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_02,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290079 On 6/25/26 11:19 AM, Maulik Shah (mkshah) wrote: > > > On 6/17/2026 6:56 PM, Konrad Dybcio wrote: >> On 6/16/26 11:25 AM, Maulik Shah wrote: >>> There are multiple statics used. Move all to struct pdc_desc to better >>> align with versioning support. Document them. >>> >>> No functional impact. >>> >>> Signed-off-by: Maulik Shah >>> --- >> >> [...] >> >>> static void pdc_enable_intr(struct irq_data *d, bool on) >>> { >>> - unsigned long flags; >>> + guard(raw_spinlock)(&pdc->lock); >> >> tglx suggested to use guard(irq) around "the other callsite".. >> which I'm not sure where it'd be - maybe around __pdc_enable_intr() >> in pdc_setup_pin_mapping()? >> >> Otherwise this patch looks good to me >> >> Konrad > > All callers will be from irqchip except pdc_setup_pin_mapping() which was > invoking lock-less because at that time irqchip is not setup and as such > can stay lock less. > > Once the patch-3 of this series is applied pdc_setup_pin_mapping() too > will use the lock as it makes direct use of pdc->enable_intr() where the new lock > is kept (only for v2.7 version specific enable function). Ack, thanks Konrad