From: <Conor.Dooley@microchip.com>
To: <wangjianli@cdjrlc.com>, <oliver@neukum.org>, <aliakc@web.de>,
<lenehan@twibble.org>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>
Cc: <dc395x@twibble.org>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/scsi: fix repeated words in comments
Date: Thu, 8 Sep 2022 12:32:03 +0000 [thread overview]
Message-ID: <2d715e75-f145-4ba2-a951-912eedc317d0@microchip.com> (raw)
In-Reply-To: <20220908122418.11728-1-wangjianli@cdjrlc.com>
On 08/09/2022 13:24, wangjianli wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Delete the redundant word 'in'.
>
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> drivers/scsi/dc395x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index 670a836a6ba1..aea82007dd61 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -4226,7 +4226,7 @@ static void adapter_init_params(struct AdapterCtlBlk *acb)
> * values that we have already stored in the adapter instance. There's
> * some mention that a lot of these are deprecated, so we won't use
> * them (we'll use the ones in the adapter instance) but we'll fill
> - * them in in case something else needs them.
> + * them in case something else needs them.
Hey wangjianli,
Thanks for your patch.
This is not a typo, is it? With your "fix", it does not make sense
anymore. If you are running a tool, you should probably validate
the outputs before sending patches.
Thanks,
Conor.
> *
> * The eeprom structure, irq and io ports in the adapter need to have
> * been set before calling this function.
> --
> 2.36.1
>
next prev parent reply other threads:[~2022-09-08 12:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 12:24 wangjianli
2022-09-08 12:32 ` Conor.Dooley [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-22 6:45 wangjianli
2022-10-22 6:28 wangjianli
2022-09-08 13:07 wangjianli
2022-09-23 10:43 ` Wei Liu
2022-09-08 12:27 wangjianli
2022-08-21 15:27 wangjianli
2022-07-24 7:27 wangjianli
2022-07-24 7:25 wangjianli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d715e75-f145-4ba2-a951-912eedc317d0@microchip.com \
--to=conor.dooley@microchip.com \
--cc=aliakc@web.de \
--cc=dc395x@twibble.org \
--cc=jejb@linux.ibm.com \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=oliver@neukum.org \
--cc=wangjianli@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®