mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hongzhen Luo <hongzhen@linux.alibaba.com>
To: Gao Xiang <hsiangkao@linux.alibaba.com>, linux-erofs@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] erofs: fix unsupported blksize in fileio mode
Date: Tue, 15 Oct 2024 11:53:11 +0800	[thread overview]
Message-ID: <2d76e36c-95d5-4eb2-9825-fa5e739ae139@linux.alibaba.com> (raw)
In-Reply-To: <231e17e3-82c1-49f4-9cc1-b376b89205b3@linux.alibaba.com>


On 2024/10/15 11:47, Gao Xiang wrote:
> Hi Hongzhen,
>
> On 2024/10/15 11:36, Hongzhen Luo wrote:
>> In fileio mode, when blcksize is not equal to PAGE_SIZE,
>> erofs will attempt to set the block size of sb->s_bdev,
>> which will trigger a panic. This patch fixes this.
>>
>> Fixes: fb176750266a ("erofs: add file-backed mount support")
>>
>> Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
>
> File-backed mounts should support < PAGE_SIZE sizes.
> You should just fix these cases instead.
>
> Thanks,
> Gao Xiang


Okay, I will fix it later.

---

Thanks,

Hongzhen


      reply	other threads:[~2024-10-15  3:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  3:36 Hongzhen Luo
2024-10-15  3:47 ` Gao Xiang
2024-10-15  3:53   ` Hongzhen Luo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d76e36c-95d5-4eb2-9825-fa5e739ae139@linux.alibaba.com \
    --to=hongzhen@linux.alibaba.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®