From: Andrew Lunn <andrew@lunn.ch>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Andrew Halaney <ahalaney@redhat.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH 9/9] arm64: dts: qcom: sa8775p-ride: enable EMAC1
Date: Mon, 7 Aug 2023 22:03:00 +0200 [thread overview]
Message-ID: <2d88a48e-e8c1-463e-8d41-dc24e8579dfe@lunn.ch> (raw)
In-Reply-To: <20230807193507.6488-10-brgl@bgdev.pl>
On Mon, Aug 07, 2023 at 09:35:07PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Enable the second MAC on sa8775p-ride.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 74 +++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> index af50aa2d9b10..0862bfb4c580 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
> @@ -356,6 +356,80 @@ queue3 {
> };
> };
>
> +ðernet1 {
> + phy-mode = "sgmii";
> + phy-handle = <&sgmii_phy1>;
This should be all you need.
> + snps,shared-mdio = <&mdio0>;
This is not needed, since it is implicit in the phy-handle.
You need to debug why the existing -EPROBE_DEFER is not working.
Andrew
next prev parent reply other threads:[~2023-08-07 20:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 19:34 [PATCH 0/9] arm64: dts: qcom: enable EMAC1 on sa8775p Bartosz Golaszewski
2023-08-07 19:34 ` [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY Bartosz Golaszewski
2023-08-07 21:10 ` Andrew Halaney
2023-08-07 21:28 ` Andrew Lunn
2023-08-07 21:39 ` Andrew Halaney
2023-08-07 21:48 ` Andrew Lunn
2023-08-07 19:35 ` [PATCH 2/9] arm64: dts: qcom: sa8775p: add a node for EMAC1 Bartosz Golaszewski
2023-08-07 21:13 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 3/9] arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY Bartosz Golaszewski
2023-08-07 21:15 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 4/9] arm64: dts: qcom: sa8775p-ride: add pin functions for ethernet1 Bartosz Golaszewski
2023-08-07 21:18 ` Andrew Halaney
2023-08-07 21:39 ` Andrew Lunn
2023-08-07 19:35 ` [PATCH 5/9] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY Bartosz Golaszewski
2023-08-07 21:32 ` Andrew Halaney
2023-08-07 21:51 ` Andrew Lunn
2023-08-07 22:27 ` Andrew Halaney
2023-08-08 12:16 ` Bartosz Golaszewski
2023-08-08 14:27 ` Andrew Halaney
2023-08-08 13:17 ` Andrew Lunn
2023-08-07 19:35 ` [PATCH 6/9] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY Bartosz Golaszewski
2023-08-07 21:41 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 7/9] arm64: dts: qcom: sa8775p-ride: add the second " Bartosz Golaszewski
2023-08-07 21:47 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 8/9] arm64: dts: qcom: sa8775p-ride: label the mdio node Bartosz Golaszewski
2023-08-07 19:35 ` [PATCH 9/9] arm64: dts: qcom: sa8775p-ride: enable EMAC1 Bartosz Golaszewski
2023-08-07 20:03 ` Andrew Lunn [this message]
2023-08-07 21:50 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d88a48e-e8c1-463e-8d41-dc24e8579dfe@lunn.ch \
--to=andrew@lunn.ch \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®