From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751026AbdALIPh (ORCPT ); Thu, 12 Jan 2017 03:15:37 -0500 Received: from mail-by2nam01on0046.outbound.protection.outlook.com ([104.47.34.46]:60864 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750863AbdALIPf (ORCPT ); Thu, 12 Jan 2017 03:15:35 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Shyam-sundar.S-k@amd.com; Subject: Re: [PATCH] pinctrl: amd: avoid maybe-uninitalized warning To: Linus Walleij , Arnd Bergmann References: <20170111143712.510147-1-arnd@arndb.de> CC: "Agrawal, Nitesh-kumar" , Pankaj Sen , "Shah, Nehal-bakulchandra" , Shyam-sundar S-k , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Shyam Sundar S K Message-ID: <2d8a7eeb-f49a-47eb-1b74-70631c27e931@amd.com> Date: Thu, 12 Jan 2017 13:45:08 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [202.56.249.162] X-ClientProxiedBy: PN1PR01CA0061.INDPRD01.PROD.OUTLOOK.COM (10.164.136.161) To BLUPR12MB0722.namprd12.prod.outlook.com (10.163.218.148) X-MS-Office365-Filtering-Correlation-Id: ada24f1c-cd7b-4a50-85f3-08d43ac32dd9 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BLUPR12MB0722; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0722;3:9peNV2dAd3/hHdY1CUW2OiI09YnxHfP6YnFKtgYpkAV68a3BlifRYrICkkm4MMrsz1yWPVFwCwG5Psi6wrAoIMQhkR0R8FE7+7V1Jyi61/119hD1vBoSkY4FoRKwqi6hSNFWarUhE7aKJnbS1NuBiVpKVUIG/yzuM0wv2/XJhe/29C5JU4ZiTpUBuD/SZBMQo7tv0/2mJomKqAWnhkOUz4ehplZKGa/FORKMGTe84HzykF1gXYxAswjJzuMc2j5P3f3XgLmrGss7KZUNxQaApA==;25:YAz6gZ8xP5KhPgmfJvi/UgcaHUAMAEfGorx2aepoYb2N5R+ZVq1h+BniDS15bqajaAFxq8/LIRtZnkt6m/t2r+JcWVDKSdZ+44C1QD2ddrgGJyCLAg8vFIYYNU62IyHoACSm6UKylgwW+GDjSzFEdm/eaGup4JBL0N6rKgN2zlqojEcx98TKasqwdEmzuCvaY4Gq0qGtbAujmqeRykwK6u26RKVgYalp+upDiBM7xywcm4AH39Dy6OCZnHpKMEZZ0l8csYMMggQJQGicqwTW4Eb7l/5wuU5HXxMOIlZpBVsNdz5MzamIsRY1gRidQgLNOaQuL49+d7AEb9mO7e1TNMLw6UhDu4nWc69zIhVEsX+Abrjd0kDJ1Oro0x7rnbObmMOFUyCiWVxDUbN4l9AgG2rggGQuUa288cNt2ee/SYfvhDggVzXI55rjcManjurG61zFxiiDfa+Cnr8M+A2ysA== X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0722;31:S9xhqqtUxqpw/rgrP/TPn0PnRusPCdaSJEFI8YBlIr0uvZAbK4dIBp2lEAtq86xp6z0y0XU0aVFJ0DVEl9Ad3fYhQviwqf76kV4MyYBYDK3IlV0VCbujA0GIYaQij3H7Rren0W1RNt2EnMg10F+lD5R4HsVPZlc4W6Tj5d4DPk0xNuN74f74InLJZJ4zjUSsRMxaYcvg1nQHepAx5ywSX0ZPeDIxTGQdhm5VG9iFaK0EuxUVY2TokYRvzAv9KMFDmB2bn6oohDgFlAdsN7vzvA==;20:sBnmQzAjdiNary66RU2CRwKdklrWDseSw93SpEHrKMptOoIUodVFdq+JyIC+af9iF8WuuwzLpHFYr51aVr4lBW3acJFiFPXHdvXDzEheI9mTtTyVDeMI8ar6zGZOS554PVozBPcrVuS0vlcMr42MGYDro8grtQGMUbuoioZJqr0U2yQR/S2Q94jLCb6fhN33inZB5HtuLdsSDoZ6kV0nLjloTOdRGKGQgJ+PMdG9NEY3cHtblMEHyWCZCQKljbBQbKSVG3ENLwxcubL6FLPk1KdQkHYPXpkufjJrhN+3GWpuxRoTap5srC7uLRLUE446JaaPKNED1LDyMaa9y7Idn3K8r3gWgVEtd1Q/NtjV+MoUu0/ucK3VPeqKxkg1iH5wt9yMU0Z/lsaKbEchAfs2ayhTxg7+UMbOiOzQl+QEnY05kK+caPldxE0fMxNfOFzBBC++RrSc0oSfPTdLd3dwL5EAKFoEF8p3YJtYtZgQAXNJYNxxSFt0pTKPWSXifP31 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123564025)(20161123560025)(20161123562025)(20161123555025)(6072148);SRVR:BLUPR12MB0722;BCL:0;PCL:0;RULEID:;SRVR:BLUPR12MB0722; X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0722;4:PSlSDLEppTYUVkmzOkhRecm12I1bQhY3zsRYzG+qZrc7DVzC8Dw6jyQ0orRL+fCCw/hhx6HIsqkiDcOvqPRM3y3uUbiSsB/pvwjWezQfqm9Zy2vNfNkg6/3inmFI2fxotmYBXymuiYq1RnYePxKfPqMGyA4+2K4Z6nKDHtHDjsxAODDHXhfScZKdOUTDr/ZF8h4j1h/aCJaDDnizxEXTZaLNrH7oq7BpbQOZ2HnWkgoj+q/xMklMKlpMQwHTBJmamPgzYBbSKzh2wpZoYhjSSf5QoKkA4y2h4lntI+yqOvnf7wMrgcEksy1sMHgdGr+l/m58zoUUfoqRGE4hJ7mL3Zdc75ZeH6Ulfz/5gEvNstkNOwO0CKVhGf+8vJ6YBhTIrsouBSf7QYljVzAmdVqI+2SRZOOEsY19w1XM13TAie0/ze/howVApUpVCjNpmwD6f+w3XuJ4f0ltQ4rkQu3Tq4C78vtGh+Is81e5QeJbzpmvA5KJcM9g9xETVqyauBBWJjfbTIbRsyFQjRApTMUTpft3blHgGtCTqgaaf+g3wfQQ7QG1qznK/IoZL+wN3Kj6rf2AoZwvaUzoJmVPLtE4oKNG36bUPoRhjTf+Qiutm/g= X-Forefront-PRVS: 018577E36E X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39840400002)(39410400002)(39450400003)(39850400002)(39860400002)(24454002)(189002)(199003)(377454003)(230700001)(8676002)(36756003)(229853002)(33646002)(38730400001)(77096006)(25786008)(31696002)(66066001)(106356001)(54906002)(65806001)(65956001)(65826007)(90366009)(23676002)(6486002)(4326007)(83506001)(64126003)(105586002)(3846002)(50466002)(2906002)(68736007)(189998001)(92566002)(6116002)(5660300001)(47776003)(7736002)(31686004)(76176999)(54356999)(305945005)(81166006)(81156014)(6666003)(101416001)(50986999)(5001770100001)(2950100002)(42186005)(4001350100001)(97736004);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR12MB0722;H:[10.136.130.49];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjEyTUIwNzIyOzIzOi9ldHFIcHJYc1hDVTBOQ1pFMEVtdVZwNEJt?= =?utf-8?B?SFZRZmR6TEVEa2k5SnB0aFgrK3BSalpSN1FGVXM3RGJ3WWlNWVorbFpGYmJu?= =?utf-8?B?cVZHUFR0dVhkalNkK0x5c2UwR1FBZFJjUUZaeXhiWFF1Ynp2dUxDd1J0c3Vj?= =?utf-8?B?RDhhREZBYlNPQjF3ZGhaY2J6a2wzdi8reittN0c3YTVBYm56R2cvcE9HWUFw?= =?utf-8?B?MFlLZGtDU2FaTXI5cEtQc1JtcDhqWlZSclhDWGFiOXovWEl3dUE3aDRydGN1?= =?utf-8?B?VUZXbFl4dHFVeWdpNExEVk9kb3JjMGU5Ty9ERnhjR1o3RUtiVHhrcmV6K3o2?= =?utf-8?B?TXlMS2JhSDQ0elJTQ1ZJK2d2T01RdSsvSFE1bG93dy85cGpESzY1QTVTNnBJ?= =?utf-8?B?bUI3TFlwQ2xybUpIdWluWURGMXJGUkFsOEdsRzYwemF2Q3plMkZMNFYxSVRi?= =?utf-8?B?MVA2YXlNVUc3MC9CRms5WDYzeVNnR0JNTCtWdFFQanlqdGYvcFM1c3JML3BG?= =?utf-8?B?czZBa0F0ejV6bHZKNkpkeWdJUnBZejdKczJ5SWFTaU42K3ZxUkxiRk1oZWly?= =?utf-8?B?RlFiQiszblAxR0tEV1RYWjlyWk1pLzVDM1pLYVlZMkUyUkh6Njk1TmIxQ01I?= =?utf-8?B?T1UyaCtidW50RGVJSHdvMm5aMjJSODZVbTl1aENtcEhrUDAxc1BGYk9TOFlW?= =?utf-8?B?dHlLK0p1Rlk1VkJNU3F3YzlWUnI3MmJyWEdBUGpRSHNrNWpIdG8rR0VGY29I?= =?utf-8?B?T2o2NnR1alRWeC80VHBSeDNyWXFsdUNtUXlybEhML0lqRXQzYXhVSnlOZGtH?= =?utf-8?B?dnorRE1pb3RjTTBxakQ3aVpxUWFCN2NLZWwzVjRSSnNuZ3dYbVNHNUVaNDQ4?= =?utf-8?B?WTcxOHNyQzJUbmQ0WDZveDN3K1dvL2tVZXBpbHNTQ01namFxY3NGeFFqZE93?= =?utf-8?B?VkJ6WEFsNkczTGE0M0x1WExXdVdBN0NoRTF4djRKUUhyQ0dEMWRpejhMQkV3?= =?utf-8?B?bG9mWDJncXFKSWVoaTlkTmZXMTZNcElaRTF6aEVTSktNNHVqa1BSTU1nS2Fy?= =?utf-8?B?WUU4RU1sU3drUmhkb29sMVN4N2JseXFYUTVZZXB3NlFtNlVVRGVXNFdJbEIr?= =?utf-8?B?ckdWQXBQOUkzZWxLQlZ4a0Rkc1ZSR2xGbHhiZVh6ZGZWT2ZCMG1ZSTBhb3NJ?= =?utf-8?B?VW9ScWo2RUN3R1FyTVlwMHFhUVY1M1ZOMXZXeG5qZFZwMEFUOVY4OFVaYnZo?= =?utf-8?B?V0x1d1d5YXh2OEJmYlliWFZrSHpnNjEzWThCWmxBRkZzSEJUVmxxRUFpQ2xh?= =?utf-8?B?NnF1UVRidFlnd0dIaTJNeVNsMjBqSHZJd1RGaGRadDVWeU5keTdEUXJGU2c0?= =?utf-8?B?SzdmSW0xVkpMNERmcnNnU1RBK1AyU25SbWd0bzJLMUZNUm94T1VTQXk0T2U1?= =?utf-8?B?ekkxT2YvSWNvb0xHVDAzVm5DYjBKV2lpa0lUWWJjZndwZitZWmNtZnhlTXNt?= =?utf-8?B?eWF2b1BlRU11VFZ5NXhwNHJPRXJvRFNtaE5vK3lCUE41eCtQYXZicXE5Z2dC?= =?utf-8?B?S0hLZ2VzaWhMOVN1VFJNUWhpeDI4cG9tYmo0TWFCejVXci92clVoeTdDam9J?= =?utf-8?B?dVVsVHRzVURuUHBXZkh2Z28zYnUveFBtUnlOL2VtWFgrY05NYWpVOFBOeFVH?= =?utf-8?B?R1ZuWCtkUThCZUIrRy80RHQzb1pXckVxOVFIMHZCWWY0bWhHVk5aaDJwNDlU?= =?utf-8?B?YXRKNVptT2JGSk5DaGliL2xUZUpVNEFrVDllZHk3ekVvMzlWaDF4WXhrYmth?= =?utf-8?B?UWhYRlVmUGs1V1NvNXgza1k4UDBxd0lVT2hpOGtybnFVWEVQaFFDT3pHU1JO?= =?utf-8?B?cFJ0dGx5YU5nbC80SnZPc0FMbmdGRC9kTmhIU2NjWUc2MVVLZE5UQlg2T3FK?= =?utf-8?Q?o7+ijpRgjuc0M0nUEE1rbWgP8e5vL0=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0722;6:+HVIhyWPWjqiNdnGuIJlSqhupOOXuNCoFNd2zQv2cjoomI6iNUCWJixpc7HWYPW7tz/Hice+TfNh6XAPFZ+W6FpoUz7nIw0o7Ot2+4Kw1FCulMaYfw79VLD5aLqszEIMQOyzZRvVVZSEBLXOJ7oaWkH2mllM6u4ftroI+3MLmp6A9azKXMBkjvfZks/cJWX5OHBnZ6LqyByrDjVWg05SNAsmAZEjB7ovXf3G3demp9XlXSvVgyzw5sVXtIbILsJFw/bJI6HVncTRFyp2KQxhsNQ7vxWXWzSOq1GxgTRFP/qOgAZ12RU0J6KSxXBGqRvf7FLL57y/nLuJSgHT96GExLFqmVbhTeFryGFrvuFuy/4ohx5Ix5em+truZ6XXadaumxsnInUMrt9NnTo6WRP6LCw20HKId6CwX+W6kMZkB33hZiDTLwgMTvWp8Bn+PUdnSHXZA0qTBi+9f+1S9m3uAw==;5:U/18AslydA+QxRsLp9Q/l0/4Q4sZGhPxi9Dm70CDcTm4dIiU5xyTYNN9s3u234roF4JcvY+Dye+71YXqaBMY4joSVxMIXwbcv2hvETfv2gicYZCV0uK30BU6XZUno+9HAad1Ojxgztr4UPXgfBAoLfZdzO8Fb1xDDJqAOzW6Sjg=;24:L0PZ38llX+ZI6Y+MeAxkkrIJB0ZDjl0gDzKB1jVVW+jxrRMGNlsDKPX5LLFOALRHIUtUHff2WZlyZWMkYr7UosxxyqaJzJFriJFyQC12ubQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BLUPR12MB0722;7:T6x7/q9RZwQ0lMTqIejos6HHpZUlPORNvEIK4gJGNPTu51Ne2nrOHIIi/d1+eW+v3kLCgBS9U7rzLL+hKMR5RnKp3llIsYjBwEroq5I9wNZTXhaZAZMcugloLohfJltvKom/tUXLI8ImH8kGKVCA3xi0j6arCpsBUoi78YS9Kp5lrShPBvjcr2mN6bz6viQF/qfpB8bnZ/Vsqj1P7oqz9GczCUP80fpj1ArKx0kUNuCuj/nFzo+wZpbevgscHkPtzy81gFQ/ZFk0Z9CimEXVMZqtBv9kq8RV5fqA0Kk3qwGIypGLMO7lVGfILj+UilQ1xSzaupK7k3Sf9S2ot/FAYiljkFatda0kC52Rt4odo6q5po4Zi9VnKZeNWmPqQT7T2Q7kPtsyITKh1MoTBj7yxZiP3NWfVVEgnjoEe+nYZl5qckC7HcTVQa0nkmW8lhCyK4KFQqXJrWF74txQZGYyRQ==;20:ZwrVv/EcaaGnn9XU1/qUboKGBtZFDJXaSmwphqjoju0VKb34J5PwYbpxYMC3oUejCgrMI06NtRAwdbEw9vBb4dUZGO5G7dHgHl8ih4jB63GRPhUQUTBXRneOqKA5mjYSFgi84IAdfBIHRNtVMAqJ2KKDScdD5tRW0ldrMiet7tLaiO1IE9MhHQgdlvS3lapcrLYz+v1c2AqEmLFBa5A2EUVwGVUJudjAyTU18TFANcwldFOCK/BiwuZvWnV6jSG4 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2017 08:15:30.4104 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR12MB0722 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Linus, You have already added patch for the same "[PATCH] pinctrl: amd: fix compilation warning" and applied to one of your fixed branch. Do you feel this patch needs to be taken ? Thanks, Shyam On 1/12/2017 1:19 PM, Linus Walleij wrote: > On Wed, Jan 11, 2017 at 3:36 PM, Arnd Bergmann wrote: > >> Since gpio_dev->hwbank_num is now a variable, the compiler cannot >> figure out if pin_num is initialized at all: >> >> drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': >> drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] >> for (; i < pin_num; i++) { >> ^~~ >> drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] >> >> This adds a 'default' statement to make that case well-defined. >> >> Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") >> Signed-off-by: Arnd Bergmann > > Patch applied. > > Yours, > Linus Walleij >