From: adrian.ho.yin.ng@altera.com
To: Dinh Nguyen <dinguyen@kernel.org>, linux-kernel@vger.kernel.org
Cc: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
Subject: [PATCH v2] firmware: stratix10-svc: populate kaddr1 from config status response
Date: Fri, 11 Sep 2026 16:44:18 +0800 [thread overview]
Message-ID: <2d8af331c37fcdd8a6f3dccdb6cc6cd903f0c4cd.1788972469.git.adrian.ho.yin.ng@altera.com> (raw)
From: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
Set kaddr1 from res.a1 when the configuration status completes, matching
the existing error path and allowing callers to retrieve firmware-returned
status details through the standard kaddr1 interface.
Signed-off-by: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>
---
Changes in v2:
- Drop the callback-data lifetime / dangling-pointer changes.
- Reduce the series to this standalone patch. Set kaddr1 with &res.a1
on the completed path, matching the existing error path.
v1 patch link:
https://lore.kernel.org/all/cover.1779780223.git.adrian.ho.yin.ng@altera.com/
---
drivers/firmware/stratix10-svc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c
index 34c591d7fd58..2333ea31e741 100644
--- a/drivers/firmware/stratix10-svc.c
+++ b/drivers/firmware/stratix10-svc.c
@@ -444,6 +444,7 @@ static void svc_thread_cmd_config_status(struct stratix10_svc_controller *ctrl,
cb_data->status = BIT(SVC_STATUS_BUSY);
} else if (res.a0 == INTEL_SIP_SMC_STATUS_OK) {
cb_data->status = BIT(SVC_STATUS_COMPLETED);
+ cb_data->kaddr1 = &res.a1;
cb_data->kaddr2 = (res.a2) ?
svc_pa_to_va(res.a2) : NULL;
cb_data->kaddr3 = (res.a3) ? &res.a3 : NULL;
--
2.49.GIT
next reply other threads:[~2026-09-11 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 8:44 adrian.ho.yin.ng [this message]
2026-09-15 14:36 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d8af331c37fcdd8a6f3dccdb6cc6cd903f0c4cd.1788972469.git.adrian.ho.yin.ng@altera.com \
--to=adrian.ho.yin.ng@altera.com \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®