From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F92CC3DA7D for ; Thu, 5 Jan 2023 09:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231879AbjAEJRl (ORCPT ); Thu, 5 Jan 2023 04:17:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231820AbjAEJRb (ORCPT ); Thu, 5 Jan 2023 04:17:31 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51EAD544D4 for ; Thu, 5 Jan 2023 01:17:29 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id m7so1035492wrn.10 for ; Thu, 05 Jan 2023 01:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=pq3ejuzBjCDJdHLBnefjQA1cSMGJU3lpvGousig3Qm4=; b=n7Mj3heVFeFgnm409WAdct2hWXOXoVgcy4BtrIqudbYirOWeWNImfDZxC/YvGM4nYC 0fjS9QSgDvmUTBANDuZ9HB/okAgRZghzDoSQIQGsLiBiLsORLCgObB1GBxTQOg4E1A5E X96TogwMkwyYa4j6+GkRAJEfm/m1IdE0VBW5KRv7R6sjI0oh3ebJwFKZ3xcG0QPR7Aps z33xiRqsive6Lg52cj+XzNqSdMmSio9TRGHSjvHkqymx5dRH3YCo1dwL9SN+ZxDT7Xwy Njl7XPKhakIlG6QQXsFRR3+zbOBaEtcdVEafTpHxY5T7k5rpBsAbJUu6/xUMdOgD6FNF ptvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:content-language :references:cc:to:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pq3ejuzBjCDJdHLBnefjQA1cSMGJU3lpvGousig3Qm4=; b=sK2hK0+NrIOn2QAQ/2JgUMtqnzYDWyH7Ll/HrhUWIGTCfJHCnjOMV3uWIsm3vNkQyo ZjEaeAPyHRB8k94ym4bAm/rrpw1CP608Zreeb5CrzljCAhdWJFHJefrpby2d8v0F2aWx myZeQZ+gX+HVDwdNaf9unbFwkfzE6i/nqPD1xv3FBEN9GhgDy5zZCzrLsHtFA/ep5h/z egTOamXOJYCSeQ+HuNfZWWGxIsOoSaktoItWa1wKXNYFzdxOmZ98CDvo0Q5V8nNGocrz tNShsP9M1qWczmMvOBOx60Jhztn+dYXL0GsI6YhHrTlqiKiEhg9cFk16osd1xTXKkQSl Ar9A== X-Gm-Message-State: AFqh2kphzz/4iseCP+7D/9uACitZb51iWp0ZGVANfnX0JaMTECQ0Gg7x l9Z9rXEqeYAx5hNMsirMeEN2WQ== X-Google-Smtp-Source: AMrXdXstMyW0DgS/z6kXcwU9LPSEpxdk+xtC0acQsk8RCCbVghUBwX0j9ppX/MquETlN1KbOsSGxBw== X-Received: by 2002:a05:6000:1f14:b0:242:5a34:fb7b with SMTP id bv20-20020a0560001f1400b002425a34fb7bmr31715300wrb.70.1672910247816; Thu, 05 Jan 2023 01:17:27 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:1e12:c16d:1898:607c? ([2a01:e0a:982:cbb0:1e12:c16d:1898:607c]) by smtp.gmail.com with ESMTPSA id m11-20020a5d56cb000000b0028d66c43101sm18463067wrw.29.2023.01.05.01.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Jan 2023 01:17:27 -0800 (PST) Message-ID: <2d90fb92-45ac-7311-ef27-ce82c6b891a4@linaro.org> Date: Thu, 5 Jan 2023 10:17:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 2/2] drm/panel: add visionox vtdr6130 DSI panel driver To: Rayyan Ansari , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-0-9b746b858378@linaro.org> <20230103-topic-sm8550-upstream-vtdr6130-panel-v1-2-9b746b858378@linaro.org> <8c8d0276-61a8-71d6-17b0-f6b384ab9d94@ansari.sh> Content-Language: en-US Organization: Linaro Developer Services In-Reply-To: <8c8d0276-61a8-71d6-17b0-f6b384ab9d94@ansari.sh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 04/01/2023 19:25, Rayyan Ansari wrote: > Hello, > I am not a maintainer, but I thought I might give a few comments. Any comment is always welcome ! > > On 03/01/2023 14:22, Neil Armstrong wrote: >> Add support for the 1080x2400 Visionox VTDR6130 AMOLED DSI panel >> found on the Qualcomm SM8550 MTP board. >> >> By default the the panel is configured to work with DSI compressed >> streams, but can work in uncompressed video mode since 1080x2400 in >> RGB888 fits in the 4 DSI lanes bandwidth. >> >> While display compression is preferred for performance and power >> reasons, let's start with the uncompressed video mode support and >> add the DSC support later on. >> >> Signed-off-by: Neil Armstrong >> --- >>   drivers/gpu/drm/panel/Kconfig                   |   8 + >>   drivers/gpu/drm/panel/Makefile                  |   1 + >>   drivers/gpu/drm/panel/panel-visionox-vtdr6130.c | 366 ++++++++++++++++++++++++ >>   3 files changed, 375 insertions(+) >> >> + >> +MODULE_AUTHOR("Neil Armstron "); > > Missed a "g" here :-) > >> +MODULE_DESCRIPTION("Panel driver for the visionox VTDR6130 AMOLED DSI panel"); > > I am not sure how the company capitalises the name, but to keep it consistent with the other mentions, I think it should be "Visionox". Thanks, I'll fix these. Neil > >> +MODULE_LICENSE("GPL"); >> >