From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E20DC61DA4 for ; Sat, 4 Feb 2023 16:54:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231654AbjBDQyd (ORCPT ); Sat, 4 Feb 2023 11:54:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjBDQyb (ORCPT ); Sat, 4 Feb 2023 11:54:31 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 092D82DE4C; Sat, 4 Feb 2023 08:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=mtAU4WjAVO0TWvJMqe0ixXT1gJ7xSV6/kS2P8d/VJYQ=; b=36usuTuRmoMs3aWje7ufuTbBc0 TY7XP/4PwOImo5G7W+rwnEphFMttIQGTcMoZFf3tLaiIXMe7BLPP3thu3UTQE3/NTlxiWn6Lninld equzVdw/8HOMN9ED7yJe/R7JdTQVAAkrVqoMabOahIzblNtMQEMKwUczTyajstqtfQAMIyV/H+40A J2NaEYRofOMe0nk6fTpGiCDdbyQDw6TBuGtJcNad+H9GbS/1MWnwlT1GuVS/eaMqYQQtA6VV6UPHA 4TxKp8P6ioQBj8hnHIIWqTjQcrG7GeQ1nQtxx1GDQnzJRHFwDRaSSwwv6/MiUhNuTUZ+mnBlUUZc2 m3zy07/A==; Received: from [2601:1c2:d00:6a60::9526] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pOLny-005POp-B4; Sat, 04 Feb 2023 16:54:22 +0000 Message-ID: <2d9a36e7-4518-a23f-9f0c-84b830e57d51@infradead.org> Date: Sat, 4 Feb 2023 08:54:19 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] soc: sunxi: select CONFIG_PM Content-Language: en-US To: Arnd Bergmann , Arnd Bergmann , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , sparclinux Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230130130453.379749-1-arnd@kernel.org> <46dafb64-81d2-c084-97c5-8d01e8b9785b@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/4/23 02:38, Arnd Bergmann wrote: > On Sat, Feb 4, 2023, at 08:47, Randy Dunlap wrote: >> On 1/30/23 05:04, Arnd Bergmann wrote: >> >> Apparently sparc32 does not support PM (arch/sparc/Kconfig): >> >> if SPARC64 >> source "kernel/power/Kconfig" >> endif >> >> so I think that SUN20I_PPU should also depend on !SPARC32. >> Does that make sense? > > I would suggest working around this in arch/sparc/ instead > of every driver that uses 'select PM', perhaps something like > > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -283,7 +283,7 @@ config ARCH_FORCE_MAX_ORDER > This config option is actually maximum order plus one. For example, > a value of 13 means that the largest free memory block is 2^12 pages. > > -if SPARC64 > +if SPARC64 || COMPILE_TEST > source "kernel/power/Kconfig" > endif > That looks good. Thanks. > The issue does not happen anywhere else, as it's fine if > kernel/power/Kconfig is not included at all. I'm also not too > worried about random sparc32 configs since it's pretty much impossible > to build a sparc32 allmodconfig or randconfig, with all the other > bugs that runs into. OK/ack. -- ~Randy