From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2292C61FFC for ; Mon, 12 Aug 2024 20:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723493530; cv=none; b=GF/ccQeQP0uV7x6rZ8tMNVV3YO4CfgO/FMnTNFnNc8FR/KWcZ8kxp/KI9htycBeY90IcsZmgq/WYE9tkMt25k5mMtAi6xCdsA9/cwAFl7aExw4fnuLmMRpXsjQK8Zjx4YBlMYXvhyEOdHrw30jysB/Wz7zOw0W2opOfIqx1J+Z4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723493530; c=relaxed/simple; bh=rsX0RfFObnQciAoSwT/35rljb0kBQAA4gxKJ+GxskM4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hJbMbNmWLyy1iNLhuMVutMAfWNDPgGBb6LWzp+EcvvfiLDOvNTVReW6JRvFYe7aLME54Le8+XpqEuBJHYZlM2ZDvAac97LraguwofT1baTawnECsemBQWsTrRJntaEUP1hYqxCD0YVU08OeO8rodzhu+79ejvd2bOFVxcUMs8UY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OriYc3aH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OriYc3aH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723493528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=4pxPhrlq8M3bwqSfpv7S5gTFvgao+jQlKr8jDIOLaPw=; b=OriYc3aH16lnW8IzpirHxodGa+4ZCBq8Zg6H0EFpvynPxhYpoDK1wvJxbKfb0oPx7lgOO2 Jm4Qlm/ohfxDKYjNE7Hz+YLnoBqnAIy5uNgft6KJ+Pm7bY6FVuYO5rxMYMJLZqrWnc4lQW +IAKhXwfzpW7+YKJmwhc+fDqB1VXrYo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-671-wnDBOVTXMm2pcS7ODt07SA-1; Mon, 12 Aug 2024 16:12:06 -0400 X-MC-Unique: wnDBOVTXMm2pcS7ODt07SA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4280b119a74so33913265e9.3 for ; Mon, 12 Aug 2024 13:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723493525; x=1724098325; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=4pxPhrlq8M3bwqSfpv7S5gTFvgao+jQlKr8jDIOLaPw=; b=twvI2LmXuhxUHhaKIcbC9FyNd2azMzcPXjSbdcgoTZaOhZwKMtNlG4I+Jgy6gLCHw4 78viV58O44UpYSBZcftRUtoW1uNQYJwASuqBDKeg6TQ3yTqyURy0csP330cbi2YF+9VG +90hRpL0Z8SVcyqgwEwW+hf0kWyZS0dpYyOj9nIucKfdto5n7MVakIcpo86OUzHXrFVB +Pk3yyqR2PwRDSZ6jlkvbeA8sndVgqljvxr/j5mx6c28xQFIz0p5tMhIUgRPuPBIZDO5 H4EsgFqw5nibhQjk9ha2baurKWSe8sHUG6PtX4iDW1dw6w2YkaPMJGwSamoxRdcdgRdS PMsw== X-Forwarded-Encrypted: i=1; AJvYcCX9jRU7aGuM+JFADvb/+r3DvF67h6FqwenPnb8dacVXNUhWQxQPComxPPcq5ZEiZ5/7wYbfm5AxDVkh4TFOtZNpOJIi7cDUKk+Omj6y X-Gm-Message-State: AOJu0Ywk/x21wPDMDav7OccP/UPTVg1M1htwIqTAD7XNuCAt+1BRTWir 7IKUNN5hyT0SkLL6os6bj00x35qLHnqaAuyXcokTTPLHYmh2HKH9InhbB/qL6doDn1S0C7dVsdD ktGKEDqOB389ETe6FDRPw/z0mUwgFbVadvv0dX5SIjJ362Aam2gU4c2DzgjihuQ== X-Received: by 2002:adf:eaca:0:b0:368:79c6:8845 with SMTP id ffacd0b85a97d-3716cd2aa5amr1098013f8f.56.1723493525281; Mon, 12 Aug 2024 13:12:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzEjoSJxu62SrF6kS7QmEKpfeqlP4QeF/rvgAdIXqlEfED0lrpAX3R4zrVGI3zqHlAw3mzaw== X-Received: by 2002:adf:eaca:0:b0:368:79c6:8845 with SMTP id ffacd0b85a97d-3716cd2aa5amr1097990f8f.56.1723493524761; Mon, 12 Aug 2024 13:12:04 -0700 (PDT) Received: from ?IPV6:2003:d8:2f09:3f00:d228:bd67:7baa:d604? (p200300d82f093f00d228bd677baad604.dip0.t-ipconnect.de. [2003:d8:2f09:3f00:d228:bd67:7baa:d604]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36e4cfefa29sm8348294f8f.61.2024.08.12.13.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Aug 2024 13:12:04 -0700 (PDT) Message-ID: <2da47dad-46ff-4e04-b697-c85f30a4341a@redhat.com> Date: Mon, 12 Aug 2024 22:12:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2] mm/swap: take folio refcount after testing the LRU flag To: Yu Zhao , yangge1116@126.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1723461718-5503-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12.08.24 21:06, Yu Zhao wrote: > On Mon, Aug 12, 2024 at 5:22 AM wrote: >> >> From: yangge >> >> Whoever passes a folio to __folio_batch_add_and_move() must hold >> a reference, otherwise something else would already be messed up. >> If the folio is referenced, it will not be freed elsewhere, so we >> can safely clear the folio's lru flag. As discussed with David >> in [1], we should take the reference after testing the LRU flag, >> not before. >> >> Link: https://lore.kernel.org/lkml/d41865b4-d6fa-49ba-890a-921eefad27dd@redhat.com/ [1] >> Signed-off-by: yangge >> Acked-by: David Hildenbrand >> --- >> mm/swap.c | 9 ++++----- >> 1 file changed, 4 insertions(+), 5 deletions(-) >> >> V2: >> Add sanity check suggested by David >> >> diff --git a/mm/swap.c b/mm/swap.c >> index 67a2467..c048659 100644 >> --- a/mm/swap.c >> +++ b/mm/swap.c >> @@ -226,12 +226,11 @@ static void __folio_batch_add_and_move(struct folio_batch __percpu *fbatch, >> { >> unsigned long flags; >> >> - folio_get(folio); >> - >> - if (on_lru && !folio_test_clear_lru(folio)) { >> - folio_put(folio); >> + if (on_lru && !folio_test_clear_lru(folio)) >> return; >> - } >> + >> + VM_WARN_ON_ONCE(!folio_ref_count(folio)); >> + folio_get(folio); > > No need to check folio_ref_count() here, because folio_get() already > does it with a better check folio_ref_zero_or_close_to_overflow(). > Ah, good point, thanks! -- Cheers, David / dhildenb