From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 412A636405D for ; Wed, 4 Mar 2026 16:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772642292; cv=none; b=WLWTS8eF2cg8X4PdveVRNiPDpEoPfefi2qvVWQvv2y3scPMtlN8iI0VjOF6gT+AY2/SZvM+cB6ge5lWQnGKjLJn6NRy5me9Nv5nPtYf2NVXN/7NiaBtyAkunBepW71RafndREPCsdliFeYulTUuw2hOHH9I8CDPe8DatjqXpqLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772642292; c=relaxed/simple; bh=x+JOWh3XcNNfKF+P5YxoyTNQK8SVoS4FodK1vT+gChk=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=g1xgIX7/a/MS1UPO6kCNgUXJfE/Pxl9lWxS5Y8Z4NqAHzI+4jU/LePQxBfwsas9oWj4Q8Ipe5NyFpt+79xjF6BWw5ZLC/gX8JFM+y8yvaz8HXeZ+FEmyZlQKWrtx2rQO+42xCK4qySJBPCbxvO2MZ7llkV76SRkNBIdVtiZE9sU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=MjDxhLt1; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MjDxhLt1" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4834826e5a0so80476015e9.2 for ; Wed, 04 Mar 2026 08:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1772642290; x=1773247090; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=CLBEOyTjMzhfw8iP5dMgZDHtLtMkaQoKON/T+0b+0mc=; b=MjDxhLt1Yqu6HlWTYQfFaxq23uOgXSaWuCvQ9oQQYTEump2jsNQSzINNjFNBRBuA4I BZ9silIABqDolHwytznfBEBc9BGG26T6vXYKnh2kgt3DOJ9CXvEdSjhAPgew3cQKRS5i nbTzD02FGWvviobCqgm3tOxzmFpT1MsZgcXu3HFQ7Jq5JGup5Z/dtd8YdhzOnNuA0EBH EuVBC9MR6TSdog68EqNKwP5+zRXCMmSa2EuSN9lXB7VJHO0BmARrXgpvrXVOw5A3ijCb dzeG20051bGm2r8un5HFrnIcbL/pcigMijfhT7A3nh/fjuD2/+f4Ltg9AJvHrxys4mnB xHhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772642290; x=1773247090; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CLBEOyTjMzhfw8iP5dMgZDHtLtMkaQoKON/T+0b+0mc=; b=riXRq/j0lH8tUnx/vBc4RtZkJql0hAgiWRqky4LxYH/vjTK3CB0oZ2hEMW7o52Oe7g 2aPr+YZzoXunuhxxwSzfru021Zde+nxVHTy+2WWACMEKKUmSRqRnv2VekOex3ZLbp3WC t+cfUZQEYBCPH+NInW4IYfUfALuhwVv2INPR5bJMse4Qc0GX838XqH5mS1C336PVUEi6 gRHd+4zttYXFVm2qO60FCUQFPM1Uts3E42a+2abVJG7OMYvWt6Y/GqxTQAJA/FY+0Nr/ uQMH/bGwDTQ6u3JzwDSKaFhqzyUigWqel4udMk7hWw9xZAa1ZqtpE2+s1f6e+sd4WPO4 GRnQ== X-Forwarded-Encrypted: i=1; AJvYcCWzWAl21Us+gFEUiZOtwl1lOGXBC60s1J41T5u6/fkWHDmVaXWRU+uiZ5JanZtKsEx9jp5GiMHDvLdqF3E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/2cu1IOhosCbhuA0cunYDao9TiqJqDkHexAwxK7FqPqr6/Mbf UYglEwjZ0K8mX4zJGppAB1vPW+MGVGODeVsj0mIQfXeF2expUeGNVFKW928yuI3azww= X-Gm-Gg: ATEYQzzn6ycwDG5vys42IBJ6jYCsYyNP+f89PZ82NqkML8kGtNaZcrixxC3fKr8gNGU 7J0/665tw2pZejGnf9O/Lc2u5myhEpVWo4BxPjZJP5w0NghEOHIGbDHcS8X8H7Y7LLIU+rfFYzz 8QazMENbi6cBHJR5QkUbmpNDnDgxiiRD52oVwAE/wgjStu52tVTImVSwQbAkUAVxN8yq1jYvZNg VD422zCaplux8Bc/GdW9vcWctPU8QIG7KEMBMtFhD+BKg7qS+Pm4hVkGnnLqFW1PHEt+OUXbv3/ QwKQmb+AZ82tHko1eWNpxBbNA+qotlLyMaD69rL8iEWPGh/6JyQmZuJ6h2dPVwFPs9zvaJU2qBR UjjLy3bcAR09N5v7cq4nXYJUpxEHmKbBn++SSOlB4OhWtkfT5DhwhGqu+g8qyZnuNwwXN3zmTqw lMWUM9oY2gB4giJQ0+1YSsFX/ZYQPt+IOHA02v1IXEj3/Ieb16+AyiH6TdCxKHLjV05BlY7/m4b As+ X-Received: by 2002:a05:600c:4f95:b0:477:9814:6882 with SMTP id 5b1f17b1804b1-48519848443mr46567695e9.5.1772642289601; Wed, 04 Mar 2026 08:38:09 -0800 (PST) Received: from ?IPV6:2a01:e0a:106d:1080:da6:dde3:e477:94d2? ([2a01:e0a:106d:1080:da6:dde3:e477:94d2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851887fd5asm64520675e9.11.2026.03.04.08.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Mar 2026 08:38:09 -0800 (PST) Message-ID: <2da607e0-9bb6-4dd2-a647-e92038e60f8b@linaro.org> Date: Wed, 4 Mar 2026 17:38:08 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: ilitek-ili9882t: use gpiod_set_value_cansleep() To: John Keeping , dri-devel@lists.freedesktop.org Cc: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org References: <20260303152124.187791-1-jkeeping@inmusicbrands.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260303152124.187791-1-jkeeping@inmusicbrands.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/3/26 16:21, John Keeping wrote: > All of these GPIO calls are in process context where they can sleep. > Use the appropriate function call to allow use of this driver with GPIO > controllers that might sleep. > > Signed-off-by: John Keeping > --- > drivers/gpu/drm/panel/panel-ilitek-ili9882t.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > index 8b2bfb7d36385..5f4e0d82ee673 100644 > --- a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > @@ -592,7 +592,7 @@ static int ili9882t_unprepare(struct drm_panel *panel) > { > struct ili9882t *ili = to_ili9882t(panel); > > - gpiod_set_value(ili->enable_gpio, 0); > + gpiod_set_value_cansleep(ili->enable_gpio, 0); > usleep_range(1000, 2000); > regulator_disable(ili->avee); > regulator_disable(ili->avdd); > @@ -608,7 +608,7 @@ static int ili9882t_prepare(struct drm_panel *panel) > struct ili9882t *ili = to_ili9882t(panel); > int ret; > > - gpiod_set_value(ili->enable_gpio, 0); > + gpiod_set_value_cansleep(ili->enable_gpio, 0); > usleep_range(1000, 1500); > > ret = regulator_enable(ili->pp3300); > @@ -638,11 +638,11 @@ static int ili9882t_prepare(struct drm_panel *panel) > } > usleep_range(1000, 2000); > > - gpiod_set_value(ili->enable_gpio, 1); > + gpiod_set_value_cansleep(ili->enable_gpio, 1); > usleep_range(1000, 2000); > - gpiod_set_value(ili->enable_gpio, 0); > + gpiod_set_value_cansleep(ili->enable_gpio, 0); > msleep(50); > - gpiod_set_value(ili->enable_gpio, 1); > + gpiod_set_value_cansleep(ili->enable_gpio, 1); > usleep_range(6000, 10000); > > ret = ili->desc->init(ili); > @@ -652,7 +652,7 @@ static int ili9882t_prepare(struct drm_panel *panel) > return 0; > > poweroff: > - gpiod_set_value(ili->enable_gpio, 0); > + gpiod_set_value_cansleep(ili->enable_gpio, 0); > regulator_disable(ili->avee); > poweroffavdd: > regulator_disable(ili->avdd); > @@ -793,7 +793,7 @@ static int ili9882t_add(struct ili9882t *ili) > return PTR_ERR(ili->enable_gpio); > } > > - gpiod_set_value(ili->enable_gpio, 0); > + gpiod_set_value_cansleep(ili->enable_gpio, 0); > > err = of_drm_get_panel_orientation(dev->of_node, &ili->orientation); > if (err < 0) { Reviewed-by: Neil Armstrong Thanks, Neil