From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A03CC3A5A1 for ; Wed, 28 Aug 2019 10:10:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 66BF1208CB for ; Wed, 28 Aug 2019 10:10:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726619AbfH1KKD (ORCPT ); Wed, 28 Aug 2019 06:10:03 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:46912 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726438AbfH1KKD (ORCPT ); Wed, 28 Aug 2019 06:10:03 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 2392928A204 Subject: Re: [PATCH] arm/arm64: defconfig: Update configs to use the new CROS_EC options To: Arnd Bergmann , Bjorn Andersson Cc: SoC Team , Gwendal Grignou , Benson Leung , Linux Kernel Mailing List , Guenter Roeck , kernel@collabora.com, Lee Jones , Krzysztof Kozlowski , Linus Walleij , "open list:TEGRA ARCHITECTURE SUPPORT" , Marcin Juszkiewicz , Will Deacon , Catalin Marinas , Geert Uytterhoeven , Leonard Crestez , "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" , Olof Johansson , Chanwoo Choi , Dinh Nguyen , Miquel Raynal , Linux ARM , Daniel Lezcano , Kukjin Kim , Thierry Reding , Jonathan Hunter , Sudeep Holla , Jagan Teki , Fabrice Gasnier , Daniel Mack , Russell King , Shawn Guo , Simon Horman , Marek Szyprowski , Yannick Fertr? , Robert Jarzmik , Alexandre Torgue , Tony Lindgren , Anson Huang , Maxime Ripard References: <20190827154851.10486-1-enric.balletbo@collabora.com> <20190827161045.GC26807@tuxbook-pro> From: Enric Balletbo i Serra Message-ID: <2db6cde1-9e7f-8b1c-f2e4-80bdd2478d28@collabora.com> Date: Wed, 28 Aug 2019 12:09:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bjorn, Arnd, On 27/8/19 18:12, Arnd Bergmann wrote: > On Tue, Aug 27, 2019 at 6:08 PM Bjorn Andersson > wrote: >> >> On Tue 27 Aug 08:48 PDT 2019, Enric Balletbo i Serra wrote: >> >>> Recently we refactored the CrOS EC drivers moving part of the code from >>> the MFD subsystem to the platform chrome subsystem. During this change >>> we needed to rename some config options, so, update the defconfigs >>> accordingly. >>> >>> Signed-off-by: Enric Balletbo i Serra >>> Acked-by: Krzysztof Kozlowski >>> Reviewed-by: Gwendal Grignou >>> Tested-by: Gwendal Grignou >> >> Can we make the entries in the generic arm64 defconfig modules? > > Good idea. > > Actually I would prefer to have all of them as modules for consistency, > if at all possible. > It is very common boot Chromebooks from an USB device, the EC needs to be built-in in order to boot from these devices, otherwise you should use an initramfs. I'd like to avoid forcing people to build an initramfs just to boot from these devices if possible, in fact, my usual workflow is without initramfs, and knowing that with the default defconfig just should boot helps a lot sometimes. Note that, it's not the case for EC subdevices, these are already build as modules. BTW, Lee asked if this patch should be squashed with the patches that really renames the config options to help bisect ability, I don't have a hard opinion as I don't usually run the config option between bisection steps, so please let me know what do you prefer and I'll respin the patches ASAP if that's the case. Thanks, Enric > Arnd >