From: Hans de Goede <hdegoede@redhat.com>
To: Christoph Hellwig <hch@lst.de>, axboe@kernel.dk
Cc: yuyufen@huawei.com, tj@kernel.org, jack@suse.cz,
bvanassche@acm.org, tytso@mit.edu, gregkh@linuxfoundation.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] vboxsf: don't use the source name in the bdi name
Date: Wed, 22 Apr 2020 10:15:32 +0200 [thread overview]
Message-ID: <2db7b68b-5117-4dab-ce57-6e8011711c23@redhat.com> (raw)
In-Reply-To: <20200422073851.303714-2-hch@lst.de>
Hi,
On 4/22/20 9:38 AM, Christoph Hellwig wrote:
> Simplify the bdi name to mirror what we are doing elsewhere, and
> drop them name in favor of just using a number. This avoids a
> potentially very long bdi name.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> fs/vboxsf/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c
> index 675e26989376..8fe03b4a0d2b 100644
> --- a/fs/vboxsf/super.c
> +++ b/fs/vboxsf/super.c
> @@ -164,7 +164,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc)
> goto fail_free;
> }
>
> - err = super_setup_bdi_name(sb, "vboxsf-%s.%d", fc->source, sbi->bdi_id);
> + err = super_setup_bdi_name(sb, "vboxsf-%d", sbi->bdi_id);
> if (err)
> goto fail_free;
>
>
next prev parent reply other threads:[~2020-04-22 8:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 7:38 bdi: fix use-after-free for dev_name(bdi->dev) v3 Christoph Hellwig
2020-04-22 7:38 ` [PATCH 1/9] vboxsf: don't use the source name in the bdi name Christoph Hellwig
2020-04-22 8:15 ` Hans de Goede [this message]
2020-04-22 7:38 ` [PATCH 2/9] bdi: move bdi_dev_name out of line Christoph Hellwig
2020-04-23 0:07 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 3/9] bdi: use bdi_dev_name() to get device name Christoph Hellwig
2020-04-22 9:07 ` Jan Kara
2020-04-23 0:08 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 4/9] bdi: add a ->dev_name field to struct backing_dev_info Christoph Hellwig
2020-04-22 9:08 ` Jan Kara
2020-04-23 0:09 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 5/9] driver core: remove device_create_vargs Christoph Hellwig
2020-04-22 9:09 ` Jan Kara
2020-04-22 7:38 ` [PATCH 6/9] bdi: unexport bdi_register_va Christoph Hellwig
2020-04-23 0:11 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 7/9] bdi: remove bdi_register_owner Christoph Hellwig
2020-04-23 0:13 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 8/9] bdi: simplify bdi_alloc Christoph Hellwig
2020-04-23 0:13 ` Bart Van Assche
2020-04-22 7:38 ` [PATCH 9/9] bdi: remove the name field in struct backing_dev_info Christoph Hellwig
2020-04-23 0:16 ` Bart Van Assche
2020-04-25 7:59 ` bdi: fix use-after-free for dev_name(bdi->dev) v3 Christoph Hellwig
2020-04-25 10:43 ` Hans de Goede
2020-04-28 6:52 ` Christoph Hellwig
2020-05-04 12:47 bdi: fix use-after-free for dev_name(bdi->dev) v3 (resend) Christoph Hellwig
2020-05-04 12:47 ` [PATCH 1/9] vboxsf: don't use the source name in the bdi name Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2db7b68b-5117-4dab-ce57-6e8011711c23@redhat.com \
--to=hdegoede@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
--cc=yuyufen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®