From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756911AbcJYH7P (ORCPT ); Tue, 25 Oct 2016 03:59:15 -0400 Received: from mail-co1nam03on0071.outbound.protection.outlook.com ([104.47.40.71]:4831 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751194AbcJYH7M (ORCPT ); Tue, 25 Oct 2016 03:59:12 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH][V2] drm/amd/powerplay: fix spelling mistake and add KERN_WARNING to printks To: Colin King , Alex Deucher , David Airlie , Rex Zhu , =?UTF-8?Q?Nils_Wallm=c3=a9nius?= , References: <20161024231412.11164-1-colin.king@canonical.com> CC: From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <2dbb0991-34d1-670d-b581-0cf59c8848ae@amd.com> Date: Tue, 25 Oct 2016 09:43:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024231412.11164-1-colin.king@canonical.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:7981:7558:651e:827b:3af0] X-ClientProxiedBy: VI1PR06CA0011.eurprd06.prod.outlook.com (10.162.116.149) To DM5PR12MB1305.namprd12.prod.outlook.com (10.168.237.148) X-MS-Office365-Filtering-Correlation-Id: c2d3b85c-a8c4-4b4e-1874-08d3fcaa9fb9 X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1305;2:37hTadrzFRifg4j09WQI/Cdi9lK7IWVE4cFKSUykdp3M/1SsuqW6DpiM/+22Bq8ZNPV174D3WG23iqucVbqVG+2GYhOlsIUKiiR+EutWI7GFy4S3+vp2gaGuqVjqt8V2dVNozSAjW3jeUrlmjPAkkduMLbiooeLRoger1/iRe5cwoqyc5ujq2imUCodbPtZ0X+2jJgmdIm0BEBC6UxzuTw==;3:gFy+Ds6TK67YxwZra7gCJD2KFqKlvA7pDp8d2V9CqNWZpg6I5/4Mz3e0RJlWWjV0YkZUILynA+Z0ov5KyW4wv/6R8evv5U9Shsc49qZH1nwWVyY1J9nGJyZoIMZ/gNPsx+0wn/TSOMTrgLpgFeOlYA==;25:Zh74Ki16k107pyX7jFkVifRzYt6C3m6vvCUzd5a+JK+K4PC+dGibLWIBS1b/61M91DSghNa2DbBrHiXltsYAMl3XwqwMBOPuech5aGkErdtHyesQxz1e8DTINqXlU/TiOnFkeRHb+LIVtxkqGe1pxCIiaUS6Mq3fbVyuBuLsr2zZbjsjhyJJOiYN06XsKvoPEQrLCUy+U2n6U30rp7qczvFLrs0s0TmylTH8zZHHtQdAXKNJhA8s7MyNwNTtltWL7VX6mhWWYHhUGYrQY/98RJ0+SlfPWJV3YfWI2qqJbR7XDCVc1oCNojhQR94oYTmMA/POtPRx03FCgHeOwP+2py5bC4qwGfq9Z8405lJeTM6OMRQTKriOJppLIBlrri9JBnaG4fgPzAXRmfTvOTPDtM39rhWOaFcwrNF0mN3jCD0K1fdvUNN/i9stxoOrHqbA X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1305; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1305;31:5rUIDxkYfNJisv5ixG/SewsZK3EvjGvCdmOLhP2CkBW/EpDJpkvhNyUWOz4Nzz8g+5D8YhWjbAb/2NfWmm7z+x1qrCyhZUn3RpkIZE6gUnZTRBUdIuP+S8EBjPNUUygfOmpW7vwdf6yNajt4oD4DB5ctyvg4X80RSXN2dYiHdhHqLN1CutdiiijHfqEApH8ZmDWIgE9iesr5ZiViGVl50guDlmKtFq7bz0FXzYC7ZVk6pC5B3sdUocDZ1fjXVAGpS240UBV2RkqvV03h9rwanQ==;20:uRnooq6bZbb/duvvkYc3Bru0FHFHf7GOPN45q8WCFLxZQPRjSLXf3vHDhrCLycSxxOScI/zRjJCSegpD/E5Mas77VUCFf3df9SFqvTswAY9cdy/4MMLHVu+68HVBVXsLfFT+4rNBf2wJeNXjuLFVXKuWbXbomlICVU1e7nGBUZDA7r5TWNzErj/3P5Z+5WD/wpes2uwTaIjW3gzSppOohO9EvA7YZJBByu8CHlB53URBLrRnt+lmxp6SpGvKkm+wJeUDubff4inDiqsmLoI6qBMul2HGSuJzbVcSkt5YJqjh3q852YdhbfVBRoEr2+Avz8C6IrOAaan9hzu18ZH/QPXW5uCbg8rO++mScqGvMHqY1Iv4lj0f1K/1ClMPtACATcMJHeVNS+rI/SUpRv5PHMTL5WVEWxDL0ECmMNTF9tU74VAAdVlnzqWBFKqaGz+vELnbVHr3GHTtH7t7ksQlTxGRuN2sZGmTj4XJ8P0hKYPVepEll8+IKsj72Vknk1rq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110)(198206253151910); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1305;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1305; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1305;4:grJkxaNvwPkVdApiYkreDXxOV9tBdrn/xBGG/c3yYpJJ213OXi4Ody4Avj7G7TmItaxFP+ZOTdZUR1zNW3XY1wLWixFd1ynTlX7h8mFgEez1t8RQ5aGHOfToz167TJcQzShEDa0EzKxAE0HkRSoeMAmkg6fBcW31dXw5EZ00eXX3wrSdibSyRL6R8nuWDLXR+v5gvTOvTgsFRemB3P9nHpamY7Em8+6OTr2cgt0OwoWIB8KHspdR2EyWwONOerUYzvEQ/qxHdslqLQPyeUMmaL9z+hthmDZgSWdyJ1yPY7fTci6YewvQs1zmgkgc0kT4aFN/Jb0QnaLqZUZM960J/5M3aNhnCUQ7ObgKBPUYMNWHZi9JH8H/nidQa/CqkB5AOYkmz/hsfgJVC77ZDq22G0UisGXj1OrhONoVyMbzJyULOTliKWEGyspWJvr6MfSQp3/5oC/vrrvET+cWQvtBVhAZv4HcRGwiSg2IRASo5JVNOtXoBMHAOtxfaqilP2fl X-Forefront-PRVS: 01068D0A20 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(81156014)(7846002)(19580395003)(19580405001)(86362001)(92566002)(36756003)(81166006)(8676002)(83506001)(2870700001)(54356999)(64126003)(47776003)(575784001)(65956001)(65806001)(23676002)(4326007)(2906002)(65826007)(31696002)(6666003)(33646002)(305945005)(5660300001)(7736002)(50466002)(77096005)(6116002)(68736007)(1706002)(97736004)(5001770100001)(4001350100001)(101416001)(42186005)(76176999)(106356001)(2950100002)(50986999)(189998001)(105586002)(586003)(31686004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1305;H:[IPv6:2a02:908:1251:7981:7558:651e:827b:3af0];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMzA1OzIzOk1wUlh5VFM3SUszRFJzVC9KVTk3cml1NDRu?= =?utf-8?B?djBaL2ZzNmFVRUNpSWR3MjROVnJsZDlvZmRFR1RiRTEyTHduN09EYlh3Z1Yv?= =?utf-8?B?RXZiNEdZOEYzOFFDOGZOZDFKWDZHaWFyL1p5dGRrNzRueUFGWHRFMDhUbzl5?= =?utf-8?B?eU56ODJZQUQxY0pNUTRRNmJZeE44amdwQTRSRDNDT3F2Vm9pTStXdGlma3Uv?= =?utf-8?B?TkdMZHo3Y1ZUUk5NNG1DSTNBcXJSRmdacnVqbzVaNTFZZlRhaWlFelJyOS9R?= =?utf-8?B?V25wMndlSzNEc2xCWFFDQ0d3YmRLK3lPb1FIWUloRnJqaitmU2kvTkF4dTRn?= =?utf-8?B?ZXZLT1QrSks3Tkw1b3ZlMEtZZkNzMjZJUXpZY3pBOVdOMlRPUVRCUFE4TVNo?= =?utf-8?B?UjJBUm1FV1hpSERLaXNhSWJQYURubEpscE5qMHlYekJya0c5V3BrMzNFcFRk?= =?utf-8?B?R3F1UmJxMGtYZGNOZm52S2N3YXhCcFJESHBUVEJhS3g4RHl4SlRjb044cVdW?= =?utf-8?B?cTNXTzdVMWkwQkkrWVEvS25nSGtOd2x1ZWpEbkRIYitlSGFxSm90dEVLSkJW?= =?utf-8?B?eE5lb25DQW5HNFh3aU45Q21NVkQvZlRsblJhUGtXOUp1VFNTeXp6SGJFd2JS?= =?utf-8?B?MGM4VWtJUU9TQ2hJc1UzMWg1L3ROQWJ6akZFaDR5ck91c1h2RGVKOVZTN0Rk?= =?utf-8?B?ZDVUN1hKdXI1S0VSUXo4VlljekpQZUUveTZ6OXNwNjRIVk50UmlpbDlLcEg0?= =?utf-8?B?U2k2QW5qL1dvdXlEQkFiTk9sdCs4OGRFemh4ZUZTcmVJNGFBeEU5VVBGUmZa?= =?utf-8?B?eGxPNk1OMEh3Wm5PK1BPUXVmQkxJZFdUajZ6cFJzcEdTMXdmdHZER2FHUGph?= =?utf-8?B?WEdpb1hDaXFYVUVYNjYrVlAwRkxyKzhVYU5lZTE1ajJNZG1PUkd5RExmazQ3?= =?utf-8?B?ZFFVaHZXRmhvVGsvNjVOdVRvemtQU3Fua1F0cEQzN0hoelZ3bDR4Z2ZBZXVN?= =?utf-8?B?T1N3VlZjYThGMWF3cWFqOU5ZQW1reGVIb3RXeXBZUHp1YlVMTTQ2MFdab2ZO?= =?utf-8?B?N2xieXhDcWxodnVVSVhsTCtxeGcvcTFkZ28xeW91Z2RwRVJaWU5kSktkVkgz?= =?utf-8?B?YWJWQlFzL2MzYTl1VUpyY2lsVmtQZ3Z5TGdPTUtwWjdqRU9PeDJTZ2JyeVFq?= =?utf-8?B?UERlY0FndXlWVUt5YnJWMW5QOWpzZEJ1WkJyOVFuR0l1RmsyYVdLS3Iyc2hN?= =?utf-8?B?blFFL25BSkxDYUNZMEtrQ3lxaFUza3JsUVJIckRiLzUzRmJRcERuM3pyLzZU?= =?utf-8?B?eTRGRmZLMWFsYlpzQXNOWFRjaWxNMUt0NFVCalM5eERjNEE3UVFqbU95ektC?= =?utf-8?B?alREaE5yZnRiOWw2cUxlb2pVQkQrcjFkZU1UbkhITHdxbEVuSmdibUpwTExs?= =?utf-8?B?Sm1vbGR6R1ZzUFVobnhiV3Vwc2lOcWNPcE14cllndk8zeG5pOHZDY3VIZ0pM?= =?utf-8?B?TGlEKzBYOHlEMzN3WjhOTm4zWmxyMVEzWTNLSHhFZzY5a3V2WWcrRUxPN1h0?= =?utf-8?B?VEh3bzVaMGJIM3VjZzg2SmVGUW1QL3hpMlQ2anRQSFFBZE5OWFFWVldkWUUy?= =?utf-8?B?eDVCdDd5UEVyM1hzMzYrbGhNOUtJVEYrZzVTOFRaYTRIbjUvMHF2Q1A2d3dD?= =?utf-8?Q?VmQD7VF3kaUidrRYwYd8DfpCcM5vv+KZTbUkNez?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1305;6:Z1vJBV8Lqm5Ysv5j8idqer/ht7BgPn34NuHbaAy+7doCO8lt/hwkcbWktX8vtfoiMCKptX7TYW3jOAWPYTFgiqRNpLZDUSwuCAel0dCjQp6P4FnrDPlMPENGxQMwjpMpygWsFzk05kt+xJJEkcUciaa2ou5ggN9BTk6TIYvOYnTXaBtbfhnu1xOMRoatWONLTKVJy8gqm7DMQmFm+Xzb4Xwyj6Hb8o72kXVYKwiK15tS+bUzA4iT/KXWrEutlJsSxXpjw8JDNYnIL+s3jnr+IPkZUlzR7OuTbVy9QfEbb3gbGUdW3TtTYbhCnEsXA1VA9jUlmCO+S57/C/qE620FMSTruoypwKu46Y0Il+x1gU8=;5:05ZtRA95hMWCVIMizLx+m6ukldW84jrNw3gnIKiYo0YIGptNcAIJHkoIGuY5hx1YoZT3eFV9hoY24vLsJ3v5xdbQgFoKRhG66ueAUK7tTXBW2blUTP0yPQvJFL4jIrRu34Xawqthg/pyFwAqlgNPBw==;24:wU4vpOE6MIeTPSubXlFsVLFQy7+BI16Avq1i2SUyvbRE6v2HcxqkhIiP5SKZD4OeruiAFqtWAbV0DCmYMNr6Wo1kX+sWTeCZgc1otHngbOI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1305;7:hWOWWnxegaKgx7WD8DcBrpUPF6ufwIYuhpHoxOvTIiKguqcCdtxfZyhCVeqHRjv8DdUbdu/D+yji5GgvlWPjDNT5aB8LH97c96bHjRpfbXNJ7arkkOjRztjSiaCcUSBcqeJxXNSAHN7VYLyRKho85uD+9VwX5qtx78G7jtl6IEC21ThdQTaM/q/9tSbUasRGW5SldJpDP2Yn1FWNPeu6jWS7liQlFFGqviyuHJWz+4s1UEvW3mD6n/xQmmA76WVtfl9elxRulFFisKOKG60qPKkctq8pDCdrnh1FAmlMnrvKZCMhGKOPVFb4NSY55DtoGp28kUqWsxuYRSQXA7yPPMVhIHKl9/ovnsHD9OF0CgM=;20:XVgwMFLeitSfXmjlSHK2RvZ8zv1h0u3QD9+b8Egc0gshdubgxa2GJ6iBGB35EGtB4g/A1rEBksKgvVLjcA+C1Ux7sKs8DZ3ISqCXbDFvSQzzj7WQnX2xK9RICOA0VRDHpjwPDZpPDvWxMEMAzUdw37cRlPqVq9xgSqRdLA2oVqS2MvC3RHuXv/u/I3mCWOWprHil5g3XUU1/yror4vM1AE8PiR1V3mwM27K6H/NhbzJkDCMzQ0JMd/XlfP/eJWS8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2016 07:43:32.6805 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1305 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 25.10.2016 um 01:14 schrieb Colin King: > From: Colin Ian King > > Fix trivial spelling mistake cant't -> can't and add KERN_WARNING to > printk messages. Remove redundant spaces before \n too (thanks to > Joe Perches for spotting those). > > Signed-off-by: Colin Ian King Reviewed-by: Christian König . > --- > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c | 4 ++-- > drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c | 4 ++-- > drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c | 4 ++-- > drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c > index 76310ac..62e99d7 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smc.c > @@ -2125,7 +2125,7 @@ uint32_t fiji_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU73_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member); > return 0; > } > > @@ -2150,7 +2150,7 @@ uint32_t fiji_get_mac_definition(uint32_t value) > return SMU73_MAX_LEVELS_MVDD; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x\n", value); > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c > index 8c889ca..0cc20a8 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smc.c > @@ -2140,7 +2140,7 @@ uint32_t iceland_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU71_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member); > return 0; > } > > @@ -2163,7 +2163,7 @@ uint32_t iceland_get_mac_definition(uint32_t value) > return SMU71_MAX_LEVELS_MVDD; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x\n", value); > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > index 4ccc0b7..7236c51 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smc.c > @@ -2174,7 +2174,7 @@ uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU74_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x \n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member); > return 0; > } > > @@ -2201,7 +2201,7 @@ uint32_t polaris10_get_mac_definition(uint32_t value) > return SMU7_UVD_MCLK_HANDSHAKE_DISABLE; > } > > - printk("cant't get the mac of %x \n", value); > + printk(KERN_WARNING "can't get the mac of %x\n", value); > return 0; > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > index de2a24d..d08f6f1 100644 > --- a/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/tonga_smc.c > @@ -2651,7 +2651,7 @@ uint32_t tonga_get_offsetof(uint32_t type, uint32_t member) > return offsetof(SMU72_Discrete_DpmTable, LowSclkInterruptThreshold); > } > } > - printk("cant't get the offset of type %x member %x\n", type, member); > + printk(KERN_WARNING "can't get the offset of type %x member %x\n", type, member); > return 0; > } > > @@ -2675,7 +2675,7 @@ uint32_t tonga_get_mac_definition(uint32_t value) > case SMU_MAX_LEVELS_MVDD: > return SMU72_MAX_LEVELS_MVDD; > } > - printk("cant't get the mac value %x\n", value); > + printk(KERN_WARNING "can't get the mac value %x\n", value); > > return 0; > }