From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E18C001DE for ; Mon, 31 Jul 2023 12:30:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232622AbjGaMa5 (ORCPT ); Mon, 31 Jul 2023 08:30:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232615AbjGaMaw (ORCPT ); Mon, 31 Jul 2023 08:30:52 -0400 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8898C10DF; Mon, 31 Jul 2023 05:30:49 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0VofLXKW_1690806644; Received: from 30.221.150.94(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0VofLXKW_1690806644) by smtp.aliyun-inc.com; Mon, 31 Jul 2023 20:30:45 +0800 Message-ID: <2dc21269-2fa0-ea39-454d-5f12a414bc13@linux.alibaba.com> Date: Mon, 31 Jul 2023 20:30:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v5 3/5] perf test: Add pmu-event test for "Compat" and new event_field. To: John Garry , Ian Rogers Cc: Will Deacon , Mark Rutland , Robin Murphy , Ilkka Koskinen , Namhyung Kim , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-doc@vger.kernel.org, Zhuo Song , Shuai Xue References: <1690525040-77423-1-git-send-email-renyu.zj@linux.alibaba.com> <1690525040-77423-4-git-send-email-renyu.zj@linux.alibaba.com> From: Jing Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/7/28 下午4:30, John Garry 写道: > On 28/07/2023 07:17, Jing Zhang wrote: >> Add new event test for uncore system event which is used to verify the >> functionality of "Compat" matching multiple identifiers and the new event >> fields "EventIdCode" and "Type". >> > > Thanks for doing this. It looks ok. I just have a comment, below. > Thanks. >> Signed-off-by: Jing Zhang >> --- >>   .../pmu-events/arch/test/test_soc/sys/uncore.json  |  8 ++++ >>   tools/perf/tests/pmu-events.c                      | 55 ++++++++++++++++++++++ >>   2 files changed, 63 insertions(+) >> >> diff --git a/tools/perf/pmu-events/arch/test/test_soc/sys/uncore.json b/tools/perf/pmu-events/arch/test/test_soc/sys/uncore.json >> index c7e7528..879a0ae 100644 >> --- a/tools/perf/pmu-events/arch/test/test_soc/sys/uncore.json >> +++ b/tools/perf/pmu-events/arch/test/test_soc/sys/uncore.json >> @@ -12,5 +12,13 @@ >>              "EventName": "sys_ccn_pmu.read_cycles", >>              "Unit": "sys_ccn_pmu", >>              "Compat": "0x01" >> +   }, >> +   { >> +           "BriefDescription": "Counts total cache misses in first lookup result (high priority).", >> +           "Type": "0x05", >> +           "EventIdCode": "0x01", >> +           "EventName": "sys_cmn_pmu.hnf_cache_miss", >> +           "Unit": "arm_cmn", >> +           "Compat": "434*;436*;43c*;43a01" >>      } >>   ] >> diff --git a/tools/perf/tests/pmu-events.c b/tools/perf/tests/pmu-events.c >> index 1dff863b..e227dcd 100644 >> --- a/tools/perf/tests/pmu-events.c >> +++ b/tools/perf/tests/pmu-events.c >> @@ -255,9 +255,24 @@ struct perf_pmu_test_pmu { >>       .matching_pmu = "uncore_sys_ccn_pmu", >>   }; >>   +static const struct perf_pmu_test_event sys_cmn_pmu_hnf_cache_miss = { >> +    .event = { >> +        .name = "sys_cmn_pmu.hnf_cache_miss", >> +        .event = "type=0x05,eventid=0x01", >> +        .desc = "Counts total cache misses in first lookup result (high priority). Unit: uncore_arm_cmn ", >> +        .topic = "uncore", >> +        .pmu = "uncore_arm_cmn", >> +        .compat = "434*;436*;43c*;43a01", >> +    }, >> +    .alias_str = "type=0x5,eventid=0x1", >> +    .alias_long_desc = "Counts total cache misses in first lookup result (high priority). Unit: uncore_arm_cmn ", >> +    .matching_pmu = "uncore_arm_cmn_0", >> +}; >> + >>   static const struct perf_pmu_test_event *sys_events[] = { >>       &sys_ddr_pmu_write_cycles, >>       &sys_ccn_pmu_read_cycles, >> +    &sys_cmn_pmu_hnf_cache_miss, >>       NULL >>   }; >>   @@ -699,6 +714,46 @@ static int __test_uncore_pmu_event_aliases(struct perf_pmu_test_pmu *test_pmu) >>               &sys_ccn_pmu_read_cycles, >>           }, >>       }, >> +    { >> +        .pmu = { >> +            .name = (char *)"uncore_arm_cmn_0", >> +            .is_uncore = 1, >> +            .id = (char *)"43401", >> +        }, >> +        .aliases = { >> +            &sys_cmn_pmu_hnf_cache_miss, >> +        }, >> +    }, >> +    { >> +        .pmu = { >> +            .name = (char *)"uncore_arm_cmn_0", >> +            .is_uncore = 1, >> +            .id = (char *)"43602", >> +        }, >> +        .aliases = { >> +            &sys_cmn_pmu_hnf_cache_miss, >> +        }, >> +    }, >> +    { >> +        .pmu = { >> +            .name = (char *)"uncore_arm_cmn_1", > > Shouldn't this match some perf_pmu_test_event entry with same matching_pmu member? But is perf_pmu_test_event.matching_pmu member ever used for any checking??? > I need to double check because I was testing against 6.3-rc2. Thanks, Jing > Thanks, > John > >> +            .is_uncore = 1, >> +            .id = (char *)"43c03", >> +        }, >> +        .aliases = { >> +            &sys_cmn_pmu_hnf_cache_miss, >> +        }, >> +    }, >> +    { >> +        .pmu = { >> +            .name = (char *)"uncore_arm_cmn_1", >> +            .is_uncore = 1, >> +            .id = (char *)"43a01", >> +        }, >> +        .aliases = { >> +            &sys_cmn_pmu_hnf_cache_miss, >> +        }, >> +    } >>   }; >>     /* Test that aliases generated are as expected */