From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, cocci@systeme.lip6.fr
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Cheng Shengyu <cheng.shengyu@zte.com.cn>,
Gilles Muller <Gilles.Muller@lip6.fr>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Palix <nicolas.palix@imag.fr>,
Yi Wang <wang.yi59@zte.com.cn>,
Xue Zhihong <xue.zhihong@zte.com.cn>,
zhongshiqi <zhong.shiqi@zte.com.cn>
Subject: Re: [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search
Date: Wed, 23 Oct 2019 16:08:45 +0200 [thread overview]
Message-ID: <2dc38508-b7af-b5bf-2829-52c75514e499@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1910231054250.2335@hadrien>
> What is the relation between the last two if branches?
A small addition is proposed for this bash script.
> If the first one fails, does that mean that $COCCI has no definition?
No. - It was checked if an empty sting was passed.
A file system check is tried then to determine if a valid directory was specified.
This parameter could be used then for the specification of a specific start
directory for calling the tool “find”, couldn't it?
> In that case, is the final else useful?
Hopefully, yes.
Which software behaviour do you expect for a string which would not
be recognised as an usable directory in a specific moment
during script execution?
Regards,
Markus
next prev parent reply other threads:[~2019-10-23 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:32 [PATCH] Configuring COCCI parameter as a directory is supportted zhongshiqi
2019-10-23 8:55 ` Julia Lawall
2019-10-23 14:08 ` Markus Elfring [this message]
2019-10-23 13:20 ` [PATCH] coccicheck: Configuring COCCI parameter for supporting a directory search Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc38508-b7af-b5bf-2829-52c75514e499@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cheng.shengyu@zte.com.cn \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=wang.yi59@zte.com.cn \
--cc=xue.zhihong@zte.com.cn \
--cc=yamada.masahiro@socionext.com \
--cc=zhong.shiqi@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®