From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6AECC4167B for ; Mon, 11 Dec 2023 10:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234932AbjLKKYo convert rfc822-to-8bit (ORCPT ); Mon, 11 Dec 2023 05:24:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234939AbjLKKYl (ORCPT ); Mon, 11 Dec 2023 05:24:41 -0500 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C16D0D7; Mon, 11 Dec 2023 02:24:43 -0800 (PST) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id AD49D24E2D5; Mon, 11 Dec 2023 18:24:36 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 11 Dec 2023 18:24:36 +0800 Received: from [192.168.1.115] (180.164.60.184) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 11 Dec 2023 18:24:36 +0800 Message-ID: <2dc5ea49-9a5f-484a-98dc-1b35b79d0945@starfivetech.com> Date: Mon, 11 Dec 2023 18:24:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v3 5/6] drm/vs: Add hdmi driver Content-Language: en-US To: Maxime Ripard , Andy Yan CC: "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "tzimmermann@suse.de" , "airlied@gmail.com" , "krzysztof.kozlowski+dt@linaro.org" , William Qiu , Xingyu Wu , "paul.walmsley@sifive.com" , "aou@eecs.berkeley.edu" , "palmer@dabbelt.com" , "p.zabel@pengutronix.de" , Shengyang Chen , Jack Zhu , Changhuang Liang , "maarten.lankhorst@linux.intel.com" , "suijingfeng@loongson.cn" References: <20231204123315.28456-6-keith.zhao@starfivetech.com> <94a1f9fc-82fb-4a04-a44b-f9b20c2bdfdd@starfivetech.com> <40cdd3c7-174e-4611-9ea6-22cb56d1f62b@starfivetech.com> <43e42269.314.18c46dbb4c5.Coremail.andyshrk@163.com> <5a79a4b9.1bd7.18c4773c1ea.Coremail.andyshrk@163.com> From: Keith Zhao In-Reply-To: Content-Type: text/plain; charset="UTF-8" X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org hi Maxime: hi Andy: On 2023/12/8 17:14, Maxime Ripard wrote: > Hi, > > On Fri, Dec 08, 2023 at 11:23:37AM +0800, Andy Yan wrote: >> 在 2023-12-08 11:00:31，"Keith Zhao" 写道： >> > >> > >> >On 2023/12/8 8:37, Andy Yan wrote: >> >> Hi Keth： >> >> >> >> >> >> >> >> >> >> >> >> >> >> 在 2023-12-07 18:48:13，"Keith Zhao" 写道： >> >>> >> >>> >> >>>On 2023/12/7 17:02, Andy Yan wrote: >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> Hi Keith： >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> >> >>>> At 2023-12-06 22:11:33, "Keith Zhao" wrote: >> >>>>> >> >>>>> >> >>>>>On 2023/12/6 20:56, Maxime Ripard wrote: >> >>>>>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >> >>>>>>> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { >> >>>>>>> >> + { .compatible = "starfive,jh7110-inno-hdmi",}, >> >>>>>>> > >> >>>>>>> > So it's inno hdmi, just like Rockchip then? >> >>>>>>> > >> >>>>>>> > This should be a common driver. >> >>>>>>> >> >>>>>>> Rockchip has a inno hdmi IP. and Starfive has a inno hdmi IP. >> >>>>>>> but the harewawre difference of them is big , it is not easy to use the common driver >> >>>>>>> maybe i need the inno hdmi version here to make a distinction >> >>>>>> >> >>>>>> I just had a look at the rockchip header file: all the registers but the >> >>>>>> STARFIVE_* ones are identical. >> >>>>>> >> >>>>>> There's no need to have two identical drivers then, please use the >> >>>>>> rockchip driver instead. >> >>>>>> >> >>>>>> Maxime >> >>>>> >> >>>>>ok, have a simple test , edid can get . i will continue >> >>>> >> >>>> Maybe you can take drivers/gpu/drm/bridge/synopsys/dw-hdmi as a reference， this >> >>>> is also a hdmi ip used by rockchip/meson/sunxi/jz/imx。 >> >>>> We finally make it share one driver。 >> >>>>> >> >>>hi Andy: >> >>> >> >>>dw_hdmi seems a good choice , it can handle inno hdmi hardware by define its dw_hdmi_plat_data. >> >>>does it means i can write own driver files such as(dw_hdmi-starfive.c) based on dw_hdmi instead of add plat_data in inno_hdmi.c >> >>> >> >> >> >> I think the process maybe like this： >> >> >> >> 1. split the inno_hdmi.c under rockchip to inno_hdmi.c(the common part), inno_hdmi-rockchip.c(the soc specific part) >> >> 2. move the common part inno_hdmi.c to drivers/gpu/drm/bridge/innosilicon/ >> >> 3. add startfive specific part, inno_hdmi-startfive.c >> >> >> >> bellow git log from kernel three show how we convert dw_hdmi to a common driver: >> >> >> >> >> >> >> >> 12b9f204e804 drm: bridge/dw_hdmi: add rockchip rk3288 support >> >> 74af9e4d03b8 dt-bindings: Add documentation for rockchip dw hdmi >> >> d346c14eeea9 drm: bridge/dw_hdmi: add function dw_hdmi_phy_enable_spare >> >> a4d3b8b050d5 drm: bridge/dw_hdmi: clear i2cmphy_stat0 reg in hdmi_phy_wait_i2c_done >> >> 632d035bace2 drm: bridge/dw_hdmi: add mode_valid support >> >> 0cd9d1428322 drm: bridge/dw_hdmi: add support for multi-byte register width access >> >> cd152393967e dt-bindings: add document for dw_hdmi >> >> b21f4b658df8 drm: imx: imx-hdmi: move imx-hdmi to bridge/dw_hdmi >> >> aaa757a092c2 drm: imx: imx-hdmi: split phy configuration to platform driver >> >> 3d1b35a3d9f3 drm: imx: imx-hdmi: convert imx-hdmi to drm_bridge mode >> >> c2c3848851a7 drm: imx: imx-hdmi: return defer if can't get ddc i2c adapter >> >> b587833933de drm: imx: imx-hdmi: make checkpatch happy >> >> >> >hi Andy: >> >I got you means, >> >as I don't have a rockchip board on hand , to split the inno_hdmi.c can not be tested. >> > >> >how adout this idea: >> >1、split the starfive_hdmi.c under verisilicion to inno_hdmi.c(the common part), inno_hdmi-starfive.c(the soc specific part) >> >2. move the common part inno_hdmi.c to drivers/gpu/drm/bridge/innosilicon/ >> >3. In the future, inno hdmi.c under rockchip will reuse the public driver. >> >> I am not sure if drm maintainers are happy with this。 > > Not really, no. > > Because we would still have two drivers for the same controller, and a > common one that haven't really been tested on anything but a single > platform. So arguably a worse situation than what you were suggesting in > the first place. > > The best solution would be to find someone with a Rockchip board to test > your changes, or to get one if it's doable so you can test yourself. ok I will also try to buy a Rockchip 3036 board for self-test. According to the commit log idea provided by Andy before, make the inno_hdmi driver common module. would the steps be ok? (if I tested rockchip and starifve pass) 1. split the inno_hdmi.c under rockchip to inno_hdmi.c(the common part), inno_hdmi-rockchip.c(the soc specific part) 2. move the common part inno_hdmi.c to drivers/gpu/drm/bridge/innosilicon/ 3. add startfive specific part, inno_hdmi-startfive.c Thanks > > Maxime