From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Rob Clark <robin.clark@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Bart Van Assche <bvanassche@acm.org>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Konrad Dybcio <konradybcio@kernel.org>,
Akhil P Oommen <akhilpo@oss.qualcomm.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drm/msm/gem: Add some cleanup.h
Date: Tue, 27 Oct 2026 15:24:08 +0100 [thread overview]
Message-ID: <2dc67d8c-f406-44e9-bf54-12704a8792de@oss.qualcomm.com> (raw)
In-Reply-To: <20261027141430.20258-1-robin.clark@oss.qualcomm.com>
On 10/27/26 3:14 PM, Rob Clark wrote:
> Convert (most of) the msm_gem_lock() and friends over to scope based
> cleanup.
>
> Other than fixing a lock leak in msm_ioctl_gem_info_set_metadata() there
> should be no functional change.
[...]
> @@ -608,26 +600,20 @@ static int msm_ioctl_gem_info_get_metadata(struct drm_gem_object *obj,
> return 0;
> }
>
> - ret = msm_gem_lock_interruptible(obj);
> - if (ret)
> - return ret;
LLM is a bit grumpy since this no longer returns all of the return
codes that it can but I think it doesn't matter
There's a couple of single-line-scopes we could shave off but any
which way
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-10-27 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 14:14 Rob Clark
2026-10-27 14:24 ` Konrad Dybcio [this message]
2026-10-27 15:05 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc67d8c-f406-44e9-bf54-12704a8792de@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=akhilpo@oss.qualcomm.com \
--cc=bvanassche@acm.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®