From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B1811C860A for ; Mon, 18 May 2026 09:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779097211; cv=none; b=Y0OTWQvdjlFm2u1EoTNCg/Mdr5fYKaMDNuJqXRa/iX36EeL8ErKQkZrR2tySVEUqdcKHadWiyVDSuZpEnHj+5Y//YKy9lKKWOS3JLINY5ZSvXub+3H/CbYYh+0fIQc5a09Lvb36auwMBAjMtawAo/cWoapqvb3qF05GeKWB1+UU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779097211; c=relaxed/simple; bh=BbZDADV9aNJ8ydE14L+gU90RVsCd90buJJw+8cFtdeU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XaK+GaKLCnQEv5fBZ65eWLZPrO5FdkXZjWpNZYDHmIlRWvUL+TIZmGQvdUXSj3wZCY4fXcIT91fDjHJtNcyds89vvUPVg5hbmcB9Xmhp1XK81y7NqT+Qweluc6B1AMKqCr634WroauEPt64xdaGlRrBhXG9Yn0vI7LaBNpLHgAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pYmbloLU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Y84B8F6j; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pYmbloLU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Y84B8F6j" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64I7fZ3v2188792 for ; Mon, 18 May 2026 09:40:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lWFZw5xDeVN9rwM0z38SMphPc1np9JV8e43sR+KJnWc=; b=pYmbloLUXOYDrgdV MTJCyTa1SgSxp8UyD9RXP7uhel3YP7DfPIgnGs1XJF4doFwE6Ia15yMC0i7nTNc8 hrQXoxASlRR3u5tNnMDNIeNfy63eca0cbRF5AlVq+Cu2ZYSKl9cBcuUobtyuoaU2 +NeTDcnja/sJ0SXiT94+636o+NUZE9C+VGcfLSToUpW3IyBND6DoBI33MG0vheJg /zGDdycwG8pJHsSy3NZ2xXASh4Dwh6PEvz/onwf2+GpljuUbpnkaNJnyncqOP3Zf iwaru2Xy4tl5MnqsIP/xnRe3LF4V3HVis/qF7bIXCq69gyWnd8LAuuc8eM0JdyB+ 5q8Nww== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xkugg7n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 18 May 2026 09:40:09 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-366122e01fcso2123851a91.2 for ; Mon, 18 May 2026 02:40:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779097208; x=1779702008; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lWFZw5xDeVN9rwM0z38SMphPc1np9JV8e43sR+KJnWc=; b=Y84B8F6jzbZOAGHJpOPIFVhhyRpAFP+8i7jccmjgEMNDOSA8xLWaTPi+88p6Up6Oh2 dPgCQ2FToFae/w8nWpdrcGT99daWJ4C6o0puHL6ufxQpCPFembH/SxN/oeMRwQzMMXen +bE48ZItR/je5kProL0PH54GvBVRDQz4sObvJjh4xy2i5oqhDBqZcZz1kh7pcaXV4x2/ GY6eZMEQm82x5xdZnlQmfxfF91QAuMaLJTOW8QunfOMZ+urukPKylsH79qWdzR0g5NZc bcI0kwZelUaLucl7bfoGQY19Y1BptJYvw/O2o8n1TAyz+zydxVcC/U2ay6UZBLKtEQSi abvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779097208; x=1779702008; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lWFZw5xDeVN9rwM0z38SMphPc1np9JV8e43sR+KJnWc=; b=f8NMksyZqcmA3dM1OiQGwtSAMs14bd81cVEd8hX1WtVmvafreSs1XSnPVrYKarR7Zu Rh7KYpoWFzOxKLBoLLGVM9NT8AhaJ1jWoXLn1fmiOBOH0e72jlsKB+sIw1e63kA0XlnL z4oZoMu7rYdbRmW5pCbpfE8lMIXQDLA9+unvQumU5H6aviI8PX/vcu98//8gAFete32z pD0DhkijNSUuV1jZG5nX93af8AP8G1D7HzhtZAcXTlH/AioliVHeDMco0pGM0FGaFLto caDaUkTvNrXEYaz0CU3ZsDs4TQ+cIuRAFSpA3a20BUw/HHVKUvp2tMSLEsbSZ67VmMg0 Buxw== X-Forwarded-Encrypted: i=1; AFNElJ8JgOVfBu1ZHLr67GvvXYDVNsrsOP0OfmLMLgivGVivzvnu4GmoRQZpJDCwDeGqFbKfPT00iqsYX+1GySg=@vger.kernel.org X-Gm-Message-State: AOJu0Yzj5IoPlt/FwQBAtuHSR01VylazgclsP59uNnyD/TO0q9+sMquW Q2BvnmkUE1dcTueysM0bwQRWbkEArvZPC/tI53q0mfb5RHG4QGp/Vugb8ROgYLfyAKzda6WqH6P 6Ln/m9LgiclXYYGfW72EFEWMtV6oBx+LP4SKVr5B4158+FSmUiNKSJ1HZYD4MlZjoE/w= X-Gm-Gg: Acq92OGqgeIqUIP3Xj38WqZ5JSIuYKAugbMFQp9lHnIg1syMXXVP46msiPHssSJ8WFV 1QjUgHhlDfK4UIrM5sPZDlgmbkcq1+UBKJVIjpSKHtAFkv0KpuhslbDFSiEHoMGcZ+5F9WBdWkx Zx6RRcOpGF0GXJn46+ZGd9ztpSAaKuQcKiJpVI6D2xvAYb0T4HrqXgyTRHggSZUaXCmpyYvNJwl ZNOvYyVahqBh4fnfjeVnkKtvjiXeJsWjUE3HA7CVers7zE3TGXmgIIeKdIMIhhYoMT/ZAn/fTqZ SG3HZKzDNxWx1A0BVN313pURRFeMVWm75LG/vl/77x/J0//H01ifrK2Ap3gskWjaINRiabMCoAS 49VQcA3OGQuuCB2ejD/51lGnoGzB0jamQuiJaPI/ffCdXM5KFK/cCT+R9vFs6NCblBCEO/OAWOA x95KiOXRFGDwBf78IoEXkf8RQ= X-Received: by 2002:a17:903:3c43:b0:2bd:e43c:12d0 with SMTP id d9443c01a7336-2bde43c14b7mr37115275ad.28.1779097207935; Mon, 18 May 2026 02:40:07 -0700 (PDT) X-Received: by 2002:a17:903:3c43:b0:2bd:e43c:12d0 with SMTP id d9443c01a7336-2bde43c14b7mr37114865ad.28.1779097207406; Mon, 18 May 2026 02:40:07 -0700 (PDT) Received: from [10.133.33.94] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c16ac4asm134369635ad.33.2026.05.18.02.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 02:40:07 -0700 (PDT) Message-ID: <2dc8245b-cea3-414d-af3b-c9fcc5b06785@oss.qualcomm.com> Date: Mon, 18 May 2026 17:40:02 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] scsi: ufs: core: Add a quirk for extended TX EQTR Adapt L0L1L2L3 length To: Can Guo , avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, peter.wang@mediatek.com, martin.petersen@oracle.com, mani@kernel.org Cc: linux-scsi@vger.kernel.org, Alim Akhtar , "James E.J. Bottomley" , open list References: <20260501131641.826258-1-can.guo@oss.qualcomm.com> <20260501131641.826258-2-can.guo@oss.qualcomm.com> Content-Language: en-US From: Ziqi Chen In-Reply-To: <20260501131641.826258-2-can.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE4MDA5MiBTYWx0ZWRfXwXPZyCxLI6Yq aSvxK/4yPbmXv4Rw74N+ObzDhZFP99axXH9Zt0ntzJDwQhEBeSyLABGAmjPeUenrO8ieSNvaWNc 2TmoVjWaCRg9iX/H6/FE1jwSgOlw7+Zd7lHsvuZuExnMXmN+mE+5qNdzJmnKzeUV5cFYBY8htzV trpEKDNC1adCLgbFBc48A64ITNQmf9WFQgte/uojVCFJMyVoigUMrUJVrSKc9vgFRKdfH/sYIF1 HUs1IQLVTZgWBsoYTlCSQtgUdUyZen53vD+t7SaBuwPVULNm4viFMrYYslQI8WD+f0RpR6qsPRV wLasaMPXTi5qQltkdi5mclVlMh1YmmWvkwS1npm5gQTlMYpOH2COxiULSiTB91/q9cm2bvNwTRB vEHFWlWWrTA48Rxu/S6I1qyoCvu/fWRrvO1BOWOrDrPgC89tVfk4V125Br55Wh+v3KwWP0zlsnL vaP4303Z9MAQvRlR5eA== X-Proofpoint-GUID: 1WBmr2QtM7uvBuDJ70jF1S0uCKH7pDPp X-Proofpoint-ORIG-GUID: 1WBmr2QtM7uvBuDJ70jF1S0uCKH7pDPp X-Authority-Analysis: v=2.4 cv=FsY1OWrq c=1 sm=1 tr=0 ts=6a0ade79 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=IHJe4OGsecWJCRHte3IA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-18_02,2026-05-15_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605180092 On 5/1/2026 9:16 PM, Can Guo wrote: > Add a quirk to support TX Equalization Training (EQTR) using Adapt L0L1L2L3 > length which is larger than what is allowed by M-PHY spec ver 6.0. > > Signed-off-by: Can Guo Reviewed-by: Ziqi Chen > --- > drivers/ufs/core/ufs-txeq.c | 8 ++++++-- > include/ufs/ufshcd.h | 7 +++++++ > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/drivers/ufs/core/ufs-txeq.c b/drivers/ufs/core/ufs-txeq.c > index b2dc89124353..fe647450a7a1 100644 > --- a/drivers/ufs/core/ufs-txeq.c > +++ b/drivers/ufs/core/ufs-txeq.c > @@ -740,7 +740,9 @@ static int ufshcd_setup_tx_eqtr_adapt_length(struct ufs_hba *hba, > if (adapt_l0l1l2l3_cap_local > ADAPT_L0L1L2L3_LENGTH_MAX) { > dev_err(hba->dev, "local RX_HS_G%u_ADAPT_INITIAL_L0L1L2L3_CAP (0x%x) exceeds MAX\n", > gear, adapt_l0l1l2l3_cap_local); > - return -EINVAL; > + > + if (!(hba->quirks & UFSHCD_QUIRK_EXTENDED_TX_EQTR_ADAPT_LENGTH_L0L1L2L3)) > + return -EINVAL; > } > > ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_PEERRXHSG6ADAPTINITIALL0L1L2L3), > @@ -751,7 +753,9 @@ static int ufshcd_setup_tx_eqtr_adapt_length(struct ufs_hba *hba, > if (adapt_l0l1l2l3_cap_peer > ADAPT_L0L1L2L3_LENGTH_MAX) { > dev_err(hba->dev, "peer RX_HS_G%u_ADAPT_INITIAL_L0L1L2L3_CAP (0x%x) exceeds MAX\n", > gear, adapt_l0l1l2l3_cap_peer); > - return -EINVAL; > + > + if (!(hba->quirks & UFSHCD_QUIRK_EXTENDED_TX_EQTR_ADAPT_LENGTH_L0L1L2L3)) > + return -EINVAL; > } > > t_adapt_l0l1l2l3_local = adapt_cap_to_t_adapt_l0l1l2l3(adapt_l0l1l2l3_cap_local); > diff --git a/include/ufs/ufshcd.h b/include/ufs/ufshcd.h > index cfbc75d8df83..7a7c07636cf7 100644 > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -804,6 +804,13 @@ enum ufshcd_quirks { > * delay after enabling VCC to ensure it's stable. > */ > UFSHCD_QUIRK_VCC_ON_DELAY = 1 << 27, > + > + /* > + * This quirk indicates that Host supports TX Equalization Training > + * (EQTR) using Adapt L0L1L2L3 length which is larger than what is > + * allowed by M-PHY spec ver 6.0. > + */ > + UFSHCD_QUIRK_EXTENDED_TX_EQTR_ADAPT_LENGTH_L0L1L2L3 = 1 << 28, > }; > > enum ufshcd_caps {