From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp11.infineon.com (smtp11.infineon.com [217.10.52.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DBD396585 for ; Fri, 5 Jun 2026 08:15:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.10.52.105 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780647326; cv=none; b=dFPloDCxCCTQt/xkTbwKaqR4YLnrA1i0wR2xHa7vxMHJiqHUfLxxITkHIfYNs7dozlhqn+zqonJMVVOy3PPZFj8vsF+bTRo5kDbed2N47UIzvv4Bc//1UF1pHeG7uvw0EyGvSkBv3SaiheawRu3Zm+pE6MxuvkVsaGYXC0oW7xc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780647326; c=relaxed/simple; bh=KcfFM3Ef5kxs3GW7n6kmRe47f+J66FB5vsd6flO/M98=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=MN2QSjSZ3AEweYbPEtwVvAvY4WEc4Bdoa/gyYqk7NT8cyODbKvfYOjLB5pI2Qtm6qgTXaXqjmM2XOsw+Sjla1TmejU+ToZxYp1feF01ThV1bU+mh/PPeAZE0/+IfFbkJOYgZYy/YLjsDx88vm3JrJ77J/Juh9xZusq3MklYfzkc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=infineon.com; spf=pass smtp.mailfrom=infineon.com; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b=LbinDZz/; arc=none smtp.client-ip=217.10.52.105 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=infineon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=infineon.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=infineon.com header.i=@infineon.com header.b="LbinDZz/" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=infineon.com; i=@infineon.com; q=dns/txt; s=IFXMAIL; t=1780647325; x=1812183325; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=KcfFM3Ef5kxs3GW7n6kmRe47f+J66FB5vsd6flO/M98=; b=LbinDZz/mSAhWCpkcBYOgvmnv3cvCyNUlViN7oskfyp5nIA5F9WtELlL NuH/Gznh7IG2w3ZI3PjFpQxQOAO9pc0MSoH/Jj9R6LNbAErSkagKoc0PP X/sjr0WhjB6arpJKCQp7I1pxVkux+IaozK5/cFblSTMzij67QAAHukVUS g=; X-CSE-ConnectionGUID: mxU7hhFJR1WB47CsJwDZhA== X-CSE-MsgGUID: G7N+IkvxQgGswRTbegT4eg== X-IronPort-AV: E=McAfee;i="6800,10657,11807"; a="146041952" X-IronPort-AV: E=Sophos;i="6.24,188,1774306800"; d="scan'208";a="146041952" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO MUCSE805.infineon.com) ([172.23.29.31]) by smtp11.infineon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2026 10:15:17 +0200 Received: from MUCSE811.infineon.com (172.23.29.37) by MUCSE805.infineon.com (172.23.29.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 5 Jun 2026 10:15:16 +0200 Received: from MUCSE815.infineon.com (172.23.29.41) by MUCSE811.infineon.com (172.23.29.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.37; Fri, 5 Jun 2026 10:15:16 +0200 Received: from MUCSE815.infineon.com ([fe80::ed10:a720:3031:ca14]) by MUCSE815.infineon.com ([fe80::ed10:a720:3031:ca14%12]) with mapi id 15.02.2562.037; Fri, 5 Jun 2026 10:15:16 +0200 From: To: , , , , , CC: , Subject: RE: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Thread-Topic: [RFC PATCH 2/3] mtd: spi-nor: don't clear the SNOR_F_4B_OPCODES flag on failure Thread-Index: AQHc8cXW+2yTYSc9Ak2Dl3vFTgjg8LYvoNHQ Date: Fri, 5 Jun 2026 08:15:16 +0000 Message-ID: <2dc8af28c3014903ab2c3d04132ac5cf@infineon.com> References: <20260601125438.3481722-1-mwalle@kernel.org> <20260601125438.3481722-3-mwalle@kernel.org> In-Reply-To: <20260601125438.3481722-3-mwalle@kernel.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 >=20 > This was introduced in commit 548ed6847f530 ("mtd: spi-nor: Add the > SNOR_F_4B_OPCODES flag"). It looks like it was the rollback mechanism if > parsing the SFDP failed, but was setting that flag first. Nowadays, that > flag can only be set if spi_nor_parse_4bait() was successful. IOW, the > flags won't be left in an undefined state if parsing SFDP fails. >=20 > Remove the unneeded code to be able to rework spi_nor_init_params(). >=20 > Signed-off-by: Michael Walle Reviewed-by: Takahiro Kuwano