From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C098629DB6C for ; Mon, 4 May 2026 06:55:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777877745; cv=none; b=s9rdYMlM+WkWJnbXKj9E7geIhQQwqevo8WCiDz30I9047c2Do0NbXhlJKywdYoTmvVdpVkOgtGbkUuhGsoEv1elUMA20Jq+HNUpUXFITcApLz7mVgvUoGp2/xjdSDGWrmajqC7qWV0FYz7hObPWyknptteC3sX3rgj8FHGhglxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777877745; c=relaxed/simple; bh=GZIVdLl3kVhNX3ssX8Br2t3bbXFGzS51JUDVPw8q0Bc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=BFVwTTfUTVGKz+ttsNvuuNAIV2bZd6FQeC0P1rMVswwvfim1nfqo/iUfFPDSJhOO6Kk6jkD7+3ijlbu4LupjEVodQQrxk1E0rGAo33J3TMHXigz+tFRDzcZvXPQy6Yk/oA5ZxszqI/iiLbjQz2GtjxsNhagDoHFG4PrfkDrrhWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PzFbRXBS; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PzFbRXBS" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so1305704f8f.1 for ; Sun, 03 May 2026 23:55:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777877742; x=1778482542; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=EEUnp57+dFeSCCp/1A9NmDUxCYKBXLwpvi6Pa+bh8jg=; b=PzFbRXBSRWHpE5A3MRoZnlQ6SkX6zJ8jlZeDBoB5WF/Tx9yI2fgZ58I2spU7ilbZJz TjieBrVk3loB0eHILL1XONQru7OUhTJEOomu7DgsjzNRnRWDgor4fcqR27zTgXKpGAih IKCLlaFvlZjTnGtJ9x9iJHJJRV7ocukLRaqyw44UwzgC0RziHqfmkndvsPjyqNa7PRA8 VAaqZifUn41nD1jsl1yTXEr9yUCMwY0yX4yaAkgBa8FyKGsdM1zaCAIMclUYtXC6AZef x0Efo8jc5PGlIdHqw0gU2eop49gArETasmyXFvQVtFhGpzFijUWC2/DrkrNY19RZOrKJ 7oag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777877742; x=1778482542; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EEUnp57+dFeSCCp/1A9NmDUxCYKBXLwpvi6Pa+bh8jg=; b=A8rKLIgMEABvNOWarfC47knVxgCP/DOwersApCFqu146sBq5RSKB+c3WdeTMiKu+h5 vUkAhzl6PrKTcjBut7/tMCZXzK+wtXCQgtx1MjPucrZn3UIpKnnDVfz4f/sjQE5JgQ2I S3G+584YPqWWRSJ7ATBpR+eNwWZ28uHQ9cfm9dXknvsO31Q5VAUmIVfAXfrqA13DZ3rr URE762TfxMglt/cqznPVvOu461T3Hf2kRzzjy1yxYRpQQU8Kg+9kBmDmSaYDgHu5aYRU VVikfQdOxKrKRrK4X2rCGyqVH7hS5umWGFCik1lrxcKrTS2/RnvWvpLFt68VLNeQistR ZDmQ== X-Forwarded-Encrypted: i=1; AFNElJ+BaIE2HZWcA+AKnumxBBbnNbJnjnQYQvRApX0vL6FgtxCFUN7HMOasi0w1g9uZz8kk1sbaNaKYuJ1qVb4=@vger.kernel.org X-Gm-Message-State: AOJu0YxiszGwGez8hImYGEbkvP1qWmll2hhw4De3J8HPq5mAXn9R3AsW wtQaK5u1tfUhM+i5hz7RPViPdwaLWtkyUP/fAVIcQ3/uI5H2Vxy5o4b2n1Eev3WxcqE= X-Gm-Gg: AeBDietvgpOhQ1V+/L/OQvBJB1O2m7TkeqP/AWv9gXqTW14z0tP6hmozSWzpU1zD50b yCmCvi8GYarwgXJum4HomlRKrNi0SaUWEIuFEwnlN5y0jJnZBOQgKtrpvTnyhwYbkMjpkL1ZkSH 7zcU6BD8dzpaEkgrdJiFFFP2chHRqWY3MHsF4ypA4pBkTwKjk7Ax23IeOdNcpbRoEXZT1Wn965l yhhKLNEsZJ6yUy4s7Zn5lbTbXfCWcayDwCO9OazI/ymA/Pnr2kHEYZtP2vWi4UXWlnGH6v9KE4O n8RANB21TH5VFmthanv6PtRYHo7zAj9FgHjU8575W/I9vpzS72ZW17Cl1k26UM8FkVArMJxq6oD 5l/tVmgPk9J9WRgezfQOapxM3YnQ+ySBK5XrlUxefLJE2GfOnp5AYlU1bUlAHFNo4nvJ61zDoF0 FAHjQ4BA1+sTh2ABdFEzxttvHBEPBEc9x4knqifZnwV/M5xLlOtr7odWsgU8qULostn0uKLwzZS i8X0N27ZYeQpFB+MmSPndczOVV6 X-Received: by 2002:a05:6000:184e:b0:43d:7af0:3a7c with SMTP id ffacd0b85a97d-44bb61111a9mr14782036f8f.29.1777877741890; Sun, 03 May 2026 23:55:41 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:4245:af61:1735:3752? ([2a01:e0a:106d:1080:4245:af61:1735:3752]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-44a8f237368sm22625014f8f.14.2026.05.03.23.55.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 May 2026 23:55:41 -0700 (PDT) Message-ID: <2dca0303-b296-4abd-a716-89e08e71a915@linaro.org> Date: Mon, 4 May 2026 08:55:45 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v2 2/2] regulator: add SGM3804 Dual Output driver To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, KancyJoe References: <20260430-topic-sm8650-ayaneo-pocket-s2-sgm3804-v2-0-76108c65a560@linaro.org> <20260430-topic-sm8650-ayaneo-pocket-s2-sgm3804-v2-2-76108c65a560@linaro.org> <150cdb85-d0ac-4802-a09b-9dab1b9b805a@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/1/26 01:46, Mark Brown wrote: > On Thu, Apr 30, 2026 at 03:28:43PM +0200, Neil Armstrong wrote: >> On 4/30/26 12:34, Mark Brown wrote: >>> On Thu, Apr 30, 2026 at 10:48:47AM +0200, Neil Armstrong wrote: > >>>> +// SPDX-License-Identifier: GPL-2.0-only >>>> +/* >>>> + * SGMicro SGM3804 regulator Driver >>>> + * >>>> + * Copyright (C) 2025 Kancy Joe >>>> + * Copyright (C) 2026 Linaro Limited >>>> + * Author: Neil Armstrong >>>> + */ > >>> Please make the entire comment block a C++ one so things look more >>> intentional. > >> Sure, converted into: >> + * Copyright (C) 2026 Linaro Limited (Neil Armstrong ) > > That's not the issue - that's not converting into a C++ comment. Oh right sorry I was confused, and I'm still very confused, sure I'll convert it to C++ comment block even if I don't fully understand the rationale about it and how does this look more intentional. Do you want me to also switch _all_ comments to C++ style ? Neil