From: Paolo Abeni <pabeni@redhat.com>
To: Chad Aldreda <ca@modelmiser.com>,
Richard Cochran <richardcochran@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Shuangpeng Bai <shuangpeng.kernel@gmail.com>,
netdev@vger.kernel.org, stable@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ptp: vmclock: keep the device state until the last file is closed
Date: Thu, 12 Nov 2026 16:05:26 +0100 [thread overview]
Message-ID: <2dcdcc8c-0484-4fd0-b09e-723b32cbacd1@redhat.com> (raw)
In-Reply-To: <20261107150344.3946529-2-ca@modelmiser.com>
On 11/7/26 16:03, Chad Aldreda wrote:
> @@ -649,9 +680,20 @@ static void vmclock_remove(void *data)
> if (st->miscdev.minor != MISC_DYNAMIC_MINOR)
> misc_deregister(&st->miscdev);
>
> + /* Files still open now fail, and a poll() in progress returns */
> + WRITE_ONCE(st->removed, true);
> + wake_up_interruptible(&st->disrupt_wait);
I think that sashiko comment about using wake_up_interruptible_all()
is relevant:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261107150344.3946529-2-ca@modelmiser.com
/P
prev parent reply other threads:[~2026-11-12 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 15:03 Chad Aldreda
2026-11-12 15:05 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dcdcc8c-0484-4fd0-b09e-723b32cbacd1@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ca@modelmiser.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=shuangpeng.kernel@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®