mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Charan Teja Kalla <quic_charante@quicinc.com>
To: Yu Zhao <yuzhao@google.com>
Cc: David Hildenbrand <david@redhat.com>, <akpm@linux-foundation.org>,
	<zhaoyang.huang@unisoc.com>, <surenb@google.com>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	Kalesh Singh <kaleshsingh@google.com>
Subject: Re: [PATCH] Multi-gen LRU: skip CMA pages when they are not eligible
Date: Sat, 12 Aug 2023 10:39:13 +0530	[thread overview]
Message-ID: <2dce810b-3fa8-0ae3-1f74-b0c447c1ed71@quicinc.com> (raw)
In-Reply-To: <CAOUHufarW3utTCqk+tes-tbU7iRKCYa_GMZvSNxJrFRKWXMbWw@mail.gmail.com>

On 8/9/2023 10:39 PM, Yu Zhao wrote:
>> On Wed, Aug 9, 2023 at 7:00 AM David Hildenbrand <david@redhat.com> wrote:
>>> On 09.08.23 10:05, Charan Teja Kalla wrote:
>>>> This patch is based on the commit 5da226dbfce3("mm: skip CMA pages when
>>>> they are not available") which skips cma pages reclaim when they are not
>>>> eligible for the current allocation context. In mglru, such pages are
>>>> added to the tail of the immediate generation to maintain better LRU
>>>> order, which is unlike the case of conventional LRU where such pages are
>>>> directly added to the head of the LRU list(akin to adding to head of the
>>>> youngest generation in mglru).
>>>>
>>>> No observable issue without this patch on MGLRU, but logically it make
>>>> sense to skip the CMA page reclaim when those pages can't be satisfied
>>>> for the current allocation context.
>>>>
>>>> Signed-off-by: Charan Teja Kalla <quic_charante@quicinc.com>
>> Reviewed-by: Kalesh Singh <kaleshsingh@google.com>
> Thanks, Charan! Do we need a "Fixes" tag?
I think the below tag matches.

Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
> 

      reply	other threads:[~2023-08-12  5:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09  8:05 Charan Teja Kalla
2023-08-09 14:00 ` David Hildenbrand
2023-08-09 15:54   ` Kalesh Singh
2023-08-09 17:09     ` Yu Zhao
2023-08-12  5:09       ` Charan Teja Kalla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dce810b-3fa8-0ae3-1f74-b0c447c1ed71@quicinc.com \
    --to=quic_charante@quicinc.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=kaleshsingh@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=surenb@google.com \
    --cc=yuzhao@google.com \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®