mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Alexander Usyskin" <alexander.usyskin@intel.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Simon Richter" <Simon.Richter@hogyros.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] misc/mei: INTEL_MEI should depend on X86 or DRM_XE
Date: Wed, 28 Jan 2026 07:50:10 +0100	[thread overview]
Message-ID: <2dd8286a-a3c7-4a3d-bd5d-011966dc07f9@app.fastmail.com> (raw)
In-Reply-To: <CY5PR11MB6366560330FE64F22ADF2C2EED91A@CY5PR11MB6366.namprd11.prod.outlook.com>

On Wed, Jan 28, 2026, at 07:41, Usyskin, Alexander wrote:
>> Subject: [PATCH] misc/mei: INTEL_MEI should depend on X86 or DRM_XE
>> 
>> The Intel Management Engine Interface is only present on x86 platforms
>> and Intel Xe graphics cards.  Hence add a dependency on X86 or DRM_XE,
>> to prevent asking the user about this driver when configuring a kernel
>> for a non-x86 architecture and without Xe graphics support.
>> 
>> Fixes: 25f9b0d351552f63 ("misc/mei: Allow building Intel ME interface on
>> non-x86")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>> ---
>>  drivers/misc/mei/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/misc/mei/Kconfig b/drivers/misc/mei/Kconfig
>> index 5902dd1ee44baf16..094fb1dde0fe80c5 100644
>> --- a/drivers/misc/mei/Kconfig
>> +++ b/drivers/misc/mei/Kconfig
>> @@ -3,6 +3,7 @@
>>  config INTEL_MEI
>>  	tristate "Intel Management Engine Interface"
>>  	depends on PCI
>> +	depends on X86 || DRM_XE!=n || COMPILE_TEST
>
> Add DRM_I915 here too, MEI may depend on it.

Based on the patch description, shouldn't the dependency allow
compile-testing only if both XE and I915 are turned off, as in

      depends on X86  || (DRM_XE=n && DRM_I915=n && COMPILE_TEST)

?

As far as I can tell, i915 and xe will attempt (and fail) to
use MEI if that is enabled, so there is no point in enabling
INTEL_MEI outside of compile-testing even if XE is built.

       Arnd

  reply	other threads:[~2026-01-28  6:50 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27 19:11 Geert Uytterhoeven
2026-01-28  6:41 ` Usyskin, Alexander
2026-01-28  6:50   ` Arnd Bergmann [this message]
2026-01-28  6:57     ` Usyskin, Alexander
2026-01-28  7:24       ` Arnd Bergmann
2026-01-29  4:45       ` Simon Richter
2026-01-29  5:53         ` Usyskin, Alexander
2026-01-30 21:15           ` Rodrigo Vivi
2026-02-01 10:15             ` Usyskin, Alexander
2026-02-02  9:33               ` Geert Uytterhoeven
2026-02-02 11:43                 ` Usyskin, Alexander
2026-01-29  8:17         ` Geert Uytterhoeven
2026-01-29  8:53           ` Arnd Bergmann
2026-01-29  9:01           ` Usyskin, Alexander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2dd8286a-a3c7-4a3d-bd5d-011966dc07f9@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=Simon.Richter@hogyros.de \
    --cc=alexander.usyskin@intel.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®