From: Florian Fainelli <f.fainelli@gmail.com>
To: Jon Hunter <jonathanh@nvidia.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Ard Biesheuvel <ardb@kernel.org>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux@roeck-us.net, shuah@kernel.org, patches@kernelci.org,
lkft-triage@lists.linaro.org, pavel@denx.de,
sudipm.mukherjee@gmail.com, slade@sladewatkins.com,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 4.9 00/25] 4.9.316-rc1 review
Date: Tue, 24 May 2022 11:42:14 -0700 [thread overview]
Message-ID: <2dd9228b-8fb8-6877-5825-3923b15b9796@gmail.com> (raw)
In-Reply-To: <97cf35b5-1286-91a0-c0d4-df7fe8a983e6@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 4336 bytes --]
On 5/24/22 10:50, Jon Hunter wrote:
>
> On 24/05/2022 17:30, Florian Fainelli wrote:
>
> ...
>
>> Jonathan any chance this is Tegra specific? Our ARCH_BRCMSTB SoCs
>> which use a Brahma-B15 which uses nearly the same ca15 processor
>> functions defined in arch/arm/mm/proc-v7.S reports the following
>> *before* changes:
>>
>> [ 0.001641] CPU: Testing write buffer coherency: ok
>> [ 0.001685] CPU0: Spectre v2: using ICIALLU workaround
>> [ 0.001703] ftrace: allocating 30541 entries in 120 pages
>> [ 0.044600] CPU0: update cpu_capacity 1024
>> [ 0.044633] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
>> [ 0.044662] Setting up static identity map for 0x200000 - 0x200060
>> [ 0.047410] brcmstb: biuctrl: MCP: Write pairing already disabled
>> [ 0.048974] CPU1: update cpu_capacity 1024
>> [ 0.048978] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
>> [ 0.048981] CPU1: Spectre v2: using ICIALLU workaround
>> [ 0.050234] CPU2: update cpu_capacity 1024
>> [ 0.050238] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002
>> [ 0.050241] CPU2: Spectre v2: using ICIALLU workaround
>> [ 0.051437] CPU3: update cpu_capacity 1024
>> [ 0.051441] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003
>> [ 0.051444] CPU3: Spectre v2: using ICIALLU workaround
>> [ 0.051532] Brought up 4 CPUs
>>
>> and this *after* merging 4.9.316-rc1:
>>
>> [ 0.001626] CPU: Testing write buffer coherency: ok
>> [ 0.001670] CPU0: Spectre v2: using ICIALLU workaround
>> [ 0.001689] CPU0: Spectre BHB: using loop workaround
>> [ 0.001705] ftrace: allocating 30542 entries in 120 pages
>> [ 0.043752] CPU0: update cpu_capacity 1024
>> [ 0.043784] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000
>> [ 0.043813] Setting up static identity map for 0x200000 - 0x200060
>> [ 0.046547] brcmstb: biuctrl: MCP: Write pairing already disabled
>> [ 0.048121] CPU1: update cpu_capacity 1024
>> [ 0.048124] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001
>> [ 0.048129] CPU1: Spectre v2: using ICIALLU workaround
>> [ 0.048165] CPU1: Spectre BHB: using loop workaround
>> [ 0.049398] CPU2: update cpu_capacity 1024
>> [ 0.049402] CPU2: thread -1, cpu 2, socket 0, mpidr 80000002
>> [ 0.049405] CPU2: Spectre v2: using ICIALLU workaround
>> [ 0.049440] CPU2: Spectre BHB: using loop workaround
>> [ 0.050613] CPU3: update cpu_capacity 1024
>> [ 0.050617] CPU3: thread -1, cpu 3, socket 0, mpidr 80000003
>> [ 0.050619] CPU3: Spectre v2: using ICIALLU workaround
>> [ 0.050653] CPU3: Spectre BHB: using loop workaround
>> [ 0.050722] Brought up 4 CPUs
>> [ 0.050738] SMP: Total of 4 processors activated (216.00 BogoMIPS).
>> [ 0.050753] CPU: All CPU(s) started in HYP mode.
>
>
> Does your platform support CPU idle? I see this being triggered
> during CPU idle transitions ...
It does, but not with an idle state resulting in powering down secondary
cores. We do have CPU hotplug with power gating as well as system wide
suspend states that result in power gating secondaries and they appear
to be working fine.
I use the attached script to randomly cycle hot plug/unplug through each
4 cores and it has been running over 10k cycles.
>
> [ 4.415167] CPU0: Spectre BHB: using loop workaround
> [ 4.417621] [<c01109a0>] (unwind_backtrace) from [<c010b7ac>]
> (show_stack+0x10/0x14)
> [ 4.430291] [<c010b7ac>] (show_stack) from [<c09c2b38>]
> (dump_stack+0xc0/0xd4)
> [ 4.437512] [<c09c2b38>] (dump_stack) from [<c011a6c8>]
> (cpu_v7_spectre_bhb_init+0xd8/0x190)
> [ 4.445943] [<c011a6c8>] (cpu_v7_spectre_bhb_init) from [<c010dee8>]
> (cpu_suspend+0xac/0xc8)
> [ 4.454377] [<c010dee8>] (cpu_suspend) from [<c011e7e4>]
> (tegra114_idle_power_down+0x74/0x78)
> [ 4.462898] [<c011e7e4>] (tegra114_idle_power_down) from [<c06d3b44>]
> (cpuidle_enter_state+0x130/0x524)
> [ 4.472286] [<c06d3b44>] (cpuidle_enter_state) from [<c0164a30>]
> (do_idle+0x1b0/0x200)
> [ 4.480199] [<c0164a30>] (do_idle) from [<c0164d28>]
> (cpu_startup_entry+0x18/0x1c)
> [ 4.487762] [<c0164d28>] (cpu_startup_entry) from [<801018cc>]
> (0x801018cc)
>
> Jon
>
--
Florian
[-- Attachment #2: hotplug.sh --]
[-- Type: application/x-shellscript, Size: 699 bytes --]
next prev parent reply other threads:[~2022-05-24 18:42 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 17:03 Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 01/25] floppy: use a statically allocated error counter Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 02/25] um: Cleanup syscall_handler_t definition/cast, fix warning Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 03/25] Input: add bounds checking to input_set_capability() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 04/25] MIPS: lantiq: check the return value of kzalloc() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 05/25] drbd: remove usage of list iterator variable after loop Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 06/25] ARM: 9191/1: arm/stacktrace, kasan: Silence KASAN warnings in unwind_frame() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 07/25] mmc: core: Specify timeouts for BKOPS and CACHE_FLUSH for eMMC Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 08/25] mmc: block: Use generic_cmd6_time when modifying INAND_CMD38_ARG_EXT_CSD Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 09/25] mmc: core: Default to generic_cmd6_time as timeout in __mmc_switch() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 10/25] ALSA: wavefront: Proper check of get_user() error Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 11/25] perf: Fix sys_perf_event_open() race against self Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 12/25] drm/dp/mst: fix a possible memory leak in fetch_monitor_name() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 13/25] net: vmxnet3: fix possible use-after-free bugs in vmxnet3_rq_alloc_rx_buf() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 14/25] net: vmxnet3: fix possible NULL pointer dereference in vmxnet3_rq_cleanup() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 15/25] net/qla3xxx: Fix a test in ql_reset_work() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 16/25] NFC: nci: fix sleep in atomic context bugs caused by nci_skb_alloc Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 17/25] net: af_key: add check for pfkey_broadcast in function pfkey_process Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 18/25] ARM: 9196/1: spectre-bhb: enable for Cortex-A15 Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 19/25] ARM: 9197/1: spectre-bhb: fix loop8 sequence for Thumb2 Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 20/25] igb: skip phy status check where unavailable Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 21/25] perf bench numa: Address compiler error on s390 Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 22/25] scsi: qla2xxx: Fix missed DMA unmap for aborted commands Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 23/25] mac80211: fix rx reordering with non explicit / psmp ack policy Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 24/25] ethernet: tulip: fix missing pci_disable_device() on error in tulip_init_one() Greg Kroah-Hartman
2022-05-23 17:03 ` [PATCH 4.9 25/25] net: stmmac: fix missing pci_disable_device() on error in stmmac_pci_probe() Greg Kroah-Hartman
2022-05-23 17:43 ` [PATCH 4.9 00/25] 4.9.316-rc1 review Florian Fainelli
2022-05-23 22:58 ` Shuah Khan
2022-05-24 8:32 ` Jon Hunter
2022-05-24 12:09 ` Greg Kroah-Hartman
2022-05-24 14:55 ` Jon Hunter
2022-05-24 15:06 ` Greg Kroah-Hartman
2022-05-24 16:30 ` Florian Fainelli
2022-05-24 17:50 ` Jon Hunter
2022-05-24 18:42 ` Florian Fainelli [this message]
2022-05-25 9:05 ` Jon Hunter
2022-05-24 13:05 ` Naresh Kamboju
2022-05-24 15:27 ` Pavel Machek
2022-05-24 20:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd9228b-8fb8-6877-5825-3923b15b9796@gmail.com \
--to=f.fainelli@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkft-triage@lists.linaro.org \
--cc=patches@kernelci.org \
--cc=pavel@denx.de \
--cc=shuah@kernel.org \
--cc=slade@sladewatkins.com \
--cc=stable@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®