From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76720215F4F for ; Fri, 20 Dec 2024 15:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734708008; cv=none; b=cRE+id01ycbe0Ou+zogL/pYTFT8RdkNMvatNkRiQbvCq3pOSnbyazEaJrPQ/j5c8hip7uyCSp/2Yyc8dQT6LJSuYLALk4cQcPq+gSQFyPRI8YOPlDcg2X6+V5u4GlWxwCcCHSx9wFh4LSCLNN0HZVaZhuvtLpw/oUsXffO/XgY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734708008; c=relaxed/simple; bh=RZEPWgLYDjiHN3vx58NrJVMH7U4OowqBjurZVfJ+3to=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OIEDLGtYTHHmILU84T+zNdp4CeDfoy91UYDjzl3kFobr+HAtgF/zNqk9BecIrzJMF3DElHPQJZrvhxy2RTYDzRuCE9dJvF+gvo2ouoaQ5Ghz3fgwbDxZrq5UnGqdOKaonI619ghPsyt/WQ5eUFp3XZKu06dfxLp1+9TYSI7oEiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Vq4XQT8E; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Vq4XQT8E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734708005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=GSLhLAF27Dus1djWbXuEQF2P4ueNwx/IWO+wl4w6Zb0=; b=Vq4XQT8Etal4YtTTHfMk3r0aZNjSqU3Om4Y/dcqkCOKyMewLcdAT1PBub//zOErh2W4Qjt QFe2xD5MllZgHfoRi+9QGI6EBJY2Q6La4i+6zQ5uco9aefem/I6dlEa7es/vA34B3UK8Xu dKUNAOET/v4b7awl6AKeaQT6Lo2SS3g= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-AQaqqUvROpiynF60Bnv6kg-1; Fri, 20 Dec 2024 10:20:03 -0500 X-MC-Unique: AQaqqUvROpiynF60Bnv6kg-1 X-Mimecast-MFC-AGG-ID: AQaqqUvROpiynF60Bnv6kg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43626224274so11980415e9.0 for ; Fri, 20 Dec 2024 07:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734708002; x=1735312802; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GSLhLAF27Dus1djWbXuEQF2P4ueNwx/IWO+wl4w6Zb0=; b=ud+LsirdI10cLfkFV84xW05f7lKuE8pSldmHigPnyrxUcgm/CW3cRIIKWvm/drUrEF qydS4rw9tVc8C21eYey64fjwwG1R9L8Fxcg0GFmXSrLK2DhpL2AjSag7sIu2RSt24mmJ jrMBy9d1x8VAjiumTRxLt3dKsTM0YEq1nZTOe+YUrcgzdiLbyoH51jO+ZmXwOpmQGpLa kUc/QeEpcTtQuGderYS5rfzfnvPcqOkPSVnBTFKPru5rXhSinp82hCOsM5fcvbaQB8fn iUgfVDD9WviIZUf+gtLAuRig6/4xsEbHQTgqqMIctCmvfOWGDlH6Z/d67z93nAOh29Os 365w== X-Forwarded-Encrypted: i=1; AJvYcCWa4Nz27nkfKnwtejX9w8GJV3qwH90EBKLozTGCZgc5gfhcQCB1Q5nVwpXz0DNJ8ALiOgz6REcKehp5acA=@vger.kernel.org X-Gm-Message-State: AOJu0YxmC5SkcS4gi63dpWe7F5sVrvuq9f04/iSxIQYOS14xZXSZU02M 6n2TFiKPh9AsbSc2Wr28eR3P0ZGLZpR9sUipb1wFgFhfSHBNLhyGvfI1gRKbVC519cCSMx+4YaW seHrk29EmBIt+8nsFlGFWjhecg5GvJ5Flmfl2Se4T9Rg0Tf8Cl0oA5EPPOLZ6ng== X-Gm-Gg: ASbGncsPe7gBaPyU2DT4xUjAkBYIwiFoi7V5PkQxrwoGIRhihPRLrAFHTB8x807FEn0 gaGPRaJnl+R+4sEzb9D4iUW4yl2bKnAavTGJyUb1BY95i2NwI+YCRRzGRN6NNNsI0Wimy0YI8P+ ZFrOEuCrmQNAt8zIYW1jEpNAdfm0uDHeBEL3SE3pbwmYOistBTT1A1XQyARLCtE7sKiFX0VRiZC PT5P3VpT5s1/5yzL4vBQwwHP8jR6YCSGo3ys3s6m3Y2arbPo0GgEKiRue+QSaIytW9LCKqLTzUv EXrLRfFQrjdHlmXsHSPOpXq+tDKhkU0CXEPfMCWGbPZXF4a2aocS69En/d6gFQLWi5Yynrd5diC iH/28EQsz X-Received: by 2002:a05:600c:5488:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-43668b498ddmr26296505e9.26.1734708002599; Fri, 20 Dec 2024 07:20:02 -0800 (PST) X-Google-Smtp-Source: AGHT+IEW1Oqhfdpc6oK9Vd1HWU9G3K1S0GmvUViZlC6eqIxnVLitf33vN/LN4J02Qp4R9fzoO9abEw== X-Received: by 2002:a05:600c:5488:b0:436:5165:f21f with SMTP id 5b1f17b1804b1-43668b498ddmr26296315e9.26.1734708002277; Fri, 20 Dec 2024 07:20:02 -0800 (PST) Received: from ?IPV6:2003:cb:c708:9d00:edd9:835b:4bfb:2ce3? (p200300cbc7089d00edd9835b4bfb2ce3.dip0.t-ipconnect.de. [2003:cb:c708:9d00:edd9:835b:4bfb:2ce3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c832e53sm4265574f8f.27.2024.12.20.07.20.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 07:20:01 -0800 (PST) Message-ID: <2dde1a51-f4c2-4e0b-8ac6-b9859e194304@redhat.com> Date: Fri, 20 Dec 2024 16:20:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] mm: add PG_dropbehind folio flag To: "Kirill A. Shutemov" Cc: Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, bfoster@redhat.com, Vlastimil Babka References: <20241213155557.105419-1-axboe@kernel.dk> <20241213155557.105419-5-axboe@kernel.dk> <042d3631-e3ab-437a-b628-4004ca3ddb45@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.12.24 16:12, Kirill A. Shutemov wrote: > On Fri, Dec 20, 2024 at 04:03:44PM +0100, David Hildenbrand wrote: >> On 20.12.24 12:08, Kirill A. Shutemov wrote: >>> On Fri, Dec 13, 2024 at 08:55:18AM -0700, Jens Axboe wrote: >>>> Add a folio flag that file IO can use to indicate that the cached IO >>>> being done should be dropped from the page cache upon completion. >>>> >>>> Signed-off-by: Jens Axboe >>> >>> Reviewed-by: Kirill A. Shutemov >>> >>> + David, Vlastimil. >>> >>> I think we should consider converting existing folio_set_reclaim() / >>> SetPageReclaim() users to the new flag. From a quick scan, all of them >>> would benefit from dropping the page after writeback is complete instead >>> of leaving the folio on the LRU. >> >> I wonder of there are some use cases where we write a lot of data to then >> only consume it read-only from that point on (databases? fancy AI stuff? no >> idea :) ). > > Do we use PG_reclaim for such cases? Good point, I looked at the pageout() case, but there we really want to pageout that thing and not just write it back, so makes sense to me. -- Cheers, David / dhildenb