From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A63233793DB for ; Fri, 27 Mar 2026 11:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611163; cv=none; b=n5xnH5KSyMsBW4OFuyCLyXjBEUJPsdMcHqkiJNs0VHjnI6t+qPtMJQ04tv/tsS3i/4AykCv0FBKJ8h271DVp1A5FcLNMOrwB0xzZmDP9FcVERT5/tbsTdbYFwZ0jeZ5+78ejctOAh6FNcI/rQchUA0poVRljXftMtszaVS4Ocv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774611163; c=relaxed/simple; bh=Dfbt6a26su4If6yjXSaIWsczfXA+UlYzh7DSG2hxcvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XFTEAtQZo0OIMKxo15gw0YACYKlftyokEwN2GQD3Ao4PAiXU8S9I91+biBVszI6q2hCr8ubftjLoHx/h+00uRuUVYl4fRjTheeRSAGqUZme5H0DtUtEFwDqh3YhYuKnG9h/DDl4EgRXzQcvRXV7H3G2jxE4y1N+WWhq05eifg9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cI8GtQcY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KmwIQYjs; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cI8GtQcY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KmwIQYjs" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62R6vod13715938 for ; Fri, 27 Mar 2026 11:32:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= chefL0VhCP2pkztsvpJhn296SxnIHxiefqjU+kXnQV8=; b=cI8GtQcYB+hiYNoF CkemIfXlARwTQCsG9MN2k0UDCiLCkt/V7+QFFfHWNuNem27Qmb66I8Uznq+n9ZAp J/SN9i1rogwo9FlCkMsS0HbOHEprZWPdhSN5ZVBRsvCyV06S9CO+Ay8thXyrWiCr R1eUCieIKXoq/RVLQkuqskhB89f/7k7/xDG24/XGjDbHnRrCzOckHZUXzgPsUnuo OLlcZg3v+3QsbSfyvU+HKJOwNTBOPvlwVl12r2JWGBQm0eozlkPamT62cx7TsZz0 5E7Ty2jnSVn94IUx33rac8NJmQLhqd85Hn1MDmX3lkhK1ljTP6Q7RuiFMaJfyIGv 51whLQ== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d5dd6jj8v-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 27 Mar 2026 11:32:39 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8cfbd336c3eso66363985a.2 for ; Fri, 27 Mar 2026 04:32:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774611159; x=1775215959; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=chefL0VhCP2pkztsvpJhn296SxnIHxiefqjU+kXnQV8=; b=KmwIQYjsKyXLgRUYeJ58vmiFvTFs4v4BIk2gn+IVio/YOVsvvu4+RVm5KKYxunfHK3 3UN4gcZUNvNIUxJ5NY3CCjHMdX4Lhv8H3JCowDTTSxIeKBApp9A4+jd+h/3tDWFYPyRc vYOeir2i82fw42hiVpLuFk2I4GPR+LkqDNmW4Kf6By97n1ZQabzl0ySU3Lr9wrJkNMiW JFUXifwZToeEy79PzONqmhfILtblfGisPswnbwqFsEC+PR1G+12sSqJSPceAj6pVKFD8 xwaAOt4tz/Kw60PoqgDpkWe8o9W0ZbtA/4kz/gLc97pnJheQXFrxzt0mYNmAKjavRxgw czdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774611159; x=1775215959; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=chefL0VhCP2pkztsvpJhn296SxnIHxiefqjU+kXnQV8=; b=WgPsHv1H/7sfQYlxty2182nMdS/pTMdFDJ994cgjnB20or1wzvHs4qkX6Fc9jRhG62 +oL15QDDZPYbWCugZPdwm0RrxnR+0poj8sx2Cq0g/zLwvMganfWyOtCMNNXh5uJxRlgf 48u5LyQoonuwFLC7l31ZgX2XvUmoZcpfpZF69CCyGPd81YWLtVW72sT/RrU7AAtDpSOY /5mu/fSGXi2wLSZov3x90cWX9r/u30XhsqPuywmUTey4yUNPFEEnT+/RdvrHNs5InFRZ WJBR6oyYDdkfxGBeWnhnVx7dUD5V99aP+A5HuMov3NNFi7mcDRX8c2JYOVxwN0mGBGNc QxeA== X-Forwarded-Encrypted: i=1; AJvYcCVnTHocgvVt7ekzmYaeBLKCyNHeP8YK8AJ1erfiLgnZ4enJYYY0kznX+B6fabSLMcX80uJuOVSzqRJ1DdQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyWcLT4r0hEt/zGKrzsTx/Ac9MAjIK1jxSgrdXrdAm+XTkbumOu j9yAUQYyYx8Erem+8MuVZja/pYMk68CI657iaiL/X27DleO79MEeEVkdsY6qDWr+kdN7wl5vPWG FfAyba5b5PLOKQ6k0okF/WwoCLS0FtJu1lqtvVQLP2Tpjtbga/FNc07LqU76G1g/zygk= X-Gm-Gg: ATEYQzwxWYqqmqDm2RFs2GB66kdqgrofOxgSs9MUe/SaL6KrC17MLZzUjGq3/upLXR+ 2RLRVw0Y9CtM9ZFV07X42FsNjjueKK9F1RWBtwatrxeT9yP/MT5sGSK+ydghQawj3f3obUCQuLF WMsdyV5Gh93YezagwO935dWZeJ1iICDdUAfDvENSqv8QHRFUrVYVa1E3qvx2nwahs70AQwKYwyD tdawatqzwyEv3t5giiod9D96A79T6slADqqO9av51HxKsekGAcOYUSAvpWxUvWvdcYk5wnNAKL5 jGWyKRBMU26hZT54L3xGQNGiD264Oc11Ak23VHufgpX03tXDDLkOaI/PjxoW3AH4c0nuwJ/Lr6w h+ZvYvdsTclKKce11ibN1eECqwNnKPoINo6Zt8/nCpmeufA4onJ91halzzg/XopneytjAObN89C SeWZM= X-Received: by 2002:ac8:574b:0:b0:509:2c6e:f6e0 with SMTP id d75a77b69052e-50ba39f670dmr19717551cf.8.1774611158919; Fri, 27 Mar 2026 04:32:38 -0700 (PDT) X-Received: by 2002:ac8:574b:0:b0:509:2c6e:f6e0 with SMTP id d75a77b69052e-50ba39f670dmr19717041cf.8.1774611158427; Fri, 27 Mar 2026 04:32:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b9b203c10a0sm240967966b.39.2026.03.27.04.32.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Mar 2026 04:32:37 -0700 (PDT) Message-ID: <2ddea137-bff2-4576-94ed-4f3a48aed386@oss.qualcomm.com> Date: Fri, 27 Mar 2026 12:32:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/17] drm/msm/a6xx: Switch to preemption safe AO counter To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260327-a8xx-gpu-batch2-v2-0-2b53c38d2101@oss.qualcomm.com> <20260327-a8xx-gpu-batch2-v2-3-2b53c38d2101@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260327-a8xx-gpu-batch2-v2-3-2b53c38d2101@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=NenrFmD4 c=1 sm=1 tr=0 ts=69c66ad7 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=wLQHWzgrVt_HrJ2nkkwA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: ujemOe7Ek9lth7BH2Afs22OvTiDgusse X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI3MDA3OSBTYWx0ZWRfX9VGw4JOFGXxY 49H27nRUtskNCSPLo9g7PP5q9e6RGg8GQUWBpP4782KsVn3Iay761HyObyvkI1zVTpQ1nO/x8HT ytTaP9JPHo8504qfM59V7vMTuJMsYQtl4vCxQ9aXz9UI+0kOU1fP0UOGZqDwnPkEmyTtqgRyBRl 8qJ76QBVvUYi6hHZ9Q5twFic1+awSOwHIi5m/x0hyXvkFqfV4OhPwre7ioca1DZ3L83YSYM8Nmy UZV4GpFcYoMxCpLUs/SCv73pPlgZWSdXxG+ibSYFUKW9V47iO+92OV1UMbMeG5oo7a+a7XyIRN0 Hfq+s9wm6N1PGZbEgK03DMTmtc0NL/AptcRj36e36kMoPFm2KPQCHsSCbcbrWCstdI7FkURlFnI IoVfKXtNL6BVNBCGWslsO4FA6vn/gn2lD5gCYRfzKU5C75/eUT/OCuSYdd1gNcfaMMnlCU/CGYs N4TxF5P+7n75FBZatQQ== X-Proofpoint-ORIG-GUID: ujemOe7Ek9lth7BH2Afs22OvTiDgusse X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-26_04,2026-03-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603270079 On 3/27/26 1:13 AM, Akhil P Oommen wrote: > CP_ALWAYS_ON_COUNTER is not save-restored during preemption, so it won't > provide accurate data about the 'submit' when preemption is enabled. > Switch to CP_ALWAYS_ON_CONTEXT which is preemption safe. > > Fixes: e7ae83da4a28 ("drm/msm/a6xx: Implement preemption for a7xx targets") > Signed-off-by: Akhil P Oommen > --- (this is not a blocking comment) would the _COUNTER counter be useful to keep for any other purpose? Konrad