From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757470Ab0KUCqe (ORCPT ); Sat, 20 Nov 2010 21:46:34 -0500 Received: from mail.perches.com ([173.55.12.10]:1700 "EHLO mail.perches.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756851Ab0KUCkV (ORCPT ); Sat, 20 Nov 2010 21:40:21 -0500 From: Joe Perches To: Stephen Hemminger Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 40/62] skge: Use static const Date: Sat, 20 Nov 2010 18:38:41 -0800 Message-Id: <2ddff3ba3e1582bddc3b544dfcd22d8317df59cc.1290305776.git.joe@perches.com> X-Mailer: git-send-email 1.7.3.2.245.g03276.dirty In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Using static const generally increases object text and decreases data size. It also generally decreases overall object size. text data bss dec hex filename 52665 927 12680 66272 102e0 drivers/net/skge.o.new 52730 927 12680 66337 10321 drivers/net/skge.o.old Signed-off-by: Joe Perches --- drivers/net/skge.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 220e039..e9dbe52 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c @@ -1191,7 +1191,7 @@ static void genesis_init(struct skge_hw *hw) static void genesis_reset(struct skge_hw *hw, int port) { - const u8 zero[8] = { 0 }; + static const u8 zero[8] = { 0 }; u32 reg; skge_write8(hw, SK_REG(port, GMAC_IRQ_MSK), 0); @@ -1557,7 +1557,7 @@ static void genesis_mac_init(struct skge_hw *hw, int port) int jumbo = hw->dev[port]->mtu > ETH_DATA_LEN; int i; u32 r; - const u8 zero[6] = { 0 }; + static const u8 zero[6] = { 0 }; for (i = 0; i < 10; i++) { skge_write16(hw, SK_REG(port, TX_MFF_CTRL1), -- 1.7.3.2.245.g03276.dirty