From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pidgin.makrotopia.org (pidgin.makrotopia.org [185.142.180.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5666830C379; Mon, 15 Sep 2025 13:07:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.142.180.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757941625; cv=none; b=WzrtdvxxM6tN31NpZamUMHF3sgIea9iDCx0dWvSy0NU/jGJ7/qpY3ehQXYQJIpD9EAe8kZjQdt3rW807uDYO3cKbM/BhqYLCJkgUqv5WWhj769/LMSvFpmb5n/MVWyhJo9E1igYAk75doGdA0KUfhXQ++lT4k3pLBt0uw1911QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757941625; c=relaxed/simple; bh=cqI0vWHyaYllk7GLbCnmovSdMGEeQZe4ENHZ2aks7AY=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=S06hkOcu/9x09EX0lnwgg3QXPZ7DU8brDo+1xeCBE7anOLH42QCwoYD4DExCG3tFbQPuBzTF0KlR0WUEJSphwN5bmfw3HfUDuiS1k9ESXxh8S7QelWXXZ8N+y3h1WVTntw4vR4djs8icKAUT+0/zKjTZaj9WRyYz8VtZM/7GMZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org; spf=pass smtp.mailfrom=makrotopia.org; arc=none smtp.client-ip=185.142.180.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=makrotopia.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=makrotopia.org Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.98.2) (envelope-from ) id 1uy8uq-000000005ys-1732; Mon, 15 Sep 2025 13:06:44 +0000 Date: Mon, 15 Sep 2025 14:06:37 +0100 From: Daniel Golle To: Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , AngeloGioacchino Del Regno , Daniel Golle , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Yu Jiaoliang , Andy Shevchenko , Changqi Hu , Sam Shih , Steven Liu , John Crispin , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 1/2] tty: serial: 8250_mtk: enable baud clock Message-ID: <2de07b0a6d51d5d3bf3e55cd03cf75adfc91ee7d.1757941345.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Some MediaTek SoCs got a gated UART baud clock, which currently gets disabled as the clk subsystem believes it would be unused. This results in the uart freezing right after "clk: Disabling unused clocks" on those platforms. To fix this request the baud clock to be prepared and enabled during probe. Fixes: e32a83c70cf9 ("serial: 8250-mtk: modify mtk uart power and clock management") Suggested-by: Sam Shih Signed-off-by: Daniel Golle --- v2: no changes drivers/tty/serial/8250/8250_mtk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c index b44de2ed7413..9329ed1f759d 100644 --- a/drivers/tty/serial/8250/8250_mtk.c +++ b/drivers/tty/serial/8250/8250_mtk.c @@ -475,13 +475,13 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p, int dmacnt; #endif - data->uart_clk = devm_clk_get(&pdev->dev, "baud"); + data->uart_clk = devm_clk_get_enabled(&pdev->dev, "baud"); if (IS_ERR(data->uart_clk)) { /* * For compatibility with older device trees try unnamed * clk when no baud clk can be found. */ - data->uart_clk = devm_clk_get(&pdev->dev, NULL); + data->uart_clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(data->uart_clk)) { dev_warn(&pdev->dev, "Can't get uart clock\n"); return PTR_ERR(data->uart_clk); -- 2.51.0