From: "Guido Günther" <agx@sigxcpu.org>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Robert Chiras <robert.chiras@nxp.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Liu Ying <victor.liu@nxp.com>
Subject: [PATCH v5 1/2] phy: core: Use runtime pm during configure too
Date: Fri, 9 Apr 2021 13:40:20 +0200 [thread overview]
Message-ID: <2de2ee26bbf443491dfff1c802f2fa9efaf58d52.1617968250.git.agx@sigxcpu.org> (raw)
In-Reply-To: <cover.1617968250.git.agx@sigxcpu.org>
The phy's configure phase usually needs register access so taking the
device out of pm_runtime suspend looks useful.
There's currently two in tree drivers using runtime pm and .configure
(qualcomm/phy-qcom-qmp.c, rockchip/phy-rockchip-inno-dsidphy.c) but both
don't use the phy layers 'transparent' runtime phy_pm_runtime handling
but manage it manually so this will for now only affect the
phy-fsl-imx8-mipi-dphy driver.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/phy/phy-core.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index ccb575b13777..256a964d52d3 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -470,10 +470,16 @@ int phy_configure(struct phy *phy, union phy_configure_opts *opts)
if (!phy->ops->configure)
return -EOPNOTSUPP;
+ ret = phy_pm_runtime_get_sync(phy);
+ if (ret < 0 && ret != -ENOTSUPP)
+ return ret;
+ ret = 0; /* Override possible ret == -ENOTSUPP */
+
mutex_lock(&phy->mutex);
ret = phy->ops->configure(phy, opts);
mutex_unlock(&phy->mutex);
+ phy_pm_runtime_put(phy);
return ret;
}
EXPORT_SYMBOL_GPL(phy_configure);
--
2.30.1
next prev parent reply other threads:[~2021-04-09 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 11:40 [PATCH v5 0/2] phy: fsl-imx8-mipi-dphy: Hook into runtime pm Guido Günther
2021-04-09 11:40 ` Guido Günther [this message]
2021-04-12 8:40 ` [PATCH v5 1/2] phy: core: Use runtime pm during configure too Liu Ying
2021-04-12 9:41 ` Guido Günther
2021-04-09 11:40 ` [PATCH v5 2/2] phy: fsl-imx8-mipi-dphy: Hook into runtime pm Guido Günther
2021-04-12 9:11 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2de2ee26bbf443491dfff1c802f2fa9efaf58d52.1617968250.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.chiras@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®