From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93691FA372A for ; Wed, 16 Oct 2019 11:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BAE7205F4 for ; Wed, 16 Oct 2019 11:42:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="n4kC1/vi"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SzVPxq8F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbfJPLma (ORCPT ); Wed, 16 Oct 2019 07:42:30 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:55109 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbfJPLm3 (ORCPT ); Wed, 16 Oct 2019 07:42:29 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 1687B5D35; Wed, 16 Oct 2019 07:42:28 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Wed, 16 Oct 2019 07:42:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=IgrN1QKfS6jYUgyH1QxRGDIheSI8XFj +2abRpMvasdw=; b=n4kC1/vi1d8rnCHxmhQauRQQ1pH3HhRA/ID8ocwRJrfEoWe /52vmluZn3rs/O3sQ9b5HA047NyHraXZ8RPVnjZ7oTKixOzWhbJ223j3B084VqdK FF6ltTKDUzG26P99xfWI97MCZ544V0Y5L2x0tTZG+a8vJ0adqymt3VIrbWu+e0Ki PRglS8PodtSfcExFjscpaQuHphc4kyA+l71/mhwXfT4ZI6jAiZs2XQ2lsHlJQ8XM IWaZQy0OQ87b340/5jJ6u+vDucLg2K5bWsst5O4Jnv0d3myLATb7xFp/ovJj6ycF Y6bJBjZ94tH49WppyALypYIaD5kQxjToEEIR4uQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=IgrN1Q KfS6jYUgyH1QxRGDIheSI8XFj+2abRpMvasdw=; b=SzVPxq8Fe+GFeXRBcIhspR 5RYTxwQE2o4PMPiX2x/CDQ4P+9PpQIOAwRSws2P0BHJnIv6inJ7oZvkJu5t6Sq9E jQ+2eUvnvqWCF39AigC1NDKmJ8QXDKDc0ATnb2/6MyATNp7/8wTMld8F0EJe3HUh JJuGU2rYbgktRU6DZ4/B4MsybPLotJey5OyBPeHQnpCMTjoFiLDLSvdrMY9zqGIX Oxcl2MuKJxwgufAR9buBMPGuRe15JhIN7v7LDtZMO/Weug+p1GgIXdRGnkBj6Dk3 TZNOaoXAT6pjNv5nOAqPL1HKvQAjptfWqA1jk4RSKUReImW2Xbxpk+ScVTcBqqUQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrjeehgdeggecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrghrrg hmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushhtvghr ufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 05F06E00A5; Wed, 16 Oct 2019 07:42:26 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-360-g7dda896-fmstable-20191004v2 Mime-Version: 1.0 Message-Id: <2de90789-c374-4821-89f9-5d5f01e7d2d6@www.fastmail.com> In-Reply-To: References: <20191008044153.12734-1-andrew@aj.id.au> Date: Wed, 16 Oct 2019 22:11:48 +1030 From: "Andrew Jeffery" To: "Linus Walleij" Cc: "open list:GPIO SUBSYSTEM" , "Rob Herring" , "Mark Rutland" , "Joel Stanley" , linux-aspeed , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "Linux ARM" , "linux-kernel@vger.kernel.org" , "Johnny Huang" , "Ryan Chen" Subject: Re: [PATCH 0/7] pinctrl: Fixes for AST2600 support Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 16 Oct 2019, at 21:49, Linus Walleij wrote: > On Tue, Oct 8, 2019 at 6:41 AM Andrew Jeffery wrote: > > > This series resolves several issues found in testing by Johnny Huang from > > ASPEED, who also contributed the patches to fix them. We'll have more patches > > from him in the near future (which I'm pretty happy about). > > > > The major issue resolved is the way I grouped the eMMC pins. What I had was > > ugly and I want to get rid of it before the binding is solidified with the 5.4 > > release. > > Should some of these go in with fixes? All of them? Or just some? > I applied them to devel right now (for v5.5). I was hoping to get them into the 5.4 fixes branch: I consider them all fixes - the rework of the eMMC pin groups and functions is a fix for the binding. The rest are fixes for the driver itself. My preference is that they get into a release sooner rather than later. It's there something that makes you think they shouldn't be merged as fixes for 5.4? > > > The remaining fixes are minor issues that stem from lack of documentation or > > understanding on my part, and at least one brain-fart. > > Do they need to go in to v5.4 or not? > > I need a shortlist of anything that should go into v5.4 if anything. IMO all of them should go into 5.4, as above. It's there something I can do in the future to communicate this better? Explicit shortlist in the cover letter? Fixes tags on the relevant patches? Keen to make things easier/more obvious if I can. Cheers, Andrew