mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
To: "Sunil Khatri" <sunil.khatri@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	dri-devel@lists.freedesktop.org
Cc: amd-gfx@lists.freedesktop.org, simona@ffwll.ch,
	tzimmermann@suse.de, tursulin@ursulin.net, phasta@kernel.org,
	dakr@kernel.org, linux-kernel@vger.kernel.org,
	Oded Gabbay <ogabbay@kernel.org>, Jonas Karlman <jonas@kwiboo.se>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Luca Ceresoli <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH v10 1/4] drm: move drm based debugfs funcs to drm_debugfs.c
Date: Fri, 18 Jul 2025 10:51:55 -0600	[thread overview]
Message-ID: <2de96bf3-0c63-4db9-b581-f011bc1446c2@oss.qualcomm.com> (raw)
In-Reply-To: <20250704075548.1549849-2-sunil.khatri@amd.com>

On 7/4/2025 1:55 AM, Sunil Khatri wrote:
> Requirement is to create per client-id based directories to
> hold key debugging information and for that access to
> root debugfs dentry is need which is not in one place
> and that information cannot be stored in drm_device.
> 
> Move the debugfs functionality from drm_drv.c and drm_accel.c
> to drm_debugfs.c This enables debugfs root node reference
> directly drm_debugfs.c and hence enable to create per client-id
> directory.
> 
> v8: Create drm_accel dentry only if it's config is enabled (Jeff, Hugo)
> v8: Merge drm_drv and drm_accel debugfs patches (Koenig, Christian)
> 
> v10: Since we moved drm_debugfs_root, hence to handle drm bridge
> debugfs add a new function which call drm_bridge_debugfs_params where
> drm_debugfs_root is accessible.
> 
> Suggested-by: Christian König <christian.koenig@amd.com>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>

 From the Accel perspective, this seems ok.

Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>

  reply	other threads:[~2025-07-18 16:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  7:55 [PATCH v10 0/4] Enable debugfs information based on client-id Sunil Khatri
2025-07-04  7:55 ` [PATCH v10 1/4] drm: move drm based debugfs funcs to drm_debugfs.c Sunil Khatri
2025-07-18 16:51   ` Jeff Hugo [this message]
2025-07-04  7:55 ` [PATCH v10 2/4] drm: add debugfs support on per client-id basis Sunil Khatri
2025-07-18 16:53   ` Jeff Hugo
2025-07-04  7:55 ` [PATCH v10 3/4] drm/amdgpu: add debugfs support for VM pagetable per client Sunil Khatri
2025-07-04  7:55 ` [PATCH v10 4/4] drm/amdgpu: add support of debugfs for mqd information Sunil Khatri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2de96bf3-0c63-4db9-b581-f011bc1446c2@oss.qualcomm.com \
    --to=jeff.hugo@oss.qualcomm.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=andrzej.hajda@intel.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.ceresoli@bootlin.com \
    --cc=ogabbay@kernel.org \
    --cc=phasta@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=sunil.khatri@amd.com \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®