From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89BD349D588 for ; Mon, 21 Sep 2026 13:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789997128; cv=none; b=U9T4pR0PehfVl+zM7ar9+rEYO2YB2JlpQcZXSysR0np/JFFvPTR6rDze3eymE2JwsyHRC3PMhhGZSNloGFAd60VJAwAa/EQsHDghKR7Kqc+8AtKz0+MgwR+PO6Z6PINq6n2+AQIPTbvu6bU+HrbLb74erTe0qgYeRjea7ksJD2E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789997128; c=relaxed/simple; bh=xYCV9phbnlvr/0RbhoT13i7JK7aS5KJeZrJBgCDDphY=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=BW+DbigbkxxfrXmabg7xE6zCFLTr96Rrp3Ge6pm2qCMiz0FrIbqVtdknvHZkkEFmh0nM6z7HOAJwzFzZgXsIUdcVLqLX9wkQO95B2rJshDJgXoxpWxGFS1bG27s/Duw+B8L6Sne/vLUVT0u6EOD1cp1H1LgQvQtks9KRKaFwWg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YAysZ80G; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YAysZ80G" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9FB91F00898; Mon, 21 Sep 2026 13:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789997127; bh=M5oDiAOnMaNY9o9gZBHcIp39xYWkoqvS23b/muDgRDk=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=YAysZ80GGY8HrTfZgZxkLKTyMtUkedjuankrXPurtWrPEf7G108Gh65GNxThOcjBw iNOhNqXHFF8jmZ3llq1aQp2o6AwAACJlyJiiaMZpEmP+INQwcPAQW4H1P/tIthpyJa S+/UQ7K5CkvWUK6+p/Xl2aCtp+h5cBKi2t+jEs5jTSrFxphT4Imif44/A9gf63WuGK LJ+iA2o1XJqCddAd6HE1dqCgbELHna80cQlILIiZO/f/88kiSFB0ReQQJVW6Od7HZY ILmuQ0osv9ZioFrW28wo4bBye8/iZNSLi0K0oQOUewjMjiqlBe6e4jCpAdrT2XwMxl OhbruLuUYVMag== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id E6143F4006A; Mon, 21 Sep 2026 09:25:25 -0400 (EDT) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Mon, 21 Sep 2026 09:25:25 -0400 X-ME-Sender: X-ME-Proxy-Cause: dmFkZTFTghwdCTVE7krZqSerSRoShUBKmlNU07x1ACHTfcSgbqttKRHqveL+zBZ/WQacFv zzNfajRXFgkQB1Df2r9By94JsuXNjiGws2qD7z0jvKfZqRN1fwTyE6pV7xpo/7548sq1pP SooyRGc1IKlRkQ2o83JzRBjyCHnT/647VTD8mYfG6z4T01+nmAq0OYFMM0SvUPhuYxn9TN ttPhbfGhs6JcfjiGn2LxvrIwWcxXQcL2t5WqgmmOAEPcDe9sSqTLW56uc+ysg81GcLS/Df iaRmQqmafkdccnHkZZoIIU2TgWKXLAjVKyAYuMHjXDu4veISo4KoXLIvkwnuNfUmTbogjD 3yMkjqg1qexd/jIcFlJTuv3EBVegB11kyRkeuYCG6cj1MqmJGlcaSk6X3431/cLLX6ioy1 J14hAzFLYJOJxUTmMxLfOk0AQTp9xk9vWCIln3RPtKxiMLPeZ2VprncYugJy6gGKJmrLC5 G49rDl0qzMlLjjez8chHbkox+h58QoYplncMNqxfsPX0VIoxQ6TNT1vBxfwTUZgYsLYiIC +kQOVUz7vehLMRT9mUXCOrx5jyt6ss24gkXaGsdjnF4BIGDjaQzdCl5Pq7BDB+kELxpnL3 rjLt1J/JGV7UlXECNgjdPtgvdKPm61/HL+1bS0rtvcqAjDPtQKzW5ih1Q5Hw X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id BEDBF780076; Mon, 21 Sep 2026 09:25:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AFQlgKekMDrg Date: Mon, 21 Sep 2026 09:24:56 -0400 From: "Chuck Lever" To: "Peng Fan (OSS)" Cc: "Jeff Layton" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "Trond Myklebust" , "Anna Schumaker" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" , linux-kernel@vger.kernel.org, "Peng Fan" , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Message-Id: <2df127da-42fe-4b35-8199-5953f6dd01d3@app.fastmail.com> In-Reply-To: References: <20260920022714.3145751-1-peng.fan@oss.nxp.com> <7c7d7b6a-38a9-477e-9bcd-1f9c53a160c5@app.fastmail.com> Subject: Re: [PATCH] SUNRPC: use assign_bit() where applicable Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sun, Sep 20, 2026, at 8:51 PM, Peng Fan wrote: > On Sun, Sep 20, 2026 at 01:22:00PM -0400, Chuck Lever wrote: >> >> >>On Sat, Sep 19, 2026, at 10:27 PM, Peng Fan (OSS) wrote: >>> From: Peng Fan >>> >>> Convert open-coded if/else with set_bit/clear_bit the assign_bit API. >> >>The above sentence explains the same thing that the diff body shows me, >>so it does not add value. >> >>But I don't have any context here: why is this being done? Is there some >>kind of tree-wide clean-up underway so that a new feature can be added, >>or is this patch just a one-off change? > > It is just a one-off change. I don't group other patches to use assign_bit() > into a large patchset, just separate patches. > > Free to drop if it does not make sense to you. It makes sense. But I'd rather not make assumptions. -- Chuck Lever (Come to NFS bake-a-thon! https://nfsv4bat.org)