From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.228 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793986035; b=ev/mml45K2NeQlr0hyYE4t0OE/AcoKzLvPe7WnJzCK4lFNp3JGpZQE4l+5wdZVPLIUZS fg55knT9W4zRDNTXKpkCQFzelKDrxH3uXBQMs1u8YhoQCvSXJM6HmChoh5WhLOaBJ0mNj b79NhEtoi1aeHkEwQF+qkQyN1NhdC9b9dSJc5zNCAMpXWR95PLr/l97qRfrv5sbgx9y7J D9Derc+qX6cFVefwzclWNkLAa2g5sWtDwtFZgS/XKJWGjPWRdmcXwzp55uKaboiJwhP14 29u4SIlCeUukZtkAlH7pWQXHcbSGb/HsblXaUnszseJ3sjWrb95rd005N7bRHFCRkXw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793986035; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:MIME-Version:Date:Content-Type: Content-Transfer-Encoding:From:Message-ID:TLS-Required:Subject:To:Cc: In-Reply-To:References; bh=Ph5YKB0KYtns94WSrNcsTtEuW7NVt+Gyk8TBrJACobE=; b=3LNREQc0JBGkjr3YBvb9fAX9LHjgenAAvPlRm1KUHgC4aJmCz+vsNLU9DjGWt7yPFJWZ gLZqwf4zIuslGBbtEhXPfW2u7dCp2RNvJoMiSmxEBCbqmDSPnA5DRub8kHKC1c6aDEXUO wl0BPNYGWLTx1wlMUcPs+bSRb5Nxi2qDsy1rHKt1W8Pv7+71idjI6Chnfay1YpZLvfAv9 sVfvqUuWgaOCMG39w+JRTavNLMwz1bEVKbWWFSx/1iu51C5RMXuW7beqbFWF427F7vHto 53Ori4BS2HScgpDxWDrTwwcZKXUfHjGR3Yl7AUAlFdEWfEJutF3zgpSED5cYPLIP/RA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=hgSVEB7r; arc=none smtp.remote-ip=95.215.58.228 Received: from mta1.migadu.com (out-228.mta1.migadu.com [95.215.58.228]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 914A7606A326 for ; Fri, 6 Nov 2026 17:27:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 914A7606A326 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=hgSVEB7r X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=U0fucB1f/JzZvNxYUiDjoItugCcDyDJ/lZcOOVQKZRg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1793986032; v=1; x=1794590832; b=hgSVEB7rRJYAJOe33KgdU+0UI+mlhTCvb1qRN1ATMN0NyFo3L/5A/LrqQtEtGPocdf3Xd5cT MM5HarHWTM2zE17+P05VIEukMwc6XEjv8uI1z/g+dwkitqKoPNmPMOU65+rWOuqizk+rIIQnONe zhBem5bLPqA9YuRv59bFVp6Q= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 12b6b9dc5f411ab5; Fri, 06 Nov 2026 17:27:12 +0000 X-Mizu-Trace-ID: 12b6b9dc5f411ab5 X-Migadu-Flow: FLOW_OUT X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Date: Fri, 06 Nov 2026 17:27:11 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: "Luka Gejak" Message-ID: <2df200abb7d9b07abf8883fcc06f4a7b0d3591c5@linux.dev> TLS-Required: No Subject: Re: [PATCH rtw-next v2 5/7] wifi: rtw88: 88xxa: correct carrier-frequency offset To: "Ho Jie Feng" , "Ping-Ke Shih" Cc: linux-wireless@vger.kernel.org, "Ho Jie Feng" , linux-kernel@vger.kernel.org In-Reply-To: <20261031070950.425176-6-hjf3108@gmail.com> References: <20261031070950.425176-1-hjf3108@gmail.com> <20261031070950.425176-6-hjf3108@gmail.com> Hi Jie Feng, A few small comments below. October 31, 2026 at 8:09 AM, "Ho Jie Feng" wrote: > diff --git a/drivers/net/wireless/realtek/rtw88/phy.c b/drivers/net/wir= eless/realtek/rtw88/phy.c > index d0c1fb65be9563c5fc29a7d18a1c9e8589730b10..69998c0d7c1f851bb30d270= 2233d62e14b305bf0 100644 > --- a/drivers/net/wireless/realtek/rtw88/phy.c > +++ b/drivers/net/wireless/realtek/rtw88/phy.c > @@ -687,13 +687,14 @@ static void rtw_phy_parsing_cfo_iter(void *data, = u8 *mac, > struct rtw_rx_pkt_stat *pkt_stat =3D iter_data->pkt_stat; > struct rtw_dm_info *dm_info =3D &rtwdev->dm_info; > struct rtw_cfo_track *cfo =3D &dm_info->cfo_track; > + u8 path_num =3D min_t(u8, rtwdev->hal.rf_path_num, 2); This and the same line in rtw_phy_cfo_xcap_track() are in core code that every chip uses. As far as I can see the limit is only there for 8814a, which has four paths but reports a CFO tail only for A and B. A short comment saying so would help, otherwise the 2 looks arbitrary. The commit message could mention this core change too, together with the CFO tracking for 8814a that this patch adds. [ ... ] > diff --git a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c b/drivers/ne= t/wireless/realtek/rtw88/rtw88xxa.c > index 87253fffe78cd6f5b58a325eef42b58b968e2d46..851d198f76f3b10d5ba77c7= e07e4be9d7fd54e4b 100644 > --- a/drivers/net/wireless/realtek/rtw88/rtw88xxa.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw88xxa.c > @@ -279,6 +279,7 @@ int rtw88xxa_read_efuse(struct rtw_dev *rtwdev, u8 = *log_map) > efuse->crystal_cap =3D map->xtal_k; > if (efuse->crystal_cap =3D=3D 0xff) > efuse->crystal_cap =3D 0x20; > + efuse->crystal_cap &=3D 0x3F; [ ... ] > + rtw88xxa_set_crystal_cap(rtwdev, rtwdev->efuse.crystal_cap & 0x3F= ); With the mask in rtw88xxa_read_efuse() the & 0x3F here isn't needed anymore. The 6 bit limit now shows up as 0x3F or 0x3f in five places across rtw88xxa.c and rtw8814a.c. Maybe a define in rtw88xxa.h, which rtw8814a.c includes too, similar to XCAP_MASK in rtw8822c.h. Best regards, Luka Gejak